Issue 891654  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e14722dd9a8f8ba2a18703fa317d5970ae2ddc21

commit e14722dd9a8f8ba2a18703fa317d5970ae2ddc21
Author: Julie Jeongeun Kim <jkim@igalia.com>
Date: Thu Oct 25 07:36:28 2018

Move the APIs using XRANR to ui/base/x folder

It creates x11_display_util.cc/h files and moves the APIs to
get display information using XRANR from DesktopScreenX11 to
share the implementation with Ozone/X11.

'GetXrandrVersion' is to get xrandr version,
'GetFallbackDisplayList' is to get a fallback display and
'BuildDisplaysFromXRandRInfo' is to get a list of displays from
the current screen.

It also moves 'GetICCProfileForMonitor' from DesktopScreenX11
to x11_util.cc.

These APIs are required for Ozone/X11 as well. This change doesn't
bring any behavioral changes.

Bug: 891175
Change-Id: Idb42b1929b7bfab4501ced4403fc176342ebdada
Reviewed-on: https://chromium-review.googlesource.com/c/1295762
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602634}
[modify] https://crrev.com/e14722dd9a8f8ba2a18703fa317d5970ae2ddc21/ui/base/x/BUILD.gn
[add] https://crrev.com/e14722dd9a8f8ba2a18703fa317d5970ae2ddc21/ui/base/x/x11_display_util.cc
[add] https://crrev.com/e14722dd9a8f8ba2a18703fa317d5970ae2ddc21/ui/base/x/x11_display_util.h
[modify] https://crrev.com/e14722dd9a8f8ba2a18703fa317d5970ae2ddc21/ui/base/x/x11_util.cc
[modify] https://crrev.com/e14722dd9a8f8ba2a18703fa317d5970ae2ddc21/ui/base/x/x11_util.h
[modify] https://crrev.com/e14722dd9a8f8ba2a18703fa317d5970ae2ddc21/ui/views/widget/desktop_aura/desktop_screen_x11.cc
[modify] https://crrev.com/e14722dd9a8f8ba2a18703fa317d5970ae2ddc21/ui/views/widget/desktop_aura/desktop_screen_x11.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce2d6b8e20914c72107ec33ca48052e69ddc7cc8

commit ce2d6b8e20914c72107ec33ca48052e69ddc7cc8
Author: Marc Treib <treib@chromium.org>
Date: Thu Oct 25 08:15:30 2018

Revert "Move the APIs using XRANR to ui/base/x folder"

This reverts commit e14722dd9a8f8ba2a18703fa317d5970ae2ddc21.

Reason for revert: Looks like this broke compile on linux-chromeos-dbg:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/8497

Original change's description:
> Move the APIs using XRANR to ui/base/x folder
> 
> It creates x11_display_util.cc/h files and moves the APIs to
> get display information using XRANR from DesktopScreenX11 to
> share the implementation with Ozone/X11.
> 
> 'GetXrandrVersion' is to get xrandr version,
> 'GetFallbackDisplayList' is to get a fallback display and
> 'BuildDisplaysFromXRandRInfo' is to get a list of displays from
> the current screen.
> 
> It also moves 'GetICCProfileForMonitor' from DesktopScreenX11
> to x11_util.cc.
> 
> These APIs are required for Ozone/X11 as well. This change doesn't
> bring any behavioral changes.
> 
> Bug: 891175
> Change-Id: Idb42b1929b7bfab4501ced4403fc176342ebdada
> Reviewed-on: https://chromium-review.googlesource.com/c/1295762
> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
> Reviewed-by: Dan Erat <derat@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#602634}

TBR=derat@chromium.org,thomasanderson@chromium.org,jkim@igalia.com

Change-Id: Iad00d2464056bd21b337fef2ca07145845a82e6f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 891175
Reviewed-on: https://chromium-review.googlesource.com/c/1298205
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602643}
[modify] https://crrev.com/ce2d6b8e20914c72107ec33ca48052e69ddc7cc8/ui/base/x/BUILD.gn
[delete] https://crrev.com/35cfc1aed4eb74a8351902ae3a24cb630cb1b83b/ui/base/x/x11_display_util.cc
[delete] https://crrev.com/35cfc1aed4eb74a8351902ae3a24cb630cb1b83b/ui/base/x/x11_display_util.h
[modify] https://crrev.com/ce2d6b8e20914c72107ec33ca48052e69ddc7cc8/ui/base/x/x11_util.cc
[modify] https://crrev.com/ce2d6b8e20914c72107ec33ca48052e69ddc7cc8/ui/base/x/x11_util.h
[modify] https://crrev.com/ce2d6b8e20914c72107ec33ca48052e69ddc7cc8/ui/views/widget/desktop_aura/desktop_screen_x11.cc
[modify] https://crrev.com/ce2d6b8e20914c72107ec33ca48052e69ddc7cc8/ui/views/widget/desktop_aura/desktop_screen_x11.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be448bda12f9fcd500500d59c394f21b6849e0a4

commit be448bda12f9fcd500500d59c394f21b6849e0a4
Author: Julie Jeongeun Kim <jkim@igalia.com>
Date: Sat Oct 27 00:03:43 2018

Reland "Move the APIs using XRANR to ui/base/x folder"

This is a reland of e14722dd9a8f8ba2a18703fa317d5970ae2ddc21

Original change's description:
> Move the APIs using XRANR to ui/base/x folder
> 
> It creates x11_display_util.cc/h files and moves the APIs to
> get display information using XRANR from DesktopScreenX11 to
> share the implementation with Ozone/X11.
> 
> 'GetXrandrVersion' is to get xrandr version,
> 'GetFallbackDisplayList' is to get a fallback display and
> 'BuildDisplaysFromXRandRInfo' is to get a list of displays from
> the current screen.
> 
> It also moves 'GetICCProfileForMonitor' from DesktopScreenX11
> to x11_util.cc.
> 
> These APIs are required for Ozone/X11 as well. This change doesn't
> bring any behavioral changes.
> 
> Bug: 891175
> Change-Id: Idb42b1929b7bfab4501ced4403fc176342ebdada
> Reviewed-on: https://chromium-review.googlesource.com/c/1295762
> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
> Reviewed-by: Dan Erat <derat@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#602634}

Bug: 891175
Change-Id: I742eec8285b023adda84d28d68a21f7545a87f8c
Reviewed-on: https://chromium-review.googlesource.com/c/1301036
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603262}
[modify] https://crrev.com/be448bda12f9fcd500500d59c394f21b6849e0a4/ui/base/x/BUILD.gn
[add] https://crrev.com/be448bda12f9fcd500500d59c394f21b6849e0a4/ui/base/x/x11_display_util.cc
[add] https://crrev.com/be448bda12f9fcd500500d59c394f21b6849e0a4/ui/base/x/x11_display_util.h
[modify] https://crrev.com/be448bda12f9fcd500500d59c394f21b6849e0a4/ui/base/x/x11_util.cc
[modify] https://crrev.com/be448bda12f9fcd500500d59c394f21b6849e0a4/ui/base/x/x11_util.h
[modify] https://crrev.com/be448bda12f9fcd500500d59c394f21b6849e0a4/ui/display/util/BUILD.gn
[modify] https://crrev.com/be448bda12f9fcd500500d59c394f21b6849e0a4/ui/views/widget/desktop_aura/desktop_screen_x11.cc
[modify] https://crrev.com/be448bda12f9fcd500500d59c394f21b6849e0a4/ui/views/widget/desktop_aura/desktop_screen_x11.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24f9819d144cc752942695b33bd20d810b76570c

commit 24f9819d144cc752942695b33bd20d810b76570c
Author: Julie Jeongeun Kim <jkim@igalia.com>
Date: Fri Nov 02 03:01:08 2018

[ozone/x11] Add initial X11ScreenOzone implementation

It adds X11ScreenOzone for PlatformScreen which has basic
implementation.

When it creates PlatformScreen for Ozone/X11, X11ScreenOzone
is created and it creates X11DisplayFetcherOzone, which
communicates with 'x11::xrandr'. The way to get display
information in X11DisplayFetcherOzone is similar to
DesktopScreenX11. Once it builds display information from
'x11::xrandr', it adds the information to display list from
X11ScreenOzone.

This patch also moves 'GetICCProfileForMonitor' to x11_util.cc
to share it with X11ScreenOzone.

Bug: 891175
Test: ozone_x11_unittests
Change-Id: I2d901f72ca2d9609ef19eef7da35bf99aec62d2a
Reviewed-on: https://chromium-review.googlesource.com/c/1293290
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#604826}
[modify] https://crrev.com/24f9819d144cc752942695b33bd20d810b76570c/ui/base/x/BUILD.gn
[modify] https://crrev.com/24f9819d144cc752942695b33bd20d810b76570c/ui/display/util/BUILD.gn
[modify] https://crrev.com/24f9819d144cc752942695b33bd20d810b76570c/ui/ozone/platform/x11/BUILD.gn
[modify] https://crrev.com/24f9819d144cc752942695b33bd20d810b76570c/ui/ozone/platform/x11/ozone_platform_x11.cc
[add] https://crrev.com/24f9819d144cc752942695b33bd20d810b76570c/ui/ozone/platform/x11/x11_display_fetcher_ozone.cc
[add] https://crrev.com/24f9819d144cc752942695b33bd20d810b76570c/ui/ozone/platform/x11/x11_display_fetcher_ozone.h
[add] https://crrev.com/24f9819d144cc752942695b33bd20d810b76570c/ui/ozone/platform/x11/x11_screen_ozone.cc
[add] https://crrev.com/24f9819d144cc752942695b33bd20d810b76570c/ui/ozone/platform/x11/x11_screen_ozone.h
[add] https://crrev.com/24f9819d144cc752942695b33bd20d810b76570c/ui/ozone/platform/x11/x11_screen_ozone_unittest.cc

*** Mass UI Triage ***

As Fix is landed, Closing the bug as a part of UI mass triage. If you feel this issue should still be addressed, feel free to reopen it or to file a new issue.

This hasn’t been completed yet. Reopened