New issue
Advanced search Search tips

Issue 891173 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug
Flaky-Test: PaymentRequestShippingAddressEditorTest.RetryWithShippingAddressErrors_HasSameValueButDifferentErrorsShown

Blocking:
issue 861704



Sign in to add a comment

PaymentRequestShippingAddressEditorTest.RetryWithShippingAddressErrors_HasSameValueButDifferentErrorsShown is flaky

Project Member Reported by Findit, Oct 2

Issue description


Flaky test: PaymentRequestShippingAddressEditorTest.RetryWithShippingAddressErrors_HasSameValueButDifferentErrorsShown
Sample failed build due to flakiness: https://chromium-swarm.appspot.com/task?id=404b8ae24af9c910
Test output log: https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/71948
Culprit (70.0% confidence): https://chromium-review.googlesource.com/q/I2cb94772485165d1fa96463f16f39edf20ccf7bc
Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyjAILEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCLVAWNocm9taXVtLndpbi9XaW43IFRlc3RzIChkYmcpKDEpLzcxOTQ4L25ldHdvcmtfc2VydmljZV9icm93c2VyX3Rlc3RzL1VHRjViV1Z1ZEZKbGNYVmxjM1JUYUdsd2NHbHVaMEZrWkhKbGMzTkZaR2wwYjNKVVpYTjBMbEpsZEhKNVYybDBhRk5vYVhCd2FXNW5RV1JrY21WemMwVnljbTl5YzE5SVlYTlRZVzFsVm1Gc2RXVkNkWFJFYVdabVpYSmxiblJGY25KdmNuTlRhRzkzYmc9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM

Please revert the culprit, or disable the test and find the appropriate owner.

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20PaymentRequestShippingAddressEditorTest.RetryWithShippingAddressErrors_HasSameValueButDifferentErrorsShown&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyjAILEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCLVAWNocm9taXVtLndpbi9XaW43IFRlc3RzIChkYmcpKDEpLzcxOTQ4L25ldHdvcmtfc2VydmljZV9icm93c2VyX3Rlc3RzL1VHRjViV1Z1ZEZKbGNYVmxjM1JUYUdsd2NHbHVaMEZrWkhKbGMzTkZaR2wwYjNKVVpYTjBMbEpsZEhKNVYybDBhRk5vYVhCd2FXNW5RV1JrY21WemMwVnljbTl5YzE5SVlYTlRZVzFsVm1Gc2RXVkNkWFJFYVdabVpYSmxiblJGY25KdmNuTlRhRzkzYmc9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM
 
Cc: jinho.b...@samsung.com
Owner: rouslan@chromium.org
Status: Assigned (was: Untriaged)
https://chromium-review.googlesource.com/c/chromium/src/+/1255082 modified the affected test. Since this CL is fixing a memory leak, I'm not reverting it. rouslan@ or jinho.bang@ can you take a look? Thanks!
Blocking: 861704
Cc: -jinho.b...@samsung.com rouslan@chromium.org
Components: UI>Browser>Payments Tests>Flaky
Labels: OS-Windows
Owner: jinho.b...@samsung.com
Jinho: Please investigate what is causing the test flake. Thank you.
 Issue 891170  has been merged into this issue.
Test appears to be crash-flaking on Linux (dbg), Linux MSAN, win-asan, and Win7 (dbg). Partial stack from example failure on Win7 (dbg) (https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8933818904421749280/+/steps/network_service_browser_tests/0/logs/PaymentRequestShippingAddressEditorTest.RetryWithShippingAddressErrors_HasSameValueButDifferentErrorsShown/0):

[ RUN      ] PaymentRequestShippingAddressEditorTest.RetryWithShippingAddressErrors_HasSameValueButDifferentErrorsShown
  [4128:4296:1001/184341.606:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062
  [4128:1236:1001/184341.699:WARNING:chrome_browser_main_win.cc(647)] Command line too long for RegisterApplicationRestart: [snipped by smcgruer@]
  [5808:4532:1001/184342.636:INFO:media_foundation_video_encode_accelerator_win.cc(347)] Windows versions earlier than 8 are not supported.
  [4128:1236:1001/184342.847:WARNING:gaia_auth_fetcher.cc(858)] Could not reach Google Accounts servers: errno -11
  [4128:1236:1001/184343.848:WARNING:gaia_auth_fetcher.cc(858)] Could not reach Google Accounts servers: errno -11
  [4128:1440:1001/184344.781:WARNING:embedded_test_server.cc(239)] Request not handled. Returning 404: /favicon.ico
  [4128:1236:1001/184345.183:ERROR:textfield.cc(1762)] NOT IMPLEMENTED
  Received fatal exception EXCEPTION_ACCESS_VIOLATION
  Backtrace:
  	views::View::SchedulePaint [0x6B4127CC+60]
  	views::View::SchedulePaintBoundsChanged [0x6B4132BD+61]
  	views::View::SetBoundsRect [0x6B412FC6+518]
  	views::BoundsAnimator::AnimationProgressed [0x6B2C0C4D+653]
  	gfx::LinearAnimation::Step [0x6ACE9058+376]
  	gfx::AnimationContainer::Run [0x6ACE3524+452]


ASAN equivalent:

PaymentRequestShippingAddressEditorTest.RetryWithShippingAddressErrors
  [7752:7276:1002/002544.602:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062
  [7752:4216:1002/002544.930:WARNING:chrome_browser_main_win.cc(647)] Command line too long for RegisterApplicationRestart: [snipped by smcgruer@]
  [7752:3964:1002/002548.258:WARNING:embedded_test_server.cc(239)] Request not handled. Returning 404: /favicon.ico
  [7752:4216:1002/002549.046:ERROR:textfield.cc(1762)] NOT IMPLEMENTED
  =================================================================
  ==7752==ERROR: AddressSanitizer: heap-use-after-free on address 0x12f6718da368 at pc 0x7ff72913b7f1 bp 0x00f9485c9480 sp 0x00f9485c94c8
  READ of size 4 at 0x12f6718da368 thread T0
  ==7752==*** WARNING: Failed to initialize DbgHelp!              ***
  ==7752==*** Most likely this means that the app is already      ***
  ==7752==*** using DbgHelp, possibly with incompatible flags.    ***
  ==7752==*** Due to technical reasons, symbolization might crash ***
  ==7752==*** or produce wrong results.                           ***
      #0 0x7ff72913b7f0 in views::BoundsAnimator::AnimationProgressed C:\b\swarming\w\ir\cache\builder\src\ui\views\animation\bounds_animator.cc:228
      #1 0x7ff729604ec6 in gfx::LinearAnimation::Step C:\b\swarming\w\ir\cache\builder\src\ui\gfx\animation\linear_animation.cc:90
      #2 0x7ff72d524b89 in gfx::AnimationContainer::Run C:\b\swarming\w\ir\cache\builder\src\ui\gfx\animation\animation_container.cc:91
      #3 0x7ff728273956 in base::RepeatingTimer::RunUserTask C:\b\swarming\w\ir\cache\builder\src\base\timer\timer.cc:302
      #4 0x7ff728272aa9 in base::internal::BaseTimerTaskInternal::Run C:\b\swarming\w\ir\cache\builder\src\base\timer\timer.cc:49


Please investigate + fix. If test continues to flake it will be disabled on those platforms.
The fix is in the CQ.
I already reverted my patch when this happens:
https://chromium-review.googlesource.com/c/chromium/src/+/1256394

Also, I'm already sent a reland patch here:
https://chromium-review.googlesource.com/c/chromium/src/+/1258813
Awesome, thank you very much for your proactive work fixing this! :)
Thank you and sorry for making this issue.
Status: Fixed (was: Assigned)

Sign in to add a comment