New issue
Advanced search Search tips

Issue 891166 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Columned content is reverse scrolled in block with position:sticky inside absolute positioned block

Reported by korens...@s25.ru, Oct 2

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3561.0 Safari/537.36

Steps to reproduce the problem:
1. Go to https://jsfiddle.net/dizzy2/oqbnchsy/6/
2. Scroll result page

What is the expected behavior?
Content must be inside a block with position: absolute

What went wrong?
Content must be inside a block with position: absolute

Did this work before? Yes 69.0.3497.100

Does this work in other browsers? Yes

Chrome version: 71.0.3561.0  Channel: canary
OS Version: OS X 10.13.6
Flash Version:
 
reverse_scroll.html
1.2 KB View Download
screencast 2018-10-02 14-49-38.mp4
271 KB View Download
Bisected to r590578 / 8661a7c51be77ca3e6a154e7fbade0b799eb6d9f
"[Blink/BGPT+SPv2] Implement sticky position as transform node"
Landed in 71.0.3551.0
Labels: Needs-Bisect Needs-Triage-M71
Cc: pdr@chromium.org
Labels: -Pri-2 -Needs-Bisect RegressedIn-71 ReleaseBlock-Stable Triaged-ET Target-71 M-71 FoundIn-71 hasbisect OS-Linux OS-Windows Pri-1
Owner: trchen@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 10, mac 10.13.6 and Ubuntu 14.04 using chrome reported version #71.0.3561.0 and latest canary #71.0.3568.0.

Bisect Information:
=====================
Good build: 71.0.3550.0
Bad Build : 71.0.3551.0

As per comment #1, suspecting the following Change log url:
https://chromium.googlesource.com/chromium/src/+/8661a7c51be77ca3e6a154e7fbade0b799eb6d9f
From the above change log suspecting below change:
Change-Id: I6706f09e26ca4549f58500e45153970edfcedc28
Reviewed-on: https://chromium-review.googlesource.com/1208449

trchen@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
Note: Adding stable blocker for M-71 as it seems to be a recent regression. Please feel free to remove the same if not appropriate.
ccing the reviewver of the issue as the author's chromium id is being reflected as Last visit 18 days ago.

Thanks...!!
Seems trchen@ is not available for the past 23 days, @pdr could you please take a look and update the thread accordingly as it is marked as stable blocker.

Thanks..!
Owner: pdr@chromium.org
Here's a reduced testcase:
-------------------8<-------------------
<!doctype html>
<style>
  body { background: lightblue; height: 10000px; }
</style>
<div id="wrapper" style="position: sticky; top: 10px;">
  <div id="columncontainer" style="width: 100px; height: 100px; background: lightgreen; columns: 2;">
    <span id="content">a</span>
  </div>
</div>
-------------------8<-------------------

To reproduce on a highdpi display, launch chrome with --disable-prefer-compositing-to-lcd-text
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/924ee417da6a59627240992516fbf3767199e7cb

commit 924ee417da6a59627240992516fbf3767199e7cb
Author: Philip Rogers <pdr@chromium.org>
Date: Mon Oct 08 23:55:40 2018

Create paint offset transform for sticky

Sticky positioning should reset the paint offset transform. This is
needed for the same reason we require a paint offset translation for
CSS transform or scroll: paint offsets must be relative to the
containing transform, because the inputs to GeometryMapper are in such
a space.

Bug:  891166 
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I5b142d8915bd3176596a81eb4e73645fa99d2d23
Reviewed-on: https://chromium-review.googlesource.com/c/1269516
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597741}
[add] https://crrev.com/924ee417da6a59627240992516fbf3767199e7cb/third_party/WebKit/LayoutTests/fast/css/sticky/sticky-as-column-container-expected.html
[add] https://crrev.com/924ee417da6a59627240992516fbf3767199e7cb/third_party/WebKit/LayoutTests/fast/css/sticky/sticky-as-column-container.html
[modify] https://crrev.com/924ee417da6a59627240992516fbf3767199e7cb/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc

Status: Fixed (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d365ad173d614976944b236c32f993d290b43dee

commit d365ad173d614976944b236c32f993d290b43dee
Author: Philip Rogers <pdr@chromium.org>
Date: Thu Oct 11 00:21:51 2018

Convert multicolumn sticky test to a WPT test

In https://crrev.com/597741 I landed a regular layout test for
multicolumn under position: sticky but this should have been a WPT test.
This patch makes everything right again with a brand new WPT test:
  css/position/position-sticky-child-multicolumn.html

Bug:  891166 
Change-Id: I85e774ad0f307d98f7dbfbf7aa86227f4d34ea6b
Reviewed-on: https://chromium-review.googlesource.com/c/1272021
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598585}
[add] https://crrev.com/d365ad173d614976944b236c32f993d290b43dee/third_party/WebKit/LayoutTests/external/wpt/css/css-position/position-sticky-child-multicolumn-ref.html
[add] https://crrev.com/d365ad173d614976944b236c32f993d290b43dee/third_party/WebKit/LayoutTests/external/wpt/css/css-position/position-sticky-child-multicolumn.html
[delete] https://crrev.com/cd822890e0a76894df50c6c3647b94641bcc94aa/third_party/WebKit/LayoutTests/fast/css/sticky/sticky-as-column-container-expected.html
[delete] https://crrev.com/cd822890e0a76894df50c6c3647b94641bcc94aa/third_party/WebKit/LayoutTests/fast/css/sticky/sticky-as-column-container.html

Sign in to add a comment