Issue metadata
Sign in to add a comment
|
virtual/user-activation-v2/fast/events/middleClickAutoscroll-drag.html is flaky |
||||||||||||||||||||
Issue descriptionFlaky test: virtual/user-activation-v2/fast/events/middleClickAutoscroll-drag.html Sample failed build due to flakiness: https://chromium-swarm.appspot.com/task?id=404ba7bfe03bdd10 Test output log: https://ci.chromium.org/buildbot/chromium.linux/linux-xenial-rel/3800 Culprit (70.0% confidence): https://chromium-review.googlesource.com/q/Ic5acb4367dd406de3e5897063bfe6b1b44e7daa6 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy4AELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKpAWNocm9taXVtLmxpbnV4L2xpbnV4LXhlbmlhbC1yZWwvMzgwMC93ZWJraXRfbGF5b3V0X3Rlc3RzIG9uIFVidW50dS0xNi4wNC9kbWx5ZEhWaGJDOTFjMlZ5TFdGamRHbDJZWFJwYjI0dGRqSXZabUZ6ZEM5bGRtVnVkSE12Yldsa1pHeGxRMnhwWTJ0QmRYUnZjMk55YjJ4c0xXUnlZV2N1YUhSdGJBPT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20virtual/user-activation-v2/fast/events/middleClickAutoscroll-drag.html&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy4AELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKpAWNocm9taXVtLmxpbnV4L2xpbnV4LXhlbmlhbC1yZWwvMzgwMC93ZWJraXRfbGF5b3V0X3Rlc3RzIG9uIFVidW50dS0xNi4wNC9kbWx5ZEhWaGJDOTFjMlZ5TFdGamRHbDJZWFJwYjI0dGRqSXZabUZ6ZEM5bGRtVnVkSE12Yldsa1pHeGxRMnhwWTJ0QmRYUnZjMk55YjJ4c0xXUnlZV2N1YUhSdGJBPT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA
,
Oct 2
sahel@, please see this CL as you look into this regression: https://chromium-review.googlesource.com/c/chromium/src/+/1213864 It is landing soon (once bots pass) and it changes the middleClick tests also. (I had to rebase around your change and the revert of your change.) Within the change to middleClickAutoscroll.js, the only important thing in my CL is the call to setAnimationRequiresRaster(). The rest is a half-hearted attempt to refactor that code, and from the looks of it, I like yours better. But you'll need to keep the setAnimationRequiresRaster() calls within the middleClick layout tests as you're trying to land yours. That will be required as I enable the --enable-display-compositor-pixel-dumps flag by default for all layout tests. Just FYI.
,
Oct 12
Issue 895011 has been merged into this issue.
,
Oct 12
Issue 895028 has been merged into this issue.
,
Oct 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd0a91a683352c0ce22ebcb6d29f9dda8fec1ede commit fd0a91a683352c0ce22ebcb6d29f9dda8fec1ede Author: Chan <chanli@chromium.org> Date: Fri Oct 12 23:55:32 2018 Mark 'virtual/mouseevent_fractional/fast/events/middleClickAutoscroll-drag.html' and 'virtual/mouseevent_fractional/fast/events/middleClickAutoscroll-event-fired.html' as flaky on Linux. TBR=wjmaclean@chromium.org Bug: 891155 Change-Id: I96caff6f340cff118f10cca35da669a091257153 Reviewed-on: https://chromium-review.googlesource.com/c/1279240 Reviewed-by: Chan Li <chanli@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#599426} [modify] https://crrev.com/fd0a91a683352c0ce22ebcb6d29f9dda8fec1ede/third_party/WebKit/LayoutTests/TestExpectations
,
Oct 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd9e6519393984fdf436e390db41828e5f9a9591 commit cd9e6519393984fdf436e390db41828e5f9a9591 Author: Chan <chanli@chromium.org> Date: Sat Oct 13 00:59:00 2018 Mark 'virtual/user-activation-v2/fast/events/middleClickAutoscroll-event-fired.html' as flaky. TBR=wjmaclean@chromium.org Bug: 891155 Change-Id: Id891da58b6e97073eef261ce37ccda9819caa097 Reviewed-on: https://chromium-review.googlesource.com/c/1278219 Reviewed-by: Chan Li <chanli@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#599453} [modify] https://crrev.com/cd9e6519393984fdf436e390db41828e5f9a9591/third_party/WebKit/LayoutTests/TestExpectations
,
Oct 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b10b8f337d82162ed428c38dac3f5a0bbfe87abe commit b10b8f337d82162ed428c38dac3f5a0bbfe87abe Author: Chan <chanli@chromium.org> Date: Mon Oct 15 18:32:11 2018 Mark 'fast/events/middleClickAutoscroll-event-fired.html' as flaky. TBR=wjmaclean@chromium.org Bug: 891155 Change-Id: I149449fe0f847f23edc5b0565c76c5ace3c79afd Reviewed-on: https://chromium-review.googlesource.com/c/1281049 Reviewed-by: Chan Li <chanli@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#599687} [modify] https://crrev.com/b10b8f337d82162ed428c38dac3f5a0bbfe87abe/third_party/WebKit/LayoutTests/TestExpectations
,
Oct 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a82aa93606c794bf23c7dfc925a2bdceed25388f commit a82aa93606c794bf23c7dfc925a2bdceed25388f Author: Chan <chanli@chromium.org> Date: Tue Oct 16 00:03:31 2018 Mark 'fast/events/middleClickAutoscroll-drag.html' to be flaky as well. TBR=wjmaclean@chromium.org Bug: 891155 Change-Id: I27212eee19d0f7f67b4ee5caba3df4562edb30d2 Reviewed-on: https://chromium-review.googlesource.com/c/1281225 Reviewed-by: Chan Li <chanli@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#599787} [modify] https://crrev.com/a82aa93606c794bf23c7dfc925a2bdceed25388f/third_party/WebKit/LayoutTests/TestExpectations
,
Nov 7
The test is also flaky on Windows: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/72794
,
Nov 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8673ef1c60371b8d63267aa62272ee29e6149ee commit f8673ef1c60371b8d63267aa62272ee29e6149ee Author: Yoshifumi Inoue <yosin@chromium.org> Date: Wed Nov 07 04:14:34 2018 Mark middleClickAutoscroll-{drag,event-fired}.html flaky This patch marks middleClickAutoscroll-{drag,event-fired}.html on Windows: * fast/events/middleClickAutoscroll-event-fired.html * virtual/mouseevent_fractional/fast/events/middleClickAutoscroll-drag.html * virtual/mouseevent_fractional/fast/events/middleClickAutoscroll-event-fired.html * virtual/scroll_customization/fast/events/touch/gesture/gesture-scrollbar-touchpad-fling.html * virtual/user-activation-v2/fast/events/middleClickAutoscroll-nested-divs-forbidden.html NOTRY=true TBR=sahel@chromium.org Bug: 891155 Change-Id: Iaa6d1054921f3298af37a5023992826b541c82f5 Reviewed-on: https://chromium-review.googlesource.com/c/1322250 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#605959} [modify] https://crrev.com/f8673ef1c60371b8d63267aa62272ee29e6149ee/third_party/WebKit/LayoutTests/TestExpectations
,
Nov 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59889ff35b1bba0ec917ce16d0752216d068c2db commit 59889ff35b1bba0ec917ce16d0752216d068c2db Author: Mounir Lamouri <mlamouri@chromium.org> Date: Fri Nov 23 18:19:59 2018 Sheriff: skip virtual/user-activation-v2/fast/events/middleClickAutoscroll-event-fired.html It's flaky on all platforms and is starting to flake on the leak bot. Bug: 891155 Change-Id: I1aa21d9232bc88e02cc8c17d08c0ee17dc08434e TBR: mlamouri@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1349453 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#610649} [modify] https://crrev.com/59889ff35b1bba0ec917ce16d0752216d068c2db/third_party/WebKit/LayoutTests/TestExpectations
,
Dec 14
,
Dec 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40bd209b06933d747cac3d05a917924eeba1ced1 commit 40bd209b06933d747cac3d05a917924eeba1ced1 Author: Morten Stenshorne <mstensho@chromium.org> Date: Fri Dec 14 10:24:56 2018 Skip virtual/user-activation-v2/fast/events/middleClickAutoscroll-event-fired.html Just as flaky as when run inside virtual/mouseevent_fractional/ , which is already skipped? Disable this virtual version of the test as well. TBR=mustaq@google.com Bug: 891155 Change-Id: Iba4400551dadb781e1650c4a948b977c823208b4 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1377433 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#616625} [modify] https://crrev.com/40bd209b06933d747cac3d05a917924eeba1ced1/third_party/blink/web_tests/TestExpectations |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by clamy@chromium.org
, Oct 2Owner: sahel@chromium.org
Status: Assigned (was: Untriaged)