New issue
Advanced search Search tips

Issue 891119 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression
Flaky-Test: Providers/FilesAppBrowserTest.Test

Blocked on:
issue 892478



Sign in to add a comment

Providers/FilesAppBrowserTest.Test?* is flaky

Project Member Reported by Findit, Oct 2

Issue description

Components: Platform>Apps>FileManager
Owner: noel@chromium.org
Status: Assigned (was: Untriaged)
noel - please investigate. Looks like at least requestMount, requestMountMultipleMounts are flaky. Unsure if related to any recently landed CLs yet.
Blockedon: 890969
> noel - please investigate. Looks like at least requestMount, requestMountMultipleMounts are flaky. Unsure if related to any recently landed CLs yet.

Yeah this is due to  issue 890969 , looking at the browser_test crash stacks in #2, I see 

  [1,3554494400:05:40:22.734158] Native Client module will be loaded at base address 0x0000324100000000  [1:1:1001/224022.674272:FATAL:find_paint_offset_and_visual_rect_needing_update.h(72)] Check failed: context.tree_builder_context_actually_needed_.
  #0 0x000004fa187c base::debug::StackTrace::StackTrace()

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c2131519acd279d74bfce0ff6edd8ce5a71a254

commit 4c2131519acd279d74bfce0ff6edd8ce5a71a254
Author: Martin Šrámek <msramek@chromium.org>
Date: Fri Oct 05 13:41:39 2018

Disable Providers/FilesAppBrowserTest.Test on Chrome OS

...due to a high amount of flakes.

TBR=noel@chromium.org

Bug:  891119 
Change-Id: I2b13e7542bbd4cb4e827ab049f761c0f6eb73fc1
Reviewed-on: https://chromium-review.googlesource.com/c/1264539
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597091}
[modify] https://crrev.com/4c2131519acd279d74bfce0ff6edd8ce5a71a254/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Labels: -Sheriff-Chromium
Cc: amistry@chromium.org
Blockedon: -890969 892478
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbe1de8f928dea212b1963faae94e020b4cc58e7

commit cbe1de8f928dea212b1963faae94e020b4cc58e7
Author: Anand K. Mistry <amistry@chromium.org>
Date: Tue Oct 09 22:08:02 2018

Re-enable ZipFiles and Providers file manager browser tests

These tests were previously timing out due to a renderer crash. That bug
( https://crbug.com/892478 ) has been fixed, so re-enable these tests.

BUG= 889703 , 891119 

Change-Id: Ie399bbc89e3ffaceb38c79e180a08b44faa080ce
Reviewed-on: https://chromium-review.googlesource.com/c/1271735
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598102}
[modify] https://crrev.com/cbe1de8f928dea212b1963faae94e020b4cc58e7/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Labels: -Type-Bug Type-Bug-Regression
Status: Fixed (was: Assigned)

Sign in to add a comment