New issue
Advanced search Search tips

Issue 891117 link

Starred by 2 users
Status: Verified
Owner:
orphis@chromium.org
Closed: Oct 2
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 2
Type: Bug



Sign in to add a comment

Implement RTCRtpTransceiverInit.sendEncodings parameter for RTCPeerConnection.addTransceiver

Project Member Reported by orphis@chromium.org, Oct 2 
The current implementation of addTransceiver() doesn't handle the sendEncodings parameter and should be updated.

It is fine to not support simulcast setup from it since the spec is being worked on and WebRTC support is lacking.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bd882a29b8ba297e2d2a13cd34c2612e81edaa4

commit 8bd882a29b8ba297e2d2a13cd34c2612e81edaa4
Author: Florent Castelli <orphis@chromium.org>
Date: Tue Oct 02 21:31:46 2018

Implement RTCRtpTransceiverInit.sendEncodings

This parameter is used to set parameters at the creation of the sender,
and later to setup simulcast, though simulcast isn't supported right
now by WebRTC.

Bug:  891117 
Change-Id: I3c6695bb94c846c4868a235d381bddf885b3a370
Reviewed-on: https://chromium-review.googlesource.com/c/1255944
Commit-Queue: Florent Castelli <orphis@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595991}
[modify] https://crrev.com/8bd882a29b8ba297e2d2a13cd34c2612e81edaa4/content/renderer/media/webrtc/mock_peer_connection_impl.cc
[modify] https://crrev.com/8bd882a29b8ba297e2d2a13cd34c2612e81edaa4/content/renderer/media/webrtc/mock_peer_connection_impl.h
[modify] https://crrev.com/8bd882a29b8ba297e2d2a13cd34c2612e81edaa4/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCPeerConnection-transceivers.https-expected.txt
[modify] https://crrev.com/8bd882a29b8ba297e2d2a13cd34c2612e81edaa4/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCRtpParameters-encodings-expected.txt
[modify] https://crrev.com/8bd882a29b8ba297e2d2a13cd34c2612e81edaa4/third_party/blink/renderer/modules/peerconnection/rtc_rtp_transceiver.cc

Comment 2 by orphis@chromium.org, Oct 2

Status: Verified (was: Started)
►

Sign in to add a comment