Assert more than title in interstitials browser tests |
|||||
Issue descriptionOriginally suggested on http://crrev/c/1256021. We currently have browser tests [1] for several types of interstitials (most of the options on chrome://interstitials). Unfortunately, these only assert that we change the title to "security error," which only tests that we created an interstitial, not which flavor of interstitial was created. It would be nice to assert a bit more about what's on the interstitial so we can differentiate between different threat types (phishing, malware, etc.) as well as different interstitial types (Loud vs. Quiet). This would be especially important for the Quiet interstitials since WebView doesn't exercise all of their functionality. [1] https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc?l=141&rcl=59aed3764077ffd201c04490e81801d6a24ed9f2
,
Oct 15
,
Oct 18
,
Oct 23
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82246f9b21c75bf6b6190c302a73a5d8ac4a2b46 commit 82246f9b21c75bf6b6190c302a73a5d8ac4a2b46 Author: Joe DeBlasio <jdeblasio@chromium.org> Date: Wed Oct 24 21:34:51 2018 Assert contents of page in interstitials tests. This CL allows the interstitials browser tests to verify that displayed interstitials are the ones expected. Previously, tests only compared the page titles, which were often shared between different interstitials. Bug: 891096 Change-Id: Ieb5e9f9a90739cf35f2357655d5e0c31a2a68c91 Reviewed-on: https://chromium-review.googlesource.com/c/1297578 Reviewed-by: Carlos IL <carlosil@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#602463} [modify] https://crrev.com/82246f9b21c75bf6b6190c302a73a5d8ac4a2b46/chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc
,
Oct 24
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by carlosil@chromium.org
, Oct 2Status: Available (was: Untriaged)