New issue
Advanced search Search tips

Issue 891087 link

Starred by 1 user
Status: Fixed
Owner:
taku...@chromium.org
Closed: Oct 3
Cc:
amyroberts@chromium.org
mfo...@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 754101


Participants' hotlists:
Harmony-Cast-Dialog


Sign in to add a comment

[Harmony Cast Dialog] Show Hangouts domain name on sink button if different from user's domain

Project Member Reported by taku...@chromium.org, Oct 1 
As mentioned in the original Castouts privacy review at http://b/27731847, the domain for a Hangouts sink must be shown if it's different from that of the logged-in user. http://b/110850708 also mentions this and comment #4 shows the treatment in the WebUI dialog.

I propose that we put it as the description text for the sink, which would usually say "Available." Please see the attached screenshot for a mock. Amy, WDYT?

(I thought we had a crbug tracking this already but I couldn't find it. Perhaps I was confusing issue 857276 with it)
hangout_domain.png
3.8 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/931b6ae754be7eb495ecdbaf0a480c4368823894

commit 931b6ae754be7eb495ecdbaf0a480c4368823894
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Wed Oct 03 18:57:16 2018

[Harmony Cast Dialog] Show domain as the status text for Hangout sinks

For Hangout sinks in the AVAILABLE state, show its domain as the status
text in the sink list.
Screenshot:
https://drive.google.com/open?id=1pOk8gsxW5MH8sUFJeg1WMLFanMtclPKv

Bug:  891087 
Change-Id: I7faf94e4d89a03da8487264aae2aa73e95debb7c
Reviewed-on: https://chromium-review.googlesource.com/1258245
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596307}
[modify] https://crrev.com/931b6ae754be7eb495ecdbaf0a480c4368823894/chrome/browser/ui/views/media_router/media_router_views_ui.cc
[modify] https://crrev.com/931b6ae754be7eb495ecdbaf0a480c4368823894/chrome/browser/ui/views/media_router/media_router_views_ui.h
[modify] https://crrev.com/931b6ae754be7eb495ecdbaf0a480c4368823894/chrome/browser/ui/views/media_router/media_router_views_ui_unittest.cc

Comment 2 by taku...@chromium.org, Oct 3

Status: Fixed (was: Assigned)
►

Sign in to add a comment