New issue
Advanced search Search tips

Issue 891083 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Migrate timeseries to rename runtime stats

Project Member Reported by benjhayden@chromium.org, Oct 1

Issue description

TBM2 runtime stats currently names Histograms like Total, Blink C++, GC-Background-Other, etc. There is a hierarchy to these names, but it is not accessible in v2spa because they don't use colons. Mythri has prepared a CL to rename these Histograms using colons so that v2spa can group them correctly:
https://chromium-review.googlesource.com/c/catapult/+/1221767

This bug will track migrating the existing data in the chromeperf dashboard from the old names to the new names. Admins can migrate test paths using patterns like */*/*/Total/* so we don't need to manually enumerate each suite x bot x test case. However, names like 'Total' might be used by other test suites. In order to avoid accidentally migrating names for the wrong test suites, we should enumerate the test suite names that use the runtimeStatsMetric. Codesearch turns up these two benchmarks:
v8.runtime_stats.top_25
wasm

Mythri: do you know of any other test suites that run the runtimeStatsMetric?

In order to minimize confusion, I'd like to migrate the data shortly after Mythri's CL lands, so I'd like to have a table mapping old names to new names that I can copy into a script in dev_console.

Mythri: please check this spreadsheet is complete and correct:
https://docs.google.com/spreadsheets/d/1M82mhf18BaToInrXN-QZqcXICMgOppotQ-6TnNSDmqE/edit#gid=0


Simon: any gotchas to beware before I call _MigrateTestBegin?
 
Thanks a lot Ben! we also use runtimeStatsMetricTotal (which is similar to runtimeStatsMetric gut measures the entire period instead of only startup) on 

1. v8.browsing_desktop
2. v8.browsing_mobile
3. v8.browsing_dekstop-future
4. v8.browsing_mobile-future

I am sorry for the delay on the CL. I got context switched to other high priority bugs at that time. I will fix the tests and try to land it this week.


I took a look at the spreadsheet. It is complete, but I am planning to add a couple more. I just fixed all the tests, I will upload the working cl tomorrow and update the sheet again. I will also run few pinpoint jobs and update this bug with the results. That way we can be sure everything is working :).
Can't think of any gotchas off hand. If these are massive migrations, might need to stagger them over a day or 2 to avoid hitting quota, but that's usually only in the case of migrating an entire bot.
Cc: -eakuefner@chromium.org

Sign in to add a comment