bot_update with patch in dependent repo fixes dependency to HEAD |
|||
Issue descriptionhttps://pinpoint-dot-chromeperf.appspot.com/job/113578af640000 In this Pinpoint try job, we're trying to compare r594825 with r594825 + patch. The patch is in skia. I'm seeing unexpected behavior in the build for r594825 + patch. https://ci.chromium.org/buildbot/tryserver.chromium.perf/Win%20x64%20Builder%20Perf/1416 It looks like skia is fixed to HEAD instead of inheriting the revision of the DEP from r594825. So the two builds above are based on different skia revisions. https://logs.chromium.org/v/?s=chrome%2Fbb%2Ftryserver.chromium.perf%2FWin_x64_Builder_Perf%2F1416%2F%2B%2Frecipes%2Fsteps%2Fbot_update%2F0%2Flogs%2Fjson.output%2F0
,
Oct 12
,
Nov 30
,
Dec 5
Sorry for the very late response In [1] the recipe is passing --revision src/third_party/skia@HEAD to bot_update, so this is an issue with the recipe, not with depot_tools, I believe. [1] https://logs.chromium.org/logs/chrome/bb/tryserver.chromium.perf/Win_x64_Builder_Perf/1416/+/recipes/steps/bot_update/0/stdout |
|||
►
Sign in to add a comment |
|||
Comment 1 by perezju@chromium.org
, Oct 3