New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature

Blocking:
issue 891059



Sign in to add a comment
link

Issue 891060: Implement AHardwareBuffer SharableImageBacking

Reported by ericrk@chromium.org, Oct 1 Project Member

Issue description

Tracks work to implement an Android AHardwareBuffer based ShareableImageBacking. This can be vended by ShareableImageManager based on usage flags. This will be the primary interop backing on Android.
 

Comment 1 by vikassoni@google.com, Oct 16

Owner: vikassoni@chromium.org
Status: Started (was: Assigned)

Comment 2 by bugdroid1@chromium.org, Oct 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f68793d0fae7fe1d805f0223eb19a8e4c96c3a2

commit 7f68793d0fae7fe1d805f0223eb19a8e4c96c3a2
Author: Vikas Soni <vikassoni@chromium.org>
Date: Fri Oct 19 01:42:22 2018

Implement AHardwareBuffer backed sharableImage.

Initial implementation of an AHardwareBuffer backed sharableImage and
corresponding unittests.

Bug: 891060
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I785a8666c210a21463514b79f8cc253c6b9544d3
Reviewed-on: https://chromium-review.googlesource.com/c/1282442
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601016}
[modify] https://crrev.com/7f68793d0fae7fe1d805f0223eb19a8e4c96c3a2/gpu/BUILD.gn
[modify] https://crrev.com/7f68793d0fae7fe1d805f0223eb19a8e4c96c3a2/gpu/command_buffer/service/BUILD.gn
[add] https://crrev.com/7f68793d0fae7fe1d805f0223eb19a8e4c96c3a2/gpu/command_buffer/service/ahardwarebuffer_utils.cc
[add] https://crrev.com/7f68793d0fae7fe1d805f0223eb19a8e4c96c3a2/gpu/command_buffer/service/ahardwarebuffer_utils.h
[add] https://crrev.com/7f68793d0fae7fe1d805f0223eb19a8e4c96c3a2/gpu/command_buffer/service/shared_image_backing_factory_ahardwarebuffer.cc
[add] https://crrev.com/7f68793d0fae7fe1d805f0223eb19a8e4c96c3a2/gpu/command_buffer/service/shared_image_backing_factory_ahardwarebuffer.h
[add] https://crrev.com/7f68793d0fae7fe1d805f0223eb19a8e4c96c3a2/gpu/command_buffer/service/shared_image_backing_factory_ahardwarebuffer_unittest.cc

Comment 4 by vikassoni@google.com, Oct 31

Cc: rjkroege@chromium.org
Labels: Proj-Vulkanize

Comment 5 by bugdroid1@chromium.org, Nov 3

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9f29b5f935e227b7c549b60a6cbe1be49897e86

commit d9f29b5f935e227b7c549b60a6cbe1be49897e86
Author: Vikas Soni <vikassoni@chromium.org>
Date: Sat Nov 03 02:03:40 2018

New build target for VulkanContextProvider.

Remove VulkanContextProvider from viz common build target and create a
new target. This is required so that the files which needs to only use
VulkanContextProvider can depend on this new target rather than
depending on whole viz common.

Bug: 891060
Change-Id: Iddff176837a43f029b6466c4b31fedb508d1fb79
Reviewed-on: https://chromium-review.googlesource.com/c/1313114
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605130}
[modify] https://crrev.com/d9f29b5f935e227b7c549b60a6cbe1be49897e86/components/viz/common/BUILD.gn
[modify] https://crrev.com/d9f29b5f935e227b7c549b60a6cbe1be49897e86/components/viz/common/gpu/vulkan_context_provider.h
[modify] https://crrev.com/d9f29b5f935e227b7c549b60a6cbe1be49897e86/components/viz/common/gpu/vulkan_in_process_context_provider.h
[add] https://crrev.com/d9f29b5f935e227b7c549b60a6cbe1be49897e86/components/viz/common/viz_vulkan_context_provider_export.h

Comment 6 by bugdroid1@chromium.org, Nov 3

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4df3f6e1d2823012c856eef0e9035aef8231e0d7

commit 4df3f6e1d2823012c856eef0e9035aef8231e0d7
Author: Vikas Soni <vikassoni@chromium.org>
Date: Sat Nov 03 03:53:24 2018

Add VulkanContextProvider to RasterDecoderContextState.

Add VulkanContextProvider to RasterDecoderContextState which is needed
to get VkDevice in shareable image. Refactor RasterDecoderContextState
class to have seperate constructors for Vulkan and GL.

Bug: 891060
Change-Id: I0ca7e657d33fdcfa62ab6465f7023a914610b7ce
Reviewed-on: https://chromium-review.googlesource.com/c/1312194
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605146}
[modify] https://crrev.com/4df3f6e1d2823012c856eef0e9035aef8231e0d7/components/viz/service/gl/gpu_service_impl.cc
[modify] https://crrev.com/4df3f6e1d2823012c856eef0e9035aef8231e0d7/gpu/command_buffer/service/BUILD.gn
[modify] https://crrev.com/4df3f6e1d2823012c856eef0e9035aef8231e0d7/gpu/command_buffer/service/DEPS
[modify] https://crrev.com/4df3f6e1d2823012c856eef0e9035aef8231e0d7/gpu/command_buffer/service/raster_decoder_context_state.cc
[modify] https://crrev.com/4df3f6e1d2823012c856eef0e9035aef8231e0d7/gpu/command_buffer/service/raster_decoder_context_state.h
[modify] https://crrev.com/4df3f6e1d2823012c856eef0e9035aef8231e0d7/gpu/ipc/service/gpu_channel_manager.cc
[modify] https://crrev.com/4df3f6e1d2823012c856eef0e9035aef8231e0d7/gpu/ipc/service/gpu_channel_manager.h

Comment 7 by bugdroid1@chromium.org, Nov 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43d76b6579c47a51234d175a4800763e39256388

commit 43d76b6579c47a51234d175a4800763e39256388
Author: Peng Huang <penghuang@chromium.org>
Date: Mon Nov 05 17:55:38 2018

Revert "Add VulkanContextProvider to RasterDecoderContextState."

This reverts commit 4df3f6e1d2823012c856eef0e9035aef8231e0d7.

Reason for revert: This CL causes crash in RasterCommandBufferStub.
The raster decoder still uses GL context and GL APIs even with vulkan.
Before removing the GL contect for vulkan, we need remove all
unnecessary GL context usage and GL calls for raster decoder.

#0 0x55d1ec37f6ef base::debug::StackTrace::StackTrace()
#1 0x55d1ec37f261 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7fe55e62d0c0 <unknown>
#3 0x55d1ed30103e gpu::RasterCommandBufferStub::Initialize()
#4 0x55d1ed25f35c gpu::GpuChannel::OnCreateCommandBuffer()
#5 0x55d1ed25ed0a bool IPC::MessageT<GpuChannelMsg_CreateCommandBuffer_Meta, std::__1::tuple<GPUCreateCommandBufferConfig, int, base::UnsafeSharedMemoryRegion>, std::__1::tuple<gpu::ContextResult, gpu::Capabilities> >::Dispatch<gpu::GpuChannel, gpu::GpuChannel, void, void (gpu::GpuChannel::*)(GPUCreateCommandBufferConfig const&, int, base::UnsafeSharedMemoryRegion, gpu::ContextResult*, gpu::Capabilities*)>(IPC::Message const*, gpu::GpuChannel*, gpu::GpuChannel*, void*, void (gpu::GpuChannel::*)(GPUCreateCommandBufferConfig const&, int, base::UnsafeSharedMemoryRegion, gpu::ContextResult*, gpu::Capabilities*))
#6 0x55d1ed25fcc4 gpu::GpuChannel::HandleMessageHelper()
#7 0x55d1ec3058f1 base::debug::TaskAnnotator::RunTask()
#8 0x55d1ec3050af base::MessageLoop::RunTask()
#9 0x55d1ec305432 base::MessageLoop::DoWork()
#10 0x55d1ec30743f base::(anonymous namespace)::WorkSourceDispatch()
#11 0x7fe55def6fc7 g_main_context_dispatch
#12 0x7fe55def7200 <unknown>
#13 0x7fe55def728c g_main_context_iteration
#14 0x55d1ec3072f2 base::MessagePumpGlib::Run()
#15 0x55d1ec31fba5 base::RunLoop::Run()
#16 0x55d1eeaedd3c content::GpuMain()
#17 0x55d1ebb80562 content::ContentMainRunnerImpl::Run()
#18 0x55d1ed68984c service_manager::Main()
#19 0x55d1eb1d6081 content::ContentMain()
#20 0x55d1ea8e316b main
#21 0x7fe559a992b1 __libc_start_main
#22 0x55d1ea8e302a _start

Original change's description:
> Add VulkanContextProvider to RasterDecoderContextState.
> 
> Add VulkanContextProvider to RasterDecoderContextState which is needed
> to get VkDevice in shareable image. Refactor RasterDecoderContextState
> class to have seperate constructors for Vulkan and GL.
> 
> Bug: 891060
> Change-Id: I0ca7e657d33fdcfa62ab6465f7023a914610b7ce
> Reviewed-on: https://chromium-review.googlesource.com/c/1312194
> Commit-Queue: vikas soni <vikassoni@chromium.org>
> Reviewed-by: Eric Karl <ericrk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605146}

TBR=ericrk@chromium.org,vikassoni@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 891060
Change-Id: I4ceebc7033b4bd74e643a5f89bbbd6791b3eb6c0
Reviewed-on: https://chromium-review.googlesource.com/c/1318073
Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605376}
[modify] https://crrev.com/43d76b6579c47a51234d175a4800763e39256388/components/viz/service/gl/gpu_service_impl.cc
[modify] https://crrev.com/43d76b6579c47a51234d175a4800763e39256388/gpu/command_buffer/service/BUILD.gn
[modify] https://crrev.com/43d76b6579c47a51234d175a4800763e39256388/gpu/command_buffer/service/DEPS
[modify] https://crrev.com/43d76b6579c47a51234d175a4800763e39256388/gpu/command_buffer/service/raster_decoder_context_state.cc
[modify] https://crrev.com/43d76b6579c47a51234d175a4800763e39256388/gpu/command_buffer/service/raster_decoder_context_state.h
[modify] https://crrev.com/43d76b6579c47a51234d175a4800763e39256388/gpu/ipc/service/gpu_channel_manager.cc
[modify] https://crrev.com/43d76b6579c47a51234d175a4800763e39256388/gpu/ipc/service/gpu_channel_manager.h

Comment 8 by bugdroid1@chromium.org, Nov 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34cb2c7034db50b84497bb9dc20acf79897775ed

commit 34cb2c7034db50b84497bb9dc20acf79897775ed
Author: Vikas Soni <vikassoni@chromium.org>
Date: Wed Nov 07 21:21:25 2018

Reland "Add VulkanContextProvider to RasterDecoderContextState."

This is a reland of 4df3f6e1d2823012c856eef0e9035aef8231e0d7 with some
changes to not seperate out vulkan and GL constructor for
RasterDecoderContextState.

Original change's description:
> Add VulkanContextProvider to RasterDecoderContextState.
>
> Add VulkanContextProvider to RasterDecoderContextState which is needed
> to get VkDevice in shareable image. Refactor RasterDecoderContextState
> class to have seperate constructors for Vulkan and GL.
>
> Bug: 891060
> Change-Id: I0ca7e657d33fdcfa62ab6465f7023a914610b7ce
> Reviewed-on: https://chromium-review.googlesource.com/c/1312194
> Commit-Queue: vikas soni <vikassoni@chromium.org>
> Reviewed-by: Eric Karl <ericrk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605146}

Bug: 891060
Change-Id: Id2f4ae194445861f59ea24299f98cc94c477be98
Reviewed-on: https://chromium-review.googlesource.com/c/1320512
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606162}
[modify] https://crrev.com/34cb2c7034db50b84497bb9dc20acf79897775ed/components/viz/service/gl/gpu_service_impl.cc
[modify] https://crrev.com/34cb2c7034db50b84497bb9dc20acf79897775ed/gpu/command_buffer/service/BUILD.gn
[modify] https://crrev.com/34cb2c7034db50b84497bb9dc20acf79897775ed/gpu/command_buffer/service/DEPS
[modify] https://crrev.com/34cb2c7034db50b84497bb9dc20acf79897775ed/gpu/command_buffer/service/raster_decoder_context_state.cc
[modify] https://crrev.com/34cb2c7034db50b84497bb9dc20acf79897775ed/gpu/command_buffer/service/raster_decoder_context_state.h
[modify] https://crrev.com/34cb2c7034db50b84497bb9dc20acf79897775ed/gpu/ipc/service/gpu_channel_manager.cc
[modify] https://crrev.com/34cb2c7034db50b84497bb9dc20acf79897775ed/gpu/ipc/service/gpu_channel_manager.h

Comment 10 by bugdroid1@chromium.org, Nov 20

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a0eb7284594a6e62033954deece1edb8ad0c21b

commit 5a0eb7284594a6e62033954deece1edb8ad0c21b
Author: Vikas Soni <vikassoni@chromium.org>
Date: Tue Nov 20 20:51:12 2018

Add android platform specific functions.

Update generate_bindings.py to generate android platform specific device
functions.

Bug: 891060
Change-Id: I88f5b6149c4e955613b64e56c403caf2a970dd6f
Reviewed-on: https://chromium-review.googlesource.com/c/1344223
Reviewed-by: Chris Blume <cblume@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609792}
[modify] https://crrev.com/5a0eb7284594a6e62033954deece1edb8ad0c21b/gpu/vulkan/generate_bindings.py
[modify] https://crrev.com/5a0eb7284594a6e62033954deece1edb8ad0c21b/gpu/vulkan/vulkan_function_pointers.cc
[modify] https://crrev.com/5a0eb7284594a6e62033954deece1edb8ad0c21b/gpu/vulkan/vulkan_function_pointers.h

Comment 11 by bugdroid1@chromium.org, Nov 27

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7af47362847f06f257fca4171c0f793d8c512001

commit 7af47362847f06f257fca4171c0f793d8c512001
Author: Vikas Soni <vikassoni@chromium.org>
Date: Tue Nov 27 23:20:30 2018

Export/Import sync FD from/to a Vulkan Semaphore.

Added android utility functions to export/import sync FD from/to a
vulkan semaphore. Added unittests.

Bug: 891060
Change-Id: I2fcac73018fe91afae0ac141fdd5e40244451b15
Reviewed-on: https://chromium-review.googlesource.com/c/1332608
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611399}
[modify] https://crrev.com/7af47362847f06f257fca4171c0f793d8c512001/components/viz/common/BUILD.gn
[modify] https://crrev.com/7af47362847f06f257fca4171c0f793d8c512001/gpu/vulkan/android/BUILD.gn
[add] https://crrev.com/7af47362847f06f257fca4171c0f793d8c512001/gpu/vulkan/android/DEPS
[add] https://crrev.com/7af47362847f06f257fca4171c0f793d8c512001/gpu/vulkan/android/run_all_unittests.cc
[add] https://crrev.com/7af47362847f06f257fca4171c0f793d8c512001/gpu/vulkan/android/vulkan_android_unittests.cc
[modify] https://crrev.com/7af47362847f06f257fca4171c0f793d8c512001/gpu/vulkan/android/vulkan_implementation_android.cc
[modify] https://crrev.com/7af47362847f06f257fca4171c0f793d8c512001/gpu/vulkan/android/vulkan_implementation_android.h
[modify] https://crrev.com/7af47362847f06f257fca4171c0f793d8c512001/gpu/vulkan/generate_bindings.py
[modify] https://crrev.com/7af47362847f06f257fca4171c0f793d8c512001/gpu/vulkan/vulkan_function_pointers.cc
[modify] https://crrev.com/7af47362847f06f257fca4171c0f793d8c512001/gpu/vulkan/vulkan_function_pointers.h
[modify] https://crrev.com/7af47362847f06f257fca4171c0f793d8c512001/gpu/vulkan/vulkan_implementation.h

Comment 12 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8e53d0f70e2e8bc9736e55cacd1bf939efc18da

commit c8e53d0f70e2e8bc9736e55cacd1bf939efc18da
Author: Vikas Soni <vikassoni@chromium.org>
Date: Fri Dec 07 01:04:09 2018

Import AHardwareBuffer into a Vulkan Image.

Added a utility function to create a vulkan image and import AHardwareBuffer
created outside of vulkan device into a vulkan image.

Bug: 891060
Change-Id: Id6a81c0b21e53bac4c439c3a7d8f787cbc32b68b
Reviewed-on: https://chromium-review.googlesource.com/c/1357658
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614518}
[modify] https://crrev.com/c8e53d0f70e2e8bc9736e55cacd1bf939efc18da/components/viz/common/BUILD.gn
[modify] https://crrev.com/c8e53d0f70e2e8bc9736e55cacd1bf939efc18da/gpu/vulkan/BUILD.gn
[modify] https://crrev.com/c8e53d0f70e2e8bc9736e55cacd1bf939efc18da/gpu/vulkan/android/vulkan_android_unittests.cc
[modify] https://crrev.com/c8e53d0f70e2e8bc9736e55cacd1bf939efc18da/gpu/vulkan/android/vulkan_implementation_android.cc
[modify] https://crrev.com/c8e53d0f70e2e8bc9736e55cacd1bf939efc18da/gpu/vulkan/android/vulkan_implementation_android.h
[modify] https://crrev.com/c8e53d0f70e2e8bc9736e55cacd1bf939efc18da/gpu/vulkan/generate_bindings.py
[modify] https://crrev.com/c8e53d0f70e2e8bc9736e55cacd1bf939efc18da/gpu/vulkan/vulkan_function_pointers.cc
[modify] https://crrev.com/c8e53d0f70e2e8bc9736e55cacd1bf939efc18da/gpu/vulkan/vulkan_function_pointers.h
[modify] https://crrev.com/c8e53d0f70e2e8bc9736e55cacd1bf939efc18da/gpu/vulkan/vulkan_implementation.h

Comment 13 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5915da6551513f0945d34a57cce82918ef4bc606

commit 5915da6551513f0945d34a57cce82918ef4bc606
Author: Michael Spang <spang@chromium.org>
Date: Fri Dec 07 19:42:48 2018

Revert "Import AHardwareBuffer into a Vulkan Image."

This reverts commit c8e53d0f70e2e8bc9736e55cacd1bf939efc18da.

Reason for revert: This breaks non-Android platforms.

VK_KHR_GET_MEMORY_REQUIREMENTS_2_EXTENSION_NAME is requested on Android only, yet a dependency on it is added to vulkan_function_pointers.cc on all platforms.

Original change's description:
> Import AHardwareBuffer into a Vulkan Image.
> 
> Added a utility function to create a vulkan image and import AHardwareBuffer
> created outside of vulkan device into a vulkan image.
> 
> Bug: 891060
> Change-Id: Id6a81c0b21e53bac4c439c3a7d8f787cbc32b68b
> Reviewed-on: https://chromium-review.googlesource.com/c/1357658
> Commit-Queue: vikas soni <vikassoni@chromium.org>
> Reviewed-by: Eric Karl <ericrk@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#614518}

TBR=piman@chromium.org,ericrk@chromium.org,vikassoni@chromium.org

Change-Id: I11c1d39a43438699d72a93212eedef1d4230518a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 891060
Reviewed-on: https://chromium-review.googlesource.com/c/1368406
Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614786}
[modify] https://crrev.com/5915da6551513f0945d34a57cce82918ef4bc606/components/viz/common/BUILD.gn
[modify] https://crrev.com/5915da6551513f0945d34a57cce82918ef4bc606/gpu/vulkan/BUILD.gn
[modify] https://crrev.com/5915da6551513f0945d34a57cce82918ef4bc606/gpu/vulkan/android/vulkan_android_unittests.cc
[modify] https://crrev.com/5915da6551513f0945d34a57cce82918ef4bc606/gpu/vulkan/android/vulkan_implementation_android.cc
[modify] https://crrev.com/5915da6551513f0945d34a57cce82918ef4bc606/gpu/vulkan/android/vulkan_implementation_android.h
[modify] https://crrev.com/5915da6551513f0945d34a57cce82918ef4bc606/gpu/vulkan/generate_bindings.py
[modify] https://crrev.com/5915da6551513f0945d34a57cce82918ef4bc606/gpu/vulkan/vulkan_function_pointers.cc
[modify] https://crrev.com/5915da6551513f0945d34a57cce82918ef4bc606/gpu/vulkan/vulkan_function_pointers.h
[modify] https://crrev.com/5915da6551513f0945d34a57cce82918ef4bc606/gpu/vulkan/vulkan_implementation.h

Comment 14 by bugdroid1@chromium.org, Dec 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a54d576cb356b3e7e8d07e503800d07fb6dec20b

commit a54d576cb356b3e7e8d07e503800d07fb6dec20b
Author: Vikas Soni <vikassoni@chromium.org>
Date: Sat Dec 08 00:43:45 2018

Reland "Import AHardwareBuffer into a Vulkan Image."

This is a reland of c8e53d0f70e2e8bc9736e55cacd1bf939efc18da after
adding a fix to remove unused extensions.

Original change's description:
> Import AHardwareBuffer into a Vulkan Image.
>
> Added a utility function to create a vulkan image and import AHardwareBuffer
> created outside of vulkan device into a vulkan image.
>
> Bug: 891060
> Change-Id: Id6a81c0b21e53bac4c439c3a7d8f787cbc32b68b
> Reviewed-on: https://chromium-review.googlesource.com/c/1357658
> Commit-Queue: vikas soni <vikassoni@chromium.org>
> Reviewed-by: Eric Karl <ericrk@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#614518}

Bug: 891060
Change-Id: I4fe440cb12302f9f9c657074b218992a5509e58b
Reviewed-on: https://chromium-review.googlesource.com/c/1368686
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614889}
[modify] https://crrev.com/a54d576cb356b3e7e8d07e503800d07fb6dec20b/components/viz/common/BUILD.gn
[modify] https://crrev.com/a54d576cb356b3e7e8d07e503800d07fb6dec20b/gpu/vulkan/BUILD.gn
[modify] https://crrev.com/a54d576cb356b3e7e8d07e503800d07fb6dec20b/gpu/vulkan/android/vulkan_android_unittests.cc
[modify] https://crrev.com/a54d576cb356b3e7e8d07e503800d07fb6dec20b/gpu/vulkan/android/vulkan_implementation_android.cc
[modify] https://crrev.com/a54d576cb356b3e7e8d07e503800d07fb6dec20b/gpu/vulkan/android/vulkan_implementation_android.h
[modify] https://crrev.com/a54d576cb356b3e7e8d07e503800d07fb6dec20b/gpu/vulkan/generate_bindings.py
[modify] https://crrev.com/a54d576cb356b3e7e8d07e503800d07fb6dec20b/gpu/vulkan/vulkan_function_pointers.cc
[modify] https://crrev.com/a54d576cb356b3e7e8d07e503800d07fb6dec20b/gpu/vulkan/vulkan_function_pointers.h
[modify] https://crrev.com/a54d576cb356b3e7e8d07e503800d07fb6dec20b/gpu/vulkan/vulkan_implementation.h

Comment 15 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62530d98d8917acfe713056076b624e4de9e650b

commit 62530d98d8917acfe713056076b624e4de9e650b
Author: Vikas Soni <vikassoni@chromium.org>
Date: Fri Dec 14 01:58:43 2018

Refactor image_reader_utils.

Refactored DeleteAImageAsync() api to move gl fence creation and
exporting a sync fd from it to a separate function.

Bug: 891060
Change-Id: I181e8d032ca64f1cd9d0a6942fb33856b236f2a1
Reviewed-on: https://chromium-review.googlesource.com/c/1377212
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: Chris Blume <cblume@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616557}
[modify] https://crrev.com/62530d98d8917acfe713056076b624e4de9e650b/gpu/ipc/common/android/android_image_reader_utils.cc
[modify] https://crrev.com/62530d98d8917acfe713056076b624e4de9e650b/gpu/ipc/common/android/android_image_reader_utils.h

Comment 16 by bugdroid1@chromium.org, Dec 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/390ef3a93083e6bd42483bbeccc510746d685f2e

commit 390ef3a93083e6bd42483bbeccc510746d685f2e
Author: Vikas Soni <vikassoni@chromium.org>
Date: Tue Dec 18 14:42:07 2018

GL internal format for AHardwareBuffer backed egl image.

For egl image created using AHardwareBuffer, get he internal format
using the buffer format instead of hardcoding it to GL_RGBA.

Bug: 891060
Change-Id: I1805ad432457c36dde4726aa89d61ceaa8e47d4d
Reviewed-on: https://chromium-review.googlesource.com/c/1380820
Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617483}
[modify] https://crrev.com/390ef3a93083e6bd42483bbeccc510746d685f2e/ui/gl/gl_image_ahardwarebuffer.cc
[modify] https://crrev.com/390ef3a93083e6bd42483bbeccc510746d685f2e/ui/gl/gl_image_ahardwarebuffer.h

Comment 17 by bugdroid1@chromium.org, Dec 20

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dc8014f0e60a549e324486d3013638bc8784adf

commit 8dc8014f0e60a549e324486d3013638bc8784adf
Author: Vikas Soni <vikassoni@chromium.org>
Date: Thu Dec 20 21:05:14 2018

Vulkan backed skia representation of SharedImageBackingAHB.

1. Implemented Vulkan backed skia representation of
SharedImageBackingAHB.
2. Added synchronisation between gl backed and Vk backed
representations.

Bug: 891060
Change-Id: I46ba32dea62569cd67d6f3b24559f4ef28307168
Reviewed-on: https://chromium-review.googlesource.com/c/1370471
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618320}
[modify] https://crrev.com/8dc8014f0e60a549e324486d3013638bc8784adf/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc
[modify] https://crrev.com/8dc8014f0e60a549e324486d3013638bc8784adf/gpu/command_buffer/service/BUILD.gn
[modify] https://crrev.com/8dc8014f0e60a549e324486d3013638bc8784adf/gpu/command_buffer/service/shared_image_backing_factory_ahardwarebuffer.cc
[modify] https://crrev.com/8dc8014f0e60a549e324486d3013638bc8784adf/gpu/command_buffer/service/shared_image_backing_factory_ahardwarebuffer.h
[modify] https://crrev.com/8dc8014f0e60a549e324486d3013638bc8784adf/gpu/command_buffer/service/shared_image_backing_factory_ahardwarebuffer_unittest.cc
[modify] https://crrev.com/8dc8014f0e60a549e324486d3013638bc8784adf/gpu/command_buffer/service/shared_image_backing_factory_gl_texture.cc
[modify] https://crrev.com/8dc8014f0e60a549e324486d3013638bc8784adf/gpu/command_buffer/service/shared_image_backing_factory_gl_texture_unittest.cc
[modify] https://crrev.com/8dc8014f0e60a549e324486d3013638bc8784adf/gpu/command_buffer/service/shared_image_representation.h
[modify] https://crrev.com/8dc8014f0e60a549e324486d3013638bc8784adf/gpu/command_buffer/service/wrapped_sk_image.cc

Comment 18 by bugdroid1@chromium.org, Dec 21

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8c415b9ddf9dfe951d3c38e8f3406fdf59d7dd8

commit d8c415b9ddf9dfe951d3c38e8f3406fdf59d7dd8
Author: vikas soni <vikassoni@chromium.org>
Date: Fri Dec 21 01:01:06 2018

Revert "Vulkan backed skia representation of SharedImageBackingAHB."

This reverts commit 8dc8014f0e60a549e324486d3013638bc8784adf.

Reason for revert: This is causing crash on android devices causing a DCHECK to fail - '[FATAL:feature_list.cc(305)] Check failed: CheckFeatureIdentity(feature). DefaultEnableOopRasterization'

Original change's description:
> Vulkan backed skia representation of SharedImageBackingAHB.
> 
> 1. Implemented Vulkan backed skia representation of
> SharedImageBackingAHB.
> 2. Added synchronisation between gl backed and Vk backed
> representations.
> 
> Bug: 891060
> Change-Id: I46ba32dea62569cd67d6f3b24559f4ef28307168
> Reviewed-on: https://chromium-review.googlesource.com/c/1370471
> Reviewed-by: Eric Karl <ericrk@chromium.org>
> Commit-Queue: vikas soni <vikassoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#618320}

TBR=ericrk@chromium.org,vikassoni@chromium.org

Change-Id: I559954ae7556f32ddc110a84e8433f24b41e4d88
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 891060
Reviewed-on: https://chromium-review.googlesource.com/c/1388179
Reviewed-by: vikas soni <vikassoni@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618413}
[modify] https://crrev.com/d8c415b9ddf9dfe951d3c38e8f3406fdf59d7dd8/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc
[modify] https://crrev.com/d8c415b9ddf9dfe951d3c38e8f3406fdf59d7dd8/gpu/command_buffer/service/BUILD.gn
[modify] https://crrev.com/d8c415b9ddf9dfe951d3c38e8f3406fdf59d7dd8/gpu/command_buffer/service/shared_image_backing_factory_ahardwarebuffer.cc
[modify] https://crrev.com/d8c415b9ddf9dfe951d3c38e8f3406fdf59d7dd8/gpu/command_buffer/service/shared_image_backing_factory_ahardwarebuffer.h
[modify] https://crrev.com/d8c415b9ddf9dfe951d3c38e8f3406fdf59d7dd8/gpu/command_buffer/service/shared_image_backing_factory_ahardwarebuffer_unittest.cc
[modify] https://crrev.com/d8c415b9ddf9dfe951d3c38e8f3406fdf59d7dd8/gpu/command_buffer/service/shared_image_backing_factory_gl_texture.cc
[modify] https://crrev.com/d8c415b9ddf9dfe951d3c38e8f3406fdf59d7dd8/gpu/command_buffer/service/shared_image_backing_factory_gl_texture_unittest.cc
[modify] https://crrev.com/d8c415b9ddf9dfe951d3c38e8f3406fdf59d7dd8/gpu/command_buffer/service/shared_image_representation.h
[modify] https://crrev.com/d8c415b9ddf9dfe951d3c38e8f3406fdf59d7dd8/gpu/command_buffer/service/wrapped_sk_image.cc

Comment 19 by bugdroid1@chromium.org, Dec 21

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/115a901d9cc158e352cc42a7a0aba0fb8ce781e2

commit 115a901d9cc158e352cc42a7a0aba0fb8ce781e2
Author: Vikas Soni <vikassoni@chromium.org>
Date: Fri Dec 21 22:24:10 2018

Move android_image_reader_utils* into a new source set.

Move android_image_reader_utils to a new source set. This helps to
reduce unwanted dependencies in the places which needs to use
android_image_reader_utils* files.

Bug: 891060
Change-Id: I2557ca40d5ab011de800d842cf2ab18dcb238381
Reviewed-on: https://chromium-review.googlesource.com/c/1388389
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618631}
[modify] https://crrev.com/115a901d9cc158e352cc42a7a0aba0fb8ce781e2/gpu/ipc/common/BUILD.gn
[modify] https://crrev.com/115a901d9cc158e352cc42a7a0aba0fb8ce781e2/media/gpu/BUILD.gn

Comment 20 by bugdroid1@chromium.org, Dec 23

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d62cddff825b45a53e429ed8ae4fcbb7ad1ddc3

commit 0d62cddff825b45a53e429ed8ae4fcbb7ad1ddc3
Author: Vikas Soni <vikassoni@chromium.org>
Date: Sun Dec 23 02:02:33 2018

Reland "Vulkan backed skia representation of SharedImageBackingAHB."

This is a reland of 8dc8014f0e60a549e324486d3013638bc8784adf
with a BUILD file fix.

Original change's description:
> Vulkan backed skia representation of SharedImageBackingAHB.
>
> 1. Implemented Vulkan backed skia representation of
> SharedImageBackingAHB.
> 2. Added synchronisation between gl backed and Vk backed
> representations.
>
> Bug: 891060
> Change-Id: I46ba32dea62569cd67d6f3b24559f4ef28307168
> Reviewed-on: https://chromium-review.googlesource.com/c/1370471
> Reviewed-by: Eric Karl <ericrk@chromium.org>
> Commit-Queue: vikas soni <vikassoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#618320}

Bug: 891060
Change-Id: Ic8dc4572a27b8c40a6fcf7a021c3e2225e155691
Reviewed-on: https://chromium-review.googlesource.com/c/1388559
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618771}
[modify] https://crrev.com/0d62cddff825b45a53e429ed8ae4fcbb7ad1ddc3/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc
[modify] https://crrev.com/0d62cddff825b45a53e429ed8ae4fcbb7ad1ddc3/gpu/command_buffer/service/BUILD.gn
[modify] https://crrev.com/0d62cddff825b45a53e429ed8ae4fcbb7ad1ddc3/gpu/command_buffer/service/shared_image_backing_factory_ahardwarebuffer.cc
[modify] https://crrev.com/0d62cddff825b45a53e429ed8ae4fcbb7ad1ddc3/gpu/command_buffer/service/shared_image_backing_factory_ahardwarebuffer.h
[modify] https://crrev.com/0d62cddff825b45a53e429ed8ae4fcbb7ad1ddc3/gpu/command_buffer/service/shared_image_backing_factory_ahardwarebuffer_unittest.cc
[modify] https://crrev.com/0d62cddff825b45a53e429ed8ae4fcbb7ad1ddc3/gpu/command_buffer/service/shared_image_backing_factory_gl_texture.cc
[modify] https://crrev.com/0d62cddff825b45a53e429ed8ae4fcbb7ad1ddc3/gpu/command_buffer/service/shared_image_backing_factory_gl_texture_unittest.cc
[modify] https://crrev.com/0d62cddff825b45a53e429ed8ae4fcbb7ad1ddc3/gpu/command_buffer/service/shared_image_representation.h
[modify] https://crrev.com/0d62cddff825b45a53e429ed8ae4fcbb7ad1ddc3/gpu/command_buffer/service/wrapped_sk_image.cc

Comment 21 by bugdroid, Jan 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c645d9dec20e256e29748e5cddce859644f81a2e

commit c645d9dec20e256e29748e5cddce859644f81a2e
Author: Vikas Soni <vikassoni@chromium.org>
Date: Tue Jan 29 19:54:58 2019

SharedImageRepresentationSkiaVkAHB changes to wait on semaphore.

Updated SharedImageRepresentationSkiaVkAHB BeginReadAccess() to do a
server side wait instead of client side wait.

Bug: 891060
Change-Id: I4d4807a63bfe51e8c6e2b65fa6080f7b7eceb25c
Reviewed-on: https://chromium-review.googlesource.com/c/1437278
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#627119}
[modify] https://crrev.com/c645d9dec20e256e29748e5cddce859644f81a2e/gpu/command_buffer/service/shared_image_backing_factory_ahardwarebuffer.cc

Sign in to add a comment