New issue
Advanced search Search tips

Issue 891059 link

Starred by 1 user
Status: Fixed
Owner:
ericrk@chromium.org
Closed: Nov 21
Cc:
backer@chromium.org
piman@chromium.org
dsinclair@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocked on: View detail
issue 891060
issue 891062
issue 905519
Blocking:
issue 870116



Sign in to add a comment

Implement base ShareableImageManager

Project Member Reported by ericrk@chromium.org, Oct 1 
gpu::ShareableImageManager has two main tasks:
1) Allocate new ShareableImageBackings, choosing the correct type based on usage params.
2) Provides a mapping from gpu::Mailbox to gpu::ShareableImageBacking. 

This bug tracks the basic implementation which will only handle simple GL <> GL handoff cases.

See https://docs.google.com/document/d/12qYPeN819JkdNGbPcKBA0rfPXSOIE3aIaQVrAZ4I1lM/edit#bookmark=id.ofshur2m631h for context.

See issue 870116 for the interface which exposes this manager.

Comment 1 by ericrk@chromium.org, Oct 1

Blocking: 870116

Comment 2 by ericrk@chromium.org, Oct 1

Blockedon: 891060

Comment 3 by ericrk@chromium.org, Oct 1

Blockedon: 891062
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a6cc166e9b9856c151493d807c080774200c126

commit 8a6cc166e9b9856c151493d807c080774200c126
Author: Eric Karl <ericrk@chromium.org>
Date: Tue Oct 09 22:23:50 2018

Start to define SharedImage[Backing/BackingFactory/Stub]

Defines several classes which will eventually be used in the full
SharedImage service-side implementation. For now this is more of
a refactoring to allow us to move to the new model with minimal
disruption to the current legacy mailbox approach.

GL texture generation has been extracted from SharedImageFactory into
SharedImageBackingFactoryGLTexture. SharedImageFactory uses this to
get a SharedImageBackingGLTexture. This is only used right now via
the ToLegacyMailbox function, but will have more functionality in the
future.

Additionally, SharedImageManager is currently just used for lifetime
management, and isn't doing anything interesting. Subsequent CLs will
add SharedImageRepresentations which can be retrieved from the
manager.

Bug:  891059 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Icb18c7e96edc08790b5a80850ec915f7cbc8563b
Reviewed-on: https://chromium-review.googlesource.com/c/1263345
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598110}
[modify] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/BUILD.gn
[modify] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/command_buffer/service/BUILD.gn
[modify] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/command_buffer/service/context_group.cc
[modify] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/command_buffer/service/context_group.h
[modify] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/command_buffer/service/context_group_unittest.cc
[modify] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
[modify] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h
[modify] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/command_buffer/service/raster_decoder_unittest.cc
[modify] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/command_buffer/service/raster_decoder_unittest_base.cc
[modify] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/command_buffer/service/raster_decoder_unittest_base.h
[modify] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/command_buffer/service/service_discardable_manager_unittest.cc
[add] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/command_buffer/service/shared_image_backing.h
[add] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/command_buffer/service/shared_image_backing_factory.h
[add] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/command_buffer/service/shared_image_backing_factory_gl_texture.cc
[add] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/command_buffer/service/shared_image_backing_factory_gl_texture.h
[add] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/command_buffer/service/shared_image_backing_factory_gl_texture_unittest.cc
[modify] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/command_buffer/service/shared_image_factory.cc
[modify] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/command_buffer/service/shared_image_factory.h
[modify] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/command_buffer/service/shared_image_factory_unittest.cc
[add] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/command_buffer/service/shared_image_manager.cc
[add] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/command_buffer/service/shared_image_manager.h
[modify] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/command_buffer/service/texture_manager.h
[modify] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/command_buffer/tests/decoder_perftest.cc
[modify] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/command_buffer/tests/fuzzer_main.cc
[modify] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/command_buffer/tests/gl_manager.cc
[modify] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/command_buffer/tests/gl_manager.h
[modify] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/config/gpu_finch_features.cc
[modify] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/config/gpu_finch_features.h
[modify] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/gles2_conform_support/egl/context.cc
[modify] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/gles2_conform_support/egl/context.h
[modify] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/ipc/command_buffer_task_executor.h
[modify] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/ipc/in_process_command_buffer.cc
[modify] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/ipc/service/gles2_command_buffer_stub.cc
[modify] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/ipc/service/gpu_channel_manager.h
[modify] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/ipc/service/raster_command_buffer_stub.cc
[modify] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/ipc/service/shared_image_stub.cc
[modify] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/gpu/ipc/service/webgpu_command_buffer_stub.cc
[modify] https://crrev.com/8a6cc166e9b9856c151493d807c080774200c126/media/gpu/android/android_video_decode_accelerator_unittest.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1521ca7e5daf02e642d787484893db2ec012f4c4

commit 1521ca7e5daf02e642d787484893db2ec012f4c4
Author: Eric Karl <ericrk@chromium.org>
Date: Tue Oct 16 20:15:44 2018

Move memory dump internals from SharedImageFactory to SharedImageBacking

This CL moves the memory dump internals into SharedImageBacking, which
will allow for new backing types to implement their own dump logic.

Bug:  891059 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I4f239ab76e75d3b51fe3a120e7c34b20376f559c
Reviewed-on: https://chromium-review.googlesource.com/c/1279167
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600096}
[modify] https://crrev.com/1521ca7e5daf02e642d787484893db2ec012f4c4/gpu/command_buffer/service/BUILD.gn
[add] https://crrev.com/1521ca7e5daf02e642d787484893db2ec012f4c4/gpu/command_buffer/service/shared_image_backing.cc
[modify] https://crrev.com/1521ca7e5daf02e642d787484893db2ec012f4c4/gpu/command_buffer/service/shared_image_backing.h
[modify] https://crrev.com/1521ca7e5daf02e642d787484893db2ec012f4c4/gpu/command_buffer/service/shared_image_backing_factory.h
[modify] https://crrev.com/1521ca7e5daf02e642d787484893db2ec012f4c4/gpu/command_buffer/service/shared_image_backing_factory_gl_texture.cc
[modify] https://crrev.com/1521ca7e5daf02e642d787484893db2ec012f4c4/gpu/command_buffer/service/shared_image_backing_factory_gl_texture.h
[modify] https://crrev.com/1521ca7e5daf02e642d787484893db2ec012f4c4/gpu/command_buffer/service/shared_image_backing_factory_gl_texture_unittest.cc
[modify] https://crrev.com/1521ca7e5daf02e642d787484893db2ec012f4c4/gpu/command_buffer/service/shared_image_factory.cc
[modify] https://crrev.com/1521ca7e5daf02e642d787484893db2ec012f4c4/gpu/command_buffer/service/shared_image_factory.h
[modify] https://crrev.com/1521ca7e5daf02e642d787484893db2ec012f4c4/gpu/command_buffer/service/shared_image_manager.cc
[modify] https://crrev.com/1521ca7e5daf02e642d787484893db2ec012f4c4/gpu/command_buffer/service/shared_image_manager.h
[modify] https://crrev.com/1521ca7e5daf02e642d787484893db2ec012f4c4/gpu/command_buffer/service/wrapped_sk_image.cc
[modify] https://crrev.com/1521ca7e5daf02e642d787484893db2ec012f4c4/gpu/command_buffer/service/wrapped_sk_image.h
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1292a17eb21a9e9d058605a3d51a47c5cc63b14

commit b1292a17eb21a9e9d058605a3d51a47c5cc63b14
Author: Eric Karl <ericrk@chromium.org>
Date: Wed Oct 17 01:20:03 2018

Add SharedImageRepresentationGLTexture and GLES2 import

Adds a SharedImageRepresentationGLTexture interface and implements this
for SharedImageBackingGLTexture.

Also adds glCreateAndTexStorage2DSharedImageCHROMIUM to the command buffer.
This function creates a new texture name / texture and assigns a
SharedImage to the first level.

Only test users at this point.

Doesn't yet add Access Begin/End. Will come in follow up.

Bug:  891059 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I8f5aa1ad1145302b9354a589ac50e978537c43d7
Reviewed-on: https://chromium-review.googlesource.com/c/1279429
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600227}
[add] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_shared_image.txt
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/GLES2/gl2chromium_autogen.h
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/build_gles2_cmd_buffer.py
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/client/gles2_c_lib_autogen.h
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/client/gles2_cmd_helper_autogen.h
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/client/gles2_implementation.cc
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/client/gles2_implementation_autogen.h
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/client/gles2_implementation_unittest.cc
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/client/gles2_interface_autogen.h
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/client/gles2_interface_stub_autogen.h
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/client/gles2_trace_implementation_autogen.h
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/common/gles2_cmd_format_autogen.h
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/common/gles2_cmd_format_test_autogen.h
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/common/gles2_cmd_ids_autogen.h
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/gles2_cmd_buffer_functions.txt
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/service/BUILD.gn
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doer_prototypes.h
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers_autogen.cc
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/service/shared_image_backing.cc
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/service/shared_image_backing.h
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/service/shared_image_backing_factory_gl_texture.cc
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/service/shared_image_backing_factory_gl_texture_unittest.cc
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/service/shared_image_factory.cc
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/service/shared_image_manager.cc
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/service/shared_image_manager.h
[add] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/service/shared_image_representation.cc
[add] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/service/shared_image_representation.h
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/service/texture_manager.cc
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/service/texture_manager.h
[modify] https://crrev.com/b1292a17eb21a9e9d058605a3d51a47c5cc63b14/gpu/command_buffer/service/wrapped_sk_image.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/643f963ceb563b126255c492fcb8a008218bf489

commit 643f963ceb563b126255c492fcb8a008218bf489
Author: Eric Karl <ericrk@chromium.org>
Date: Thu Oct 18 20:06:55 2018

Add SharedImageRepresentationGLTexturePassthrough

The passthrough command decoder counterpart to:
https://chromium-review.googlesource.com/c/chromium/src/+/1279429

Adds support for DoCreateAndTexStorage2DSharedImageCHROMIUM to the
passthrough command decoder.

Causes the passthrough command decoder to store shared image
representations for relevant client IDs. This isn't really used now,
but will be used in a future begin/end access patch.

Bug:  891059 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I14f9c0cdfeaf9e836361c2c811a06b69f36cdd66
Reviewed-on: https://chromium-review.googlesource.com/c/1287267
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600879}
[modify] https://crrev.com/643f963ceb563b126255c492fcb8a008218bf489/gpu/BUILD.gn
[modify] https://crrev.com/643f963ceb563b126255c492fcb8a008218bf489/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
[modify] https://crrev.com/643f963ceb563b126255c492fcb8a008218bf489/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h
[modify] https://crrev.com/643f963ceb563b126255c492fcb8a008218bf489/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
[add] https://crrev.com/643f963ceb563b126255c492fcb8a008218bf489/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_unittest_textures.cc
[modify] https://crrev.com/643f963ceb563b126255c492fcb8a008218bf489/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
[modify] https://crrev.com/643f963ceb563b126255c492fcb8a008218bf489/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h
[modify] https://crrev.com/643f963ceb563b126255c492fcb8a008218bf489/gpu/command_buffer/service/shared_image_backing.cc
[modify] https://crrev.com/643f963ceb563b126255c492fcb8a008218bf489/gpu/command_buffer/service/shared_image_backing.h
[modify] https://crrev.com/643f963ceb563b126255c492fcb8a008218bf489/gpu/command_buffer/service/shared_image_backing_factory_gl_texture.cc
[modify] https://crrev.com/643f963ceb563b126255c492fcb8a008218bf489/gpu/command_buffer/service/shared_image_backing_factory_gl_texture_unittest.cc
[modify] https://crrev.com/643f963ceb563b126255c492fcb8a008218bf489/gpu/command_buffer/service/shared_image_manager.cc
[modify] https://crrev.com/643f963ceb563b126255c492fcb8a008218bf489/gpu/command_buffer/service/shared_image_manager.h
[modify] https://crrev.com/643f963ceb563b126255c492fcb8a008218bf489/gpu/command_buffer/service/shared_image_representation.h
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfaf5f207349cb49ad257c967af4bd019d8b5fbd

commit dfaf5f207349cb49ad257c967af4bd019d8b5fbd
Author: Antoine Labour <piman@chromium.org>
Date: Fri Oct 19 23:10:54 2018

Fix crash in SharedImageFactory with duplicate mailboxes

Remove use-after-moved-from on the SharedImageBacking.

Bug:  891059 
Change-Id: I663e019033145477fbe3719b7441da59e0fedd50
Reviewed-on: https://chromium-review.googlesource.com/c/1292550
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601348}
[modify] https://crrev.com/dfaf5f207349cb49ad257c967af4bd019d8b5fbd/gpu/command_buffer/service/shared_image_factory.cc
[modify] https://crrev.com/dfaf5f207349cb49ad257c967af4bd019d8b5fbd/gpu/command_buffer/service/shared_image_factory_unittest.cc
[modify] https://crrev.com/dfaf5f207349cb49ad257c967af4bd019d8b5fbd/gpu/command_buffer/service/shared_image_manager.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3750cfa3c0fdf5eb637981b04f68bb3cd089c7ae

commit 3750cfa3c0fdf5eb637981b04f68bb3cd089c7ae
Author: Eric Karl <ericrk@chromium.org>
Date: Thu Oct 25 16:54:17 2018

Add SharedImageRepresentationSkia + update RasterDecoder / Skia Renderer

Adds a SharedImageRepresentationSkia for use with RasterDecoder and Skia
Renderer.

Causes RasterDecoder to always use SharedImage, as the client is already
converted.

SkiaRenderer tries to use SharedImage, but falls back to legacy
mailboxes if the content to raster is not backed by a SharedImage.

Causes WrappedSkImage to be a SharedImage, rather than a TextureBase.

Bug:  891059 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I339b3fdd5f7ad2a722ed19bacdb8416fb868bf64
Reviewed-on: https://chromium-review.googlesource.com/c/1282382
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602758}
[modify] https://crrev.com/3750cfa3c0fdf5eb637981b04f68bb3cd089c7ae/cc/paint/oop_pixeltest.cc
[modify] https://crrev.com/3750cfa3c0fdf5eb637981b04f68bb3cd089c7ae/components/viz/service/display_embedder/skia_output_surface_impl.cc
[modify] https://crrev.com/3750cfa3c0fdf5eb637981b04f68bb3cd089c7ae/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc
[modify] https://crrev.com/3750cfa3c0fdf5eb637981b04f68bb3cd089c7ae/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.h
[modify] https://crrev.com/3750cfa3c0fdf5eb637981b04f68bb3cd089c7ae/components/viz/service/gl/gpu_service_impl.h
[modify] https://crrev.com/3750cfa3c0fdf5eb637981b04f68bb3cd089c7ae/gpu/command_buffer/service/raster_decoder.cc
[modify] https://crrev.com/3750cfa3c0fdf5eb637981b04f68bb3cd089c7ae/gpu/command_buffer/service/shared_image_backing.cc
[modify] https://crrev.com/3750cfa3c0fdf5eb637981b04f68bb3cd089c7ae/gpu/command_buffer/service/shared_image_backing.h
[modify] https://crrev.com/3750cfa3c0fdf5eb637981b04f68bb3cd089c7ae/gpu/command_buffer/service/shared_image_backing_factory_gl_texture.cc
[modify] https://crrev.com/3750cfa3c0fdf5eb637981b04f68bb3cd089c7ae/gpu/command_buffer/service/shared_image_backing_factory_gl_texture_unittest.cc
[modify] https://crrev.com/3750cfa3c0fdf5eb637981b04f68bb3cd089c7ae/gpu/command_buffer/service/shared_image_factory.cc
[modify] https://crrev.com/3750cfa3c0fdf5eb637981b04f68bb3cd089c7ae/gpu/command_buffer/service/shared_image_manager.cc
[modify] https://crrev.com/3750cfa3c0fdf5eb637981b04f68bb3cd089c7ae/gpu/command_buffer/service/shared_image_manager.h
[modify] https://crrev.com/3750cfa3c0fdf5eb637981b04f68bb3cd089c7ae/gpu/command_buffer/service/shared_image_representation.h
[modify] https://crrev.com/3750cfa3c0fdf5eb637981b04f68bb3cd089c7ae/gpu/command_buffer/service/skia_utils.cc
[modify] https://crrev.com/3750cfa3c0fdf5eb637981b04f68bb3cd089c7ae/gpu/command_buffer/service/skia_utils.h
[modify] https://crrev.com/3750cfa3c0fdf5eb637981b04f68bb3cd089c7ae/gpu/command_buffer/service/texture_base.cc
[modify] https://crrev.com/3750cfa3c0fdf5eb637981b04f68bb3cd089c7ae/gpu/command_buffer/service/texture_base.h
[modify] https://crrev.com/3750cfa3c0fdf5eb637981b04f68bb3cd089c7ae/gpu/command_buffer/service/texture_manager.cc
[modify] https://crrev.com/3750cfa3c0fdf5eb637981b04f68bb3cd089c7ae/gpu/command_buffer/service/wrapped_sk_image.cc
[modify] https://crrev.com/3750cfa3c0fdf5eb637981b04f68bb3cd089c7ae/gpu/command_buffer/service/wrapped_sk_image.h
[modify] https://crrev.com/3750cfa3c0fdf5eb637981b04f68bb3cd089c7ae/gpu/ipc/client/raster_in_process_context_tests.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ae657077217e655c0129f8e9417aac96240423b

commit 7ae657077217e655c0129f8e9417aac96240423b
Author: Eric Karl <ericrk@chromium.org>
Date: Thu Oct 25 18:14:19 2018

Move Memory*Tracker from gles2:: to gpu::

As we move towards using Vulkan, it makes sense to use this class more
generally, so removing gles2.

Bug:  891059 
Change-Id: I5e34a9ebe6e58f25401184799d5f06e81b2c0918
Reviewed-on: https://chromium-review.googlesource.com/c/1298506
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602792}
[modify] https://crrev.com/7ae657077217e655c0129f8e9417aac96240423b/gpu/command_buffer/service/context_group.h
[modify] https://crrev.com/7ae657077217e655c0129f8e9417aac96240423b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h
[modify] https://crrev.com/7ae657077217e655c0129f8e9417aac96240423b/gpu/command_buffer/service/gpu_command_buffer_memory_tracker.h
[modify] https://crrev.com/7ae657077217e655c0129f8e9417aac96240423b/gpu/command_buffer/service/memory_tracking.h
[modify] https://crrev.com/7ae657077217e655c0129f8e9417aac96240423b/gpu/command_buffer/service/raster_decoder.cc
[modify] https://crrev.com/7ae657077217e655c0129f8e9417aac96240423b/gpu/command_buffer/service/shared_image_backing_factory_gl_texture.cc
[modify] https://crrev.com/7ae657077217e655c0129f8e9417aac96240423b/gpu/command_buffer/service/shared_image_backing_factory_gl_texture.h
[modify] https://crrev.com/7ae657077217e655c0129f8e9417aac96240423b/gpu/command_buffer/service/shared_image_factory.cc
[modify] https://crrev.com/7ae657077217e655c0129f8e9417aac96240423b/gpu/command_buffer/service/shared_image_factory.h
[modify] https://crrev.com/7ae657077217e655c0129f8e9417aac96240423b/gpu/command_buffer/service/transfer_buffer_manager.cc
[modify] https://crrev.com/7ae657077217e655c0129f8e9417aac96240423b/gpu/command_buffer/service/transfer_buffer_manager.h
[modify] https://crrev.com/7ae657077217e655c0129f8e9417aac96240423b/gpu/ipc/in_process_command_buffer.cc
[modify] https://crrev.com/7ae657077217e655c0129f8e9417aac96240423b/gpu/ipc/service/command_buffer_stub.cc
[modify] https://crrev.com/7ae657077217e655c0129f8e9417aac96240423b/gpu/ipc/service/command_buffer_stub.h
[modify] https://crrev.com/7ae657077217e655c0129f8e9417aac96240423b/gpu/ipc/service/gpu_channel.cc
[modify] https://crrev.com/7ae657077217e655c0129f8e9417aac96240423b/gpu/ipc/service/shared_image_stub.h

Comment 11 by rjkroege@chromium.org, Oct 31

Labels: Proj-Vulkanize
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebc7f2d990254998a0a6510ccbe031078ac1a940

commit ebc7f2d990254998a0a6510ccbe031078ac1a940
Author: Eric Karl <ericrk@chromium.org>
Date: Wed Nov 07 13:52:26 2018

Add Begin/EndSharedImageAccessCHROMIUM

Adds begin/end functions to the GL command buffer for shared image
access. Currently, begin/end is a no-op in all
SharedImageRepresentations, this will be fixed up in a follow up.

This change just adds the commands and parameter validation in the
validating and passthrough command decoders.

Bug:  891059 
Change-Id: Idb4bd900fa56bd470ad44ad955267e76860792cd
Reviewed-on: https://chromium-review.googlesource.com/c/1313668
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606030}
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_shared_image.txt
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/GLES2/gl2chromium_autogen.h
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/GLES2/gl2extchromium.h
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/command_buffer/build_gles2_cmd_buffer.py
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/command_buffer/client/gles2_c_lib_autogen.h
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/command_buffer/client/gles2_cmd_helper_autogen.h
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/command_buffer/client/gles2_implementation_autogen.h
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/command_buffer/client/gles2_implementation_impl_autogen.h
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/command_buffer/client/gles2_implementation_unittest_autogen.h
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/command_buffer/client/gles2_interface_autogen.h
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/command_buffer/client/gles2_interface_stub_autogen.h
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/command_buffer/client/gles2_trace_implementation_autogen.h
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/command_buffer/common/gles2_cmd_format_autogen.h
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/command_buffer/common/gles2_cmd_format_test_autogen.h
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/command_buffer/common/gles2_cmd_ids_autogen.h
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/command_buffer/common/gles2_cmd_utils_autogen.h
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/command_buffer/gles2_cmd_buffer_functions.txt
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doer_prototypes.h
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers_autogen.cc
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_unittest_textures.cc
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/command_buffer/service/gles2_cmd_validation_autogen.h
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/command_buffer/service/shared_image_representation.cc
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/command_buffer/service/shared_image_representation.h
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/gpu/command_buffer/service/texture_manager.h
[modify] https://crrev.com/ebc7f2d990254998a0a6510ccbe031078ac1a940/ui/gl/gl_bindings.h

Comment 13 by kbr@chromium.org, Nov 16

Blockedon: 905519
Project Member

Comment 14 by bugdroid1@chromium.org, Nov 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1be26f6e4aa49b40d19501e105b72ebf170b4afb

commit 1be26f6e4aa49b40d19501e105b72ebf170b4afb
Author: Austin Eng <enga@chromium.org>
Date: Fri Nov 16 19:37:08 2018

Rereun ui/gl/generate_bindings.py

Bug:  894200 ,  891059 
Change-Id: Ic3ad1be6bf9ce21cd672266d42ef4259fd47cd9d
Reviewed-on: https://chromium-review.googlesource.com/c/1340568
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608893}
[modify] https://crrev.com/1be26f6e4aa49b40d19501e105b72ebf170b4afb/ui/gl/gl_enums_implementation_autogen.h

Comment 15 by ericrk@chromium.org, Nov 21

Status: Fixed (was: Started)
Basic work is done, remaining is follow-ups and improvements prob. better tracked in specific bugs. Closing this out.
►

Sign in to add a comment