This is a blocker for migrating the CQ.

It's just a question of updating the annotator generated URLs to use buildbucket ids.

Thanks for pointing this out!

Thanks for the bug report. This has been broken for a few months and this was the first report.

We're shutting down Annotator in a few months in favor of the UI moving into the CI UI. Also, no one ever annotates release build failures.

So, I think that we should WontFix this one.

"no one ever annotates release build failures."

that's pretty circular (it's broken, so no one used it) :)

Last time I was using S-o-M, I definitely annotated canary build failures, to help other sheriffs who were working. That would help us clear out our mental queue of failures.

I guess it looks like I can still annotate, but they won't be used for anything, right?

Correct. The status of release builds in the Annotator was always that they were purely for the sheriffs to keep notes; no other system ever looked at them.

In theory, we could generate stats from them, but never had enough annotated to make that worth while. Which is also circular. 

Jason, this same problem will affect CQ builds after they move to swarming. So... we either need to replace the annotator before that move, or fix this.

I'm pretty sure the hardest part of fixing this will be figuring out how to deploy new annotator versions.

Hrm, good point. I deployed Annotator awhile ago and it was really painful. I'll take a look.

Is this the same reason we have problems like the following?

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8933574730886724448

The 'kevin64-release' link leads to:

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?builderName=kevin64-release&buildNumber=0

which gives HTTP 500 errors:
javax.persistence.NonUniqueResultException
...

I have to click through the MILO link instead, to get the logs:

https://ci.chromium.org/p/chromeos/builders/luci.chromeos.general/Prod/b8933573569094788816

That's a different Legoland bug which needs a tracking bug in this Buganizer component: https://b.corp.google.com/issues?q=componentid:318849 . Could you file that as a P1 and assign to dburger@, please?

Done:
https://b.corp.google.com/issues/117290017

Fix deployed to prod and crrev.com/c/1263139 out for review.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/86aed05a6d9088709b9d389b5f87c908590be5b8

commit 86aed05a6d9088709b9d389b5f87c908590be5b8
Author: Jason D. Clinton <jclinton@chromium.org>
Date: Sat Oct 06 02:38:01 2018

Migrate from build_number to buildbucket_id for external links

Also migrates from Waterfall to Legoland.

BUG= chromium:891055 
TEST=deploy to prod :(, confirmed that everything works

Change-Id: I64a46b9bf45469dbd8d06abbdc134910194996ad
Reviewed-on: https://chromium-review.googlesource.com/1263139
Commit-Ready: Jason Clinton <jclinton@chromium.org>
Tested-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/86aed05a6d9088709b9d389b5f87c908590be5b8/appengine/cq_stats/build_annotations/templates/build_annotations/edit_annotations.html
[modify] https://crrev.com/86aed05a6d9088709b9d389b5f87c908590be5b8/appengine/cq_stats/build_annotations/models.py
[modify] https://crrev.com/86aed05a6d9088709b9d389b5f87c908590be5b8/appengine/cq_stats/build_annotations/build_row_controller.py
[modify] https://crrev.com/86aed05a6d9088709b9d389b5f87c908590be5b8/appengine/cq_stats/build_annotations/templates/build_annotations/index.html