NetworkFileShares UI: Mark username and password fields in |
|||||||||
Issue descriptionAdd "(optional)" to the username and password fields in the add share dialog
,
Oct 2
,
Oct 2
,
Oct 2
This bug requires manual review: We are only 13 days from stable. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 2
,
Oct 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ae7395ad16c9bd4a1fd27745160d1ff755ed154 commit 0ae7395ad16c9bd4a1fd27745160d1ff755ed154 Author: Bailey Berro <baileyberro@chromium.org> Date: Wed Oct 03 15:22:03 2018 Mark un and pw fields as optional in add SMB share dialog - Marks username and password as optional in the add share dialog. Bug: chromium:891020 Change-Id: Ie3ea8c2a021dd6be42a129865aac30fe00f67dcb Reviewed-on: https://chromium-review.googlesource.com/1255900 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#595645}(cherry picked from commit 1b7451ab9ffcc5e817178530be4233286812e8ae) Reviewed-on: https://chromium-review.googlesource.com/c/1258967 Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#836} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/0ae7395ad16c9bd4a1fd27745160d1ff755ed154/chrome/app/settings_strings.grdp
,
Oct 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ae7395ad16c9bd4a1fd27745160d1ff755ed154 Commit: 0ae7395ad16c9bd4a1fd27745160d1ff755ed154 Author: baileyberro@chromium.org Commiter: zentaro@chromium.org Date: 2018-10-03 15:22:03 +0000 UTC Mark un and pw fields as optional in add SMB share dialog - Marks username and password as optional in the add share dialog. Bug: chromium:891020 Change-Id: Ie3ea8c2a021dd6be42a129865aac30fe00f67dcb Reviewed-on: https://chromium-review.googlesource.com/1255900 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#595645}(cherry picked from commit 1b7451ab9ffcc5e817178530be4233286812e8ae) Reviewed-on: https://chromium-review.googlesource.com/c/1258967 Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#836} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Oct 3
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c05bb2dd9bbd3e8649aded08305daf4239e56fc3 Commit: c05bb2dd9bbd3e8649aded08305daf4239e56fc3 Author: zentaro@chromium.org Commiter: zentaro@chromium.org Date: 2018-10-04 16:40:02 +0000 UTC Revert "Mark un and pw fields as optional in add SMB share dialog" This reverts commit 0ae7395ad16c9bd4a1fd27745160d1ff755ed154. Reason for revert: Remove from M70 branch because we don't have translations. Original change's description: > Mark un and pw fields as optional in add SMB share dialog > > - Marks username and password as optional in the add share dialog. > > Bug: chromium:891020 > Change-Id: Ie3ea8c2a021dd6be42a129865aac30fe00f67dcb > Reviewed-on: https://chromium-review.googlesource.com/1255900 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: Bailey Berro <baileyberro@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#595645}(cherry picked from commit 1b7451ab9ffcc5e817178530be4233286812e8ae) > Reviewed-on: https://chromium-review.googlesource.com/c/1258967 > Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> > Cr-Commit-Position: refs/branch-heads/3538@{#836} > Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} TBR=zentaro@chromium.org,baileyberro@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:891020 Change-Id: Id07828170890976cddd2bd5834cdc61e9b2e5a10 Reviewed-on: https://chromium-review.googlesource.com/c/1261961 Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#854} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c05bb2dd9bbd3e8649aded08305daf4239e56fc3 commit c05bb2dd9bbd3e8649aded08305daf4239e56fc3 Author: Zentaro Kavanagh <zentaro@chromium.org> Date: Thu Oct 04 16:40:02 2018 Revert "Mark un and pw fields as optional in add SMB share dialog" This reverts commit 0ae7395ad16c9bd4a1fd27745160d1ff755ed154. Reason for revert: Remove from M70 branch because we don't have translations. Original change's description: > Mark un and pw fields as optional in add SMB share dialog > > - Marks username and password as optional in the add share dialog. > > Bug: chromium:891020 > Change-Id: Ie3ea8c2a021dd6be42a129865aac30fe00f67dcb > Reviewed-on: https://chromium-review.googlesource.com/1255900 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: Bailey Berro <baileyberro@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#595645}(cherry picked from commit 1b7451ab9ffcc5e817178530be4233286812e8ae) > Reviewed-on: https://chromium-review.googlesource.com/c/1258967 > Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> > Cr-Commit-Position: refs/branch-heads/3538@{#836} > Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} TBR=zentaro@chromium.org,baileyberro@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:891020 Change-Id: Id07828170890976cddd2bd5834cdc61e9b2e5a10 Reviewed-on: https://chromium-review.googlesource.com/c/1261961 Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#854} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/c05bb2dd9bbd3e8649aded08305daf4239e56fc3/chrome/app/settings_strings.grdp
,
Oct 4
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, Oct 1