New issue
Advanced search Search tips

Issue 891016 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

runtime.onStartup doesn't fire for SW based extension

Project Member Reported by lazyboy@chromium.org, Oct 1

Issue description

The basic hooks is there but "runtime" isn't available for extesnsion service worker contexts.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f70ab2221ed3a97983704b3743cec5d22f075957

commit f70ab2221ed3a97983704b3743cec5d22f075957
Author: Istiaque Ahmed <lazyboy@chromium.org>
Date: Tue Oct 02 03:08:24 2018

Extensions: Add a test for SW runtime.onStartup

Add a test that verifies that runtime.onStartup fires on Service
Worker based extension upon chrome start.

This CL also expands "runtime" feature to "extension_service_worker"
context type.

Bug:  891016 
Change-Id: I4a11f6da2f5311d7901ad8bb05c348b9343fe701
Reviewed-on: https://chromium-review.googlesource.com/1255588
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595708}
[modify] https://crrev.com/f70ab2221ed3a97983704b3743cec5d22f075957/chrome/browser/extensions/service_worker_apitest.cc
[add] https://crrev.com/f70ab2221ed3a97983704b3743cec5d22f075957/chrome/test/data/extensions/api_test/service_worker/worker_based_background/on_startup_event/manifest.json
[add] https://crrev.com/f70ab2221ed3a97983704b3743cec5d22f075957/chrome/test/data/extensions/api_test/service_worker/worker_based_background/on_startup_event/service_worker_background.js

Status: Fixed (was: Started)
FYI, Change https://chromium-review.googlesource.com/q/I75dddc32613862464ba2bb73fd972ec1b0d2b03a, landed before the change^^^ actually lets "runtime" feature through and change I4a11f6da2f5311d7901ad8bb05c348b9343fe701 adds a test specific to onStartup event.

Sign in to add a comment