signing: drop support for verity-old & old dm= kernel parameters (support for <R16 CrOS images) |
||||
Issue descriptionthe "new" dm= kernel parameter style was introduced with the R16 release of CrOS. the only devices that used the old style & were released were mario/alex/zgb. lumpy/stumpy probably saw some of it during early development, but they were all released on R17+. and at any rate, all those devices are EOL now, and we don't care about being able to sign <R16 media anymore.
,
Oct 2
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/16ceb9625ed13b0da4ae6306f9187b672b9b382f commit 16ceb9625ed13b0da4ae6306f9187b672b9b382f Author: Mike Frysinger <vapier@chromium.org> Date: Tue Oct 02 16:17:37 2018 image_signing: drop support for <R16 recovery image signing We changed the verity kernel command line form before R16 was released and included backwards compat support in the scripts for it. But all the devices that were released for these old versions are EOL, and we don't need to sign images that old anymore, so drop support. BRANCH=None BUG= chromium:891015 TEST=precq passes Change-Id: I0e61c5d5cbeefb8ea0af955ead604a97fcb84bad Reviewed-on: https://chromium-review.googlesource.com/1255344 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: David Riley <davidriley@chromium.org> [modify] https://crrev.com/16ceb9625ed13b0da4ae6306f9187b672b9b382f/scripts/image_signing/sign_official_build.sh
,
Oct 3
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/cros-signing/+/52038547b0024b1c35c6587669eb3379845a7869 commit 52038547b0024b1c35c6587669eb3379845a7869 Author: Mike Frysinger <vapier@chromium.org> Date: Wed Oct 03 03:37:16 2018
,
Oct 3
,
Oct 3
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/cros-signing/+/6fc6d82055fd46f7ef5b7ef63d3db6ad79c35092 commit 6fc6d82055fd46f7ef5b7ef63d3db6ad79c35092 Author: Mike Frysinger <vapier@google.com> Date: Wed Oct 03 19:02:34 2018
,
Oct 4
hrm, that seemed to break signing for some reason. need to track it down and add unittest coverage.
,
Dec 15
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/aad0cfff9dea75a405a2ebff48c87b03cce43051 commit aad0cfff9dea75a405a2ebff48c87b03cce43051 Author: Mike Frysinger <vapier@chromium.org> Date: Sat Dec 15 10:18:44 2018 image_signing: fix breakage from dropping <R16 support Commit 16ceb9625ed13b0da4ae6306f9187b672b9b382f dropped support for old versions, but it also accidentally dropped the salt= setting which ended up breaking newer recovery kernels. Restore that line and drop an unused var from the old code path. BRANCH=None BUG= chromium:891015 , chromium:891764 TEST=running `./sign_official_build.sh verify` against the images in crbug.com/891764 works again Change-Id: I8ae619c9243f9c2638962ae439b9df5090d6c535 Reviewed-on: https://chromium-review.googlesource.com/1376831 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: David Riley <davidriley@chromium.org> [modify] https://crrev.com/aad0cfff9dea75a405a2ebff48c87b03cce43051/scripts/image_signing/sign_official_build.sh
,
Dec 21
,
Dec 23
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/e9beb8556fa357a9c374ca6b93d8f4c5c784f5e3 commit e9beb8556fa357a9c374ca6b93d8f4c5c784f5e3 Author: LaMont Jones <lamontjones@chromium.org> Date: Sun Dec 23 22:46:12 2018 image_signing: drop support for old_verity_argv images We changed the verity kernel command line form before R16 was released and included backwards compat support in the scripts for it. But all the devices that were released for these old versions are EOL, and we don't need to sign images that old anymore, so drop support. BRANCH=None BUG= chromium:891015 TEST=precq passes Change-Id: I5cc37fae19fb4b3db229598aa0f5c69a6f32005a Reviewed-on: https://chromium-review.googlesource.com/1387904 Commit-Ready: LaMont Jones <lamontjones@chromium.org> Tested-by: LaMont Jones <lamontjones@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/e9beb8556fa357a9c374ca6b93d8f4c5c784f5e3/scripts/image_signing/sign_official_build.sh
,
Jan 11
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/cros-signing/+/ee89d838b45c40bbcb33c81d4c480f6f2fc71516 commit ee89d838b45c40bbcb33c81d4c480f6f2fc71516 Author: Mike Frysinger <vapier@chromium.org> Date: Fri Jan 11 16:29:52 2019 |
||||
►
Sign in to add a comment |
||||
Comment 1 by vapier@chromium.org
, Oct 1