Reuse the same buffer in smbprovider |
||
Issue descriptionWe repeatedly create new temporary buffers for holding data read from or prior to writing to samba. The buffers are never needed for longer than the life of a DBUS call and the daemon runs a single threaded FIFO queue for operations. Just have a single shared buffer that can be reused for reads and writes.
,
Oct 2
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/41fda1aebce1ae09aeac07aefcd50205c17d19b3 commit 41fda1aebce1ae09aeac07aefcd50205c17d19b3 Author: Zentaro Kavanagh <zentaro@chromium.org> Date: Tue Oct 02 23:42:01 2018 smbprovider: Use a single shared buffer for ReadFile - All operations are single threaded and the buffers are only used for temporary storage before writing through to files. BUG= chromium:890982 TEST=unittests Change-Id: Icd802c342466ffb149aa7021c43fb5a5ad6515bc Reviewed-on: https://chromium-review.googlesource.com/1255563 Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org> Tested-by: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Bailey Berro <baileyberro@chromium.org> [modify] https://crrev.com/41fda1aebce1ae09aeac07aefcd50205c17d19b3/smbprovider/smbprovider.cc [modify] https://crrev.com/41fda1aebce1ae09aeac07aefcd50205c17d19b3/smbprovider/smbprovider.h
,
Oct 2
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/07d89570b01677ff68d3e692caa3a537337f6426 commit 07d89570b01677ff68d3e692caa3a537337f6426 Author: Zentaro Kavanagh <zentaro@chromium.org> Date: Tue Oct 02 23:42:02 2018 smbprovider: Use a shared buffer for WriteFile - Just use a single shared buffer BUG= chromium:890982 TEST=unittests Change-Id: Ia68386f5f869c2d4c70658220e078b32883a427e Reviewed-on: https://chromium-review.googlesource.com/1255564 Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org> Tested-by: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Bailey Berro <baileyberro@chromium.org> [modify] https://crrev.com/07d89570b01677ff68d3e692caa3a537337f6426/smbprovider/smbprovider.cc [modify] https://crrev.com/07d89570b01677ff68d3e692caa3a537337f6426/smbprovider/smbprovider.h
,
Oct 3
|
||
►
Sign in to add a comment |
||
Comment 1 by zentaro@chromium.org
, Oct 1