New issue
Advanced search Search tips

Issue 890956 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

stdin hangs in crosvm for ARM

Project Member Reported by jkardatzke@chromium.org, Oct 1

Issue description

Using Chrome OS 11117.0.0 you can reproduce this easily.  Just run the following command (you may need to change the filename for the socket if you run this more than once):

crosvm run --socket /tmp/crosvm_socket123 --root /run/imageloader/cros-termina/11101.0.0/vm_rootfs.img -p init=/bin/bash /run/imageloader/cros-termina/11101.0.0/vm_kernel

You will then get the prompt into the VM, but stdin won't accept anything...which is causing the vm.StartCrosvm test to fail.

I reproduced this on kevin, from the test results it also happened on bob and scarlet...very much looks like it's only a problem on ARM based on the data.
 
Owner: dverkamp@chromium.org
FYI, stdin has never worked on arm as the serial device hasn't been implemented yet
OK, is that something that'll be implemented soon...or should we just disable that part of the test for now?
I think we should start with that part of the test disabled on ARM systems.
Status: Assigned (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/cc11cdc88238c537306d077c7662c962c594c104

commit cc11cdc88238c537306d077c7662c962c594c104
Author: Jeffrey Kardatzke <jkardatzke@google.com>
Date: Tue Oct 02 16:17:41 2018

tast-tests: Disable stdin related test in StartCrosvm

We currently don't have a working stdin for the VM on ARM, so disable
the part of the vm.StartCrosvm test which relies on that. It will still
be able to validate VM startup occur properly though.

BUG= chromium:849438 , chromium:890956 
TEST=tast run vm.StartCrosvm

Change-Id: I30b4bf4640c2b9a64cf24879395107ed4e9424e8
Reviewed-on: https://chromium-review.googlesource.com/1255448
Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com>
Tested-by: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/cc11cdc88238c537306d077c7662c962c594c104/src/chromiumos/tast/local/bundles/cros/vm/start_crosvm.go

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosvm/+/c7af4b1e68ea06136b1474976df8ea2e9528b2b3

commit c7af4b1e68ea06136b1474976df8ea2e9528b2b3
Author: Sonny Rao <sonnyrao@chromium.org>
Date: Fri Oct 12 22:16:54 2018

aarch64: add arm serial input support

Wire up the serial device interrupt on aarch64 so stdin works.

BUG= chromium:890956 
TEST=Verify serial console works on kevin

Change-Id: Ifcafecb10d443f0100f047d0a2ec545c24e718af
Signed-off-by: Daniel Verkamp <dverkamp@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1115728
Reviewed-by: Sonny Rao <sonnyrao@chromium.org>

[modify] https://crrev.com/c7af4b1e68ea06136b1474976df8ea2e9528b2b3/aarch64/src/fdt.rs
[modify] https://crrev.com/c7af4b1e68ea06136b1474976df8ea2e9528b2b3/aarch64/src/lib.rs

Status: Fixed (was: Assigned)
This should be working now, so we should be able to re-enable the vm.StartCrosvm test on ARM.
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/e9c0283586e897469d64d29d58a632d529fbace0

commit e9c0283586e897469d64d29d58a632d529fbace0
Author: Daniel Verkamp <dverkamp@chromium.org>
Date: Fri Oct 19 22:07:47 2018

Revert "tast-tests: Disable stdin related test in StartCrosvm"

Serial support for stdin is working on ARM platforms as of
https://chromium-review.googlesource.com/1115728 - we can now re-enable
the full StartCrosvm test.

This reverts commit cc11cdc88238c537306d077c7662c962c594c104.

BUG= chromium:890956 
TEST=`tast run chromebook vm.StartCrosvm` on kevin

Change-Id: I861e684aea71e43f0d70d8a4b64b18b71904ac72
Signed-off-by: Daniel Verkamp <dverkamp@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1287809
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/e9c0283586e897469d64d29d58a632d529fbace0/src/chromiumos/tast/local/bundles/cros/vm/start_crosvm.go

Sign in to add a comment