New issue
Advanced search Search tips

Issue 890953 link

Starred by 1 user
Status: Fixed
Owner:
mukai@chromium.org
Closed: Oct 3
Cc:
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

HostedAppAshInteractiveUITest.MenuButtonClickable is flaky with SingleProcessMash

Project Member Reported by mukai@chromium.org, Oct 1 
It fails on the FYI bot several times.
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8933882762354176208/+/steps/single_process_mash_interactive_ui_tests/0/logs/HostedAppAshInteractiveUITest.MenuButtonClickable/0

Somehow it fails to open the menu like
  ../../chrome/browser/ui/views/frame/hosted_app_ash_interactive_ui_test.cc:48: Failure
  Value of: menu_button->IsMenuShowing()
    Actual: false
  Expected: true
  Stack trace:
  #0 0x000000c2e29c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
  #1 0x000000c2dc69 testing::internal::AssertHelper::operator=()
  #2 0x000000b24a7c HostedAppAshInteractiveUITest::CheckHostedAppMenuClickable()
  #3 0x000003e18472 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
  #4 0x00000398d2cb ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
  #5 0x00000398c00a ChromeBrowserMainParts::PreMainMessageLoopRun()
  #6 0x00000280624f chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
  #7 0x000001bb33c1 content::BrowserMainLoop::PreMainMessageLoopRun()
  #8 0x0000020648f5 content::StartupTaskRunner::RunAllTasksNow()
  #9 0x000001bb1af7 content::BrowserMainLoop::CreateStartupTasks()
  #10 0x000001bb5c83 content::BrowserMainRunnerImpl::Initialize()
  #11 0x000001baf652 content::BrowserMain()
  #12 0x00000392dfdf content::ContentMainRunnerImpl::Run()
  #13 0x000005aff9c5 service_manager::Main()
  #14 0x00000392c474 content::ContentMain()
  #15 0x000003e1803b content::BrowserTestBase::SetUp()
  #16 0x00000397ba95 InProcessBrowserTest::SetUp()

is seen.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d4927a6c343310754c678e5792bd7c8ea39f187

commit 1d4927a6c343310754c678e5792bd7c8ea39f187
Author: Jun Mukai <mukai@chromium.org>
Date: Tue Oct 02 23:12:37 2018

stabilize CheckHostedAppMenuClickable test

HostedAppAshInteractiveUITest.MenuButtonClickable is flaky with
SingleProcessMash, and I think it could be the case of unstable
mouse location. When mouse move events occur during the test,
then the last mouse location could change and then further
mouse clicks occur on an unexpected location.

UIControlsFactoryOzone can remember the last specified location
and can use the remembered location for clicks. This will
stabilize the HostedAppAshInteractiveUITest.MenuButtonClickable,
and I hope others will get benefits.

BUG= 890953 
TEST=locally interactive_ui_tests --enable-features=SingleProcessMash

Change-Id: I3542a5a961dd4e7e8819e924d1d0c170c4dfaff1
Reviewed-on: https://chromium-review.googlesource.com/c/1255607
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596034}
[modify] https://crrev.com/1d4927a6c343310754c678e5792bd7c8ea39f187/ui/aura/test/ui_controls_factory_ozone.cc

Comment 2 by mukai@chromium.org, Oct 3

Status: Fixed (was: Assigned)
►

Sign in to add a comment