New issue
Advanced search Search tips

Issue 890951 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Feature

Blocked on:
issue 891829

Blocking:
issue 871872



Sign in to add a comment

All GPU tests failing on macOS 10.14

Project Member Reported by kbr@chromium.org, Oct 1

Issue description

Three new macOS 10.14 bots were just deployed for running GPU tests but unfortunately they're not running any tests successfully.

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%2010.14%20Release%20%28AMD%29

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%2010.14%20Release%20%28Intel%29

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%2010.14%20Release%20%28NVIDIA%29

The logs state:

(INFO) 2018-10-01 09:30:21,686 browser._LogBrowserInfo:100  Browser started (pid=2363).
(ERROR) 2018-10-01 09:30:21,687 browser.__init__:54  Failed with NotImplementedError while starting the browser backend.

which indicates it's failing here:

https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/internal/browser/browser.py?sq=package:chromium&g=0&l=54

We need to debug this on 10.14. Kyle, as pixel wrangler this week could you please log on to the Mac 10.14 Intel bot per the GPU internal pixel wrangling instructions, use the Python debugger to see what the nested exception is (or land code which dumps its stack trace) and try to get things into a working state?

Thanks.

 
Status: Started (was: Assigned)
I'll take a look.
Blockedon: 891829
Telemetry doesn't recognize the OS version number and errors out. I've uploaded https://crrev.com/c/1259389 to fix it.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/a38326ca79201f8c7de1c3d9074acb742fce66fd

commit a38326ca79201f8c7de1c3d9074acb742fce66fd
Author: kylechar <kylechar@chromium.org>
Date: Wed Oct 03 23:02:35 2018

Support macOS 10.14 Mojave.

Telemetry fails while starting the browser process because the OS
version number is unrecognized.

Bug:  chromium:890951 
Change-Id: Ica8e10a11ea39920a677f3d3af98e00ada5d6329
Reviewed-on: https://chromium-review.googlesource.com/c/1259389
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/a38326ca79201f8c7de1c3d9074acb742fce66fd/telemetry/telemetry/core/os_version.py
[modify] https://crrev.com/a38326ca79201f8c7de1c3d9074acb742fce66fd/telemetry/telemetry/internal/platform/mac_platform_backend.py

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fbe05fb32cf430baa5ff7f13704f6bee7abeab4

commit 8fbe05fb32cf430baa5ff7f13704f6bee7abeab4
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Oct 04 03:52:41 2018

Roll src/third_party/catapult 2dd914402ebc..0543f082e2f4 (7 commits)

https://chromium.googlesource.com/catapult.git/+log/2dd914402ebc..0543f082e2f4


git log 2dd914402ebc..0543f082e2f4 --date=short --no-merges --format='%ad %ae %s'
2018-10-03 khmel@chromium.org Fix flakiness of tests, that require GAIA login.
2018-10-03 kylechar@chromium.org Support macOS 10.14 Mojave.
2018-10-03 zmo@chromium.org Revert "Wire action_runner's Click through DevTools"
2018-10-03 chiniforooshan@chromium.org Telemetry: clean up legacy surface flinger metrics
2018-10-03 pasko@chromium.org androidStartupMetric: skip the first start
2018-10-03 benjhayden@chromium.org Fix flaky cp-toast.autoclose-only-last test.
2018-10-03 zmo@chromium.org Wire action_runner's Click through DevTools


Created with:
  gclient setdep -r src/third_party/catapult@0543f082e2f4

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:879353 , chromium:890951 ,chromium:885912, chromium:890757 , chromium:881384 ,chromium:885912
TBR=sullivan@chromium.org

Change-Id: I6e2ae7a29df4dcab18c0cde1e852ee159a3f12cf
Reviewed-on: https://chromium-review.googlesource.com/c/1260146
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#596495}
[modify] https://crrev.com/8fbe05fb32cf430baa5ff7f13704f6bee7abeab4/DEPS

Status: Fixed (was: Started)

Sign in to add a comment