New issue
Advanced search Search tips

Issue 890930 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 5
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: CopyBetweenWindows/FilesAppBrowserTest.Test



Sign in to add a comment

CopyBetweenWindows/FilesAppBrowserTest.Test?* is flaky

Project Member Reported by Findit, Oct 1

Issue description


Flaky test: CopyBetweenWindows/FilesAppBrowserTest.Test/copyBetweenWindowsDriveToLocal_DriveFs
Sample failed build due to flakiness: https://chromium-swarm.appspot.com/task?id=402dfae0f11fad10
Test output log: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/8710
Culprit (70.0% confidence): https://chromium-review.googlesource.com/q/I1a391af1e942bc4f4c5e993b9afcbbae67ff3905
Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy5gELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKvAWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bU9TIE1TYW4gVGVzdHMvODcxMC9icm93c2VyX3Rlc3RzL1EyOXdlVUpsZEhkbFpXNVhhVzVrYjNkekwwWnBiR1Z6UVhCd1FuSnZkM05sY2xSbGMzUXVWR1Z6ZEM5amIzQjVRbVYwZDJWbGJsZHBibVJ2ZDNORWNtbDJaVlJ2VEc5allXeGZSSEpwZG1WR2N3PT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

Please revert the culprit, or disable the test and find the appropriate owner.

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20CopyBetweenWindows/FilesAppBrowserTest.Test/copyBetweenWindowsDriveToLocal_DriveFs&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy5gELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKvAWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bU9TIE1TYW4gVGVzdHMvODcxMC9icm93c2VyX3Rlc3RzL1EyOXdlVUpsZEhkbFpXNVhhVzVrYjNkekwwWnBiR1Z6UVhCd1FuSnZkM05sY2xSbGMzUXVWR1Z6ZEM5amIzQjVRbVYwZDJWbGJsZHBibVJ2ZDNORWNtbDJaVlJ2VEc5allXeGZSSEpwZG1WR2N3PT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA
 
Owner: alexilin@chromium.org
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8934337943248186144/+/steps/browser_tests/0/logs/CopyBetweenWindows__x2f_FilesAppBrowserTest.Test__x2f_copyBetweenWindowsDriveToLocal_DriveFs/0

This appears to be saying that a member of GpuMemoryBufferHandle is not initialized, and it's being serialized to mojo. I think this is where the GpuMemoryBufferHandle is created: https://cs.chromium.org/chromium/src/components/viz/host/gpu_client.cc?type=cs&q=components/viz/host/gpu_client.cc:182&g=0&l=186

So this might be fixed by providing default values for members of GpuMemoryBufferHandle.
Cc: alexilin@chromium.org
Owner: thakis@chromium.org
I'll add an initialization for GpuMemoryBufferHandle members that aren't default-initialized. It doesn't explain though why we started seeing this issue only now. 

There was one recent change in GpuMemoryBufferHandle serialization: https://crrev.com/c/1251322

thakis@ could you take a look? It seems that the code path you've added is executed in the failing test.
Status: Assigned (was: Untriaged)
Owner: ----
Status: Untriaged (was: Assigned)
https://chromium-review.googlesource.com/c/chromium/src/+/1251322 didn't add any executable code, so I don't think it could cause any behavior change.
Cc: -alexilin@chromium.org
Owner: alexilin@chromium.org
Status: Assigned (was: Untriaged)
Ok, I have a patch in the CQ that may fix the issue, let's wait.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ae13a865a0a4fc22113708f19004f1194ade19c

commit 6ae13a865a0a4fc22113708f19004f1194ade19c
Author: Alexandr Ilin <alexilin@chromium.org>
Date: Tue Oct 02 15:35:11 2018

Initialize all members of GpuMemoryBufferHandle in the default ctor

GpuMemoryBufferHandle::offset and GpuMemoryBufferHandle::stride are not
initialized in the default constructor. These uninitialized members may be
serialized later by mojo that makes MSAN bot unhappy.

Bug:  890930 
Change-Id: I0663de62997d673b97907a8bd470e9834bdaf638
Reviewed-on: https://chromium-review.googlesource.com/1256786
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595850}
[modify] https://crrev.com/6ae13a865a0a4fc22113708f19004f1194ade19c/ui/gfx/gpu_memory_buffer.cc

Labels: -Sheriff-Chromium
Status: Fixed (was: Assigned)
The test is no longer flaky on the "Linux ChromiumOS MSan Tests" bot. 

I've checked that on the flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=CopyBetweenWindows%2FFilesAppBrowserTest.Test%2FcopyBetweenWindowsDriveToLocal_DriveFs

Sign in to add a comment