New issue
Advanced search Search tips

Issue 890925 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 12
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Increase test coverage for Dice

Project Member Reported by jochen@chromium.org, Oct 1

Issue description

we should make sure we have some more integration tests in addition to the unit tests

doesn't need to get merged back..
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ae20888007bcc7fae849a1f4fe98caea91bd047

commit 8ae20888007bcc7fae849a1f4fe98caea91bd047
Author: Jochen Eisinger <jochen@chromium.org>
Date: Tue Oct 02 13:15:30 2018

Add browser tests for turning off Dice via settings and in OTR

R=tangltom@chromium.org, msarda@chromium.org
BUG= 890925 

Change-Id: Ibbcd8c86e6398d2d5abbe55536297195f8b00afc
Reviewed-on: https://chromium-review.googlesource.com/1254148
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595811}
[modify] https://crrev.com/8ae20888007bcc7fae849a1f4fe98caea91bd047/chrome/browser/signin/dice_browsertest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df554d02051d43d493d30cdf39fb1ee7566355bf

commit df554d02051d43d493d30cdf39fb1ee7566355bf
Author: Jochen Eisinger <jochen@chromium.org>
Date: Fri Oct 12 07:53:09 2018

Add browser tests for when we show the cookie exception

Depending on the sync / sign-in state.

BUG= 890925 
R=tangltom@chromium.org, msarda@chromium.org

Change-Id: I784f13a4981250f851df770d111a13969a6892a6
Reviewed-on: https://chromium-review.googlesource.com/c/1273521
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599134}
[add] https://crrev.com/df554d02051d43d493d30cdf39fb1ee7566355bf/chrome/browser/browsing_data/counters/browsing_data_counter_utils_browsertest.cc
[modify] https://crrev.com/df554d02051d43d493d30cdf39fb1ee7566355bf/chrome/test/BUILD.gn

Status: Fixed (was: Started)
this were the two tests I had in mind, so closing again.

Sign in to add a comment