New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 890924 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Remove unused command from cros_sdk_lib.

Project Member Reported by saklein@chromium.org, Oct 1

Issue description

A command was built but never run. As a whole, it's been about a year since it was first added and since it not running has not been a problem in that time, removing it makes the most sense.

More context, courtesy of bmgordon@, the original author:
"Some versions of LVM don't auto-activate volumes, and it was meant to take care of that case. Considering that everybody's chroots have been working without it, I'd be tempted to just remove that command and assume that we must all be running new enough LVM to not need it."
 
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/8775060263d67635cb7c004f5cceeec68043fcf6

commit 8775060263d67635cb7c004f5cceeec68043fcf6
Author: Alex Klein <saklein@chromium.org>
Date: Tue Oct 02 20:23:10 2018

cros_sdk_lib: remove unused command.

Command was built but not run. Remove to simplify.

BUG= chromium:890924 
TEST=precq

Change-Id: I618e458d503b731c58940178d05035975cc09801
Reviewed-on: https://chromium-review.googlesource.com/1255183
Commit-Ready: Alex Klein <saklein@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Benjamin Gordon <bmgordon@chromium.org>

[modify] https://crrev.com/8775060263d67635cb7c004f5cceeec68043fcf6/lib/cros_sdk_lib.py

Status: Fixed (was: Started)

Sign in to add a comment