New issue
Advanced search Search tips

Issue 890916 link

Starred by 2 users
Status: Fixed
Owner:
mfo...@chromium.org
Closed: Oct 2
Cc:
mfo...@chromium.org
m...@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Casting a tab fails every time.

Project Member Reported by dbbrooks@chromium.org, Oct 1 
Chrome Version: 71.0.3567.0
OS: All
MR: 7118.1001.0.0

I haven't done a bisect yet, but it works with Chrome 71.0.3559.6. (Same MR version)

Note: Happens with WebUI and Harmony UI

What steps will reproduce the problem?
(1) Attempt to cast a tab

What is the expected result? Casting succeeds.

What happens instead? Just a never ending spinner in the dialog. Nothing else happens on the sender or receiver.

Internal feedback ID: 85696995055   

(From the logs: [SEVERE][browser] Error: Script error. ( @ Line: 0))

Comment 1 by dbbrooks@chromium.org, Oct 1

Description: Show this description

Comment 2 by mfo...@chromium.org, Oct 1 

Looks related:

extensions::mojo_bindings:3726 Uncaught TypeError: Cannot read property 'validate' of undefined
    at Validator.validateStructPointer (extensions::mojo_bindings:3726)
    at Function.Origin.validate (extensions::url/mojom/origin.mojom:76)
    at Validator.validateStructPointer (extensions::mojo_bindings:3726)
    at Function.MediaRouteProvider_CreateRoute_Params.validate (extensions::chrome/common/media_router/mojo/media_router.mojom:1107)
    at Array.validateMediaRouteProviderRequest (extensions::chrome/common/media_router/mojo/media_router.mojom:4599)
    at InterfaceEndpointClient.handleIncomingMessage (extensions::mojo_bindings:2587)
    at Router.accept (extensions::mojo_bindings:3180)
    at Connector.readMore_ (extensions::mojo_bindings:2177)

Comment 3 by mfo...@chromium.org, Oct 1

Owner: mfo...@chromium.org
Status: Started (was: Untriaged)
I have a fix for this in review: https://chromium-review.googlesource.com/c/chromium/src/+/1255585
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dca811434bb545bacf057c4caf0312aab379c1d6

commit dca811434bb545bacf057c4caf0312aab379c1d6
Author: mark a. foltz <mfoltz@chromium.org>
Date: Tue Oct 02 01:35:09 2018

[Media Router] Fix mojom imports for media_router_bindings.js.

r594911 added unguessable_token.mojom as a dependendy of origin.mojom.

This imports the JS bindings for unguessable_token.mojom into the
Media Router component extension bindings to prevent a JS exception
when validating a message that includes an Origin.

Bug:  890916 
Change-Id: I83426296abbf911587367ffbd0b002a6c1525522
Reviewed-on: https://chromium-review.googlesource.com/1255585
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595686}
[modify] https://crrev.com/dca811434bb545bacf057c4caf0312aab379c1d6/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
[modify] https://crrev.com/dca811434bb545bacf057c4caf0312aab379c1d6/chrome/renderer/resources/extensions/media_router_bindings.js
[modify] https://crrev.com/dca811434bb545bacf057c4caf0312aab379c1d6/chrome/renderer/resources/renderer_resources.grd

Comment 5 by mfo...@chromium.org, Oct 2

Status: Fixed (was: Started)
►

Sign in to add a comment