New issue
Advanced search Search tips

Issue 890902 link

Starred by 2 users
Status: Started
Owner:
jdoerrie@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 776257



Sign in to add a comment

Run clang-tidy modernize-use-auto

Project Member Reported by jdoerrie@chromium.org, Oct 1 
From https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html:

This check is responsible for using the auto type specifier for variable declarations to improve code readability and maintainability. For example:

std::vector<int>::iterator I = my_container.begin();
// transforms to:
auto I = my_container.begin();
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/698875bcfc0b68c53281ff527bca607107685aa7

commit 698875bcfc0b68c53281ff527bca607107685aa7
Author: jdoerrie <jdoerrie@chromium.org>
Date: Tue Oct 02 20:53:56 2018

[clang-tidy] Apply modernize-use-auto in /device

This change applies clang-tidy's modernize-use-auto [1] in /device.
This change does not rewrite new and cast expressions.

Reproduction steps:
- run clang-tidy's modernize-use-auto
- run git cl format
- manually remove unused typedefs due to -Wunused-local-typedef error

[1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html

This CL was uploaded by git cl split.

R=reillyg@chromium.org, rkc@chromium.org

Bug: 890902
Change-Id: Ic49b7caed2bbc9950b3aa580fea0e79da4043d2f
Reviewed-on: https://chromium-review.googlesource.com/c/1257883
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595973}
[modify] https://crrev.com/698875bcfc0b68c53281ff527bca607107685aa7/device/bluetooth/bluetooth_adapter.cc
[modify] https://crrev.com/698875bcfc0b68c53281ff527bca607107685aa7/device/bluetooth/bluetooth_remote_gatt_characteristic.cc
[modify] https://crrev.com/698875bcfc0b68c53281ff527bca607107685aa7/device/bluetooth/bluez/bluetooth_adapter_bluez.cc
[modify] https://crrev.com/698875bcfc0b68c53281ff527bca607107685aa7/device/bluetooth/bluez/bluetooth_remote_gatt_characteristic_bluez.cc
[modify] https://crrev.com/698875bcfc0b68c53281ff527bca607107685aa7/device/bluetooth/bluez/bluetooth_remote_gatt_descriptor_bluez.cc
[modify] https://crrev.com/698875bcfc0b68c53281ff527bca607107685aa7/device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.cc
[modify] https://crrev.com/698875bcfc0b68c53281ff527bca607107685aa7/device/bluetooth/dbus/bluetooth_device_client.cc
[modify] https://crrev.com/698875bcfc0b68c53281ff527bca607107685aa7/device/bluetooth/dbus/fake_bluetooth_device_client.cc
[modify] https://crrev.com/698875bcfc0b68c53281ff527bca607107685aa7/device/bluetooth/dbus/fake_bluetooth_gatt_descriptor_client.cc
[modify] https://crrev.com/698875bcfc0b68c53281ff527bca607107685aa7/device/bluetooth/dbus/fake_bluetooth_gatt_manager_client.cc
[modify] https://crrev.com/698875bcfc0b68c53281ff527bca607107685aa7/device/bluetooth/dbus/fake_bluetooth_le_advertising_manager_client.cc
[modify] https://crrev.com/698875bcfc0b68c53281ff527bca607107685aa7/device/bluetooth/dbus/fake_bluetooth_profile_manager_client.cc
[modify] https://crrev.com/698875bcfc0b68c53281ff527bca607107685aa7/device/gamepad/gamepad_data_fetcher_manager.cc
[modify] https://crrev.com/698875bcfc0b68c53281ff527bca607107685aa7/device/gamepad/gamepad_provider.cc
[modify] https://crrev.com/698875bcfc0b68c53281ff527bca607107685aa7/device/gamepad/gamepad_service.cc
[modify] https://crrev.com/698875bcfc0b68c53281ff527bca607107685aa7/device/usb/usb_descriptors.cc
[modify] https://crrev.com/698875bcfc0b68c53281ff527bca607107685aa7/device/usb/webusb_descriptors.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0539eeb7a60b3935deeb1c44775274566174738

commit d0539eeb7a60b3935deeb1c44775274566174738
Author: jdoerrie <jdoerrie@chromium.org>
Date: Tue Oct 02 20:54:29 2018

[clang-tidy] Apply modernize-use-auto in /remoting

This change applies clang-tidy's modernize-use-auto [1] in /remoting.
This change does not rewrite new and cast expressions.

Reproduction steps:
- run clang-tidy's modernize-use-auto
- run git cl format
- manually remove unused typedefs due to -Wunused-local-typedef error

[1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html

This CL was uploaded by git cl split.

R=joedow@chromium.org

Bug: 890902
Change-Id: Ib36073c54837ccd92347d202b539cef688d8402a
Reviewed-on: https://chromium-review.googlesource.com/c/1257908
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595974}
[modify] https://crrev.com/d0539eeb7a60b3935deeb1c44775274566174738/remoting/client/input/key_event_mapper.cc
[modify] https://crrev.com/d0539eeb7a60b3935deeb1c44775274566174738/remoting/client/input/normalizing_input_filter_mac.cc
[modify] https://crrev.com/d0539eeb7a60b3935deeb1c44775274566174738/remoting/host/chromoting_host.cc
[modify] https://crrev.com/d0539eeb7a60b3935deeb1c44775274566174738/remoting/host/ipc_desktop_environment.cc
[modify] https://crrev.com/d0539eeb7a60b3935deeb1c44775274566174738/remoting/host/remote_input_filter.cc
[modify] https://crrev.com/d0539eeb7a60b3935deeb1c44775274566174738/remoting/host/security_key/security_key_auth_handler_posix.cc
[modify] https://crrev.com/d0539eeb7a60b3935deeb1c44775274566174738/remoting/protocol/channel_multiplexer.cc
[modify] https://crrev.com/d0539eeb7a60b3935deeb1c44775274566174738/remoting/protocol/client_video_dispatcher.cc
[modify] https://crrev.com/d0539eeb7a60b3935deeb1c44775274566174738/remoting/protocol/fake_datagram_socket.cc
[modify] https://crrev.com/d0539eeb7a60b3935deeb1c44775274566174738/remoting/protocol/ice_transport.cc
[modify] https://crrev.com/d0539eeb7a60b3935deeb1c44775274566174738/remoting/protocol/jingle_session_manager.cc
[modify] https://crrev.com/d0539eeb7a60b3935deeb1c44775274566174738/remoting/protocol/pseudotcp_channel_factory.cc
[modify] https://crrev.com/d0539eeb7a60b3935deeb1c44775274566174738/remoting/protocol/secure_channel_factory.cc
[modify] https://crrev.com/d0539eeb7a60b3935deeb1c44775274566174738/remoting/signaling/iq_sender.cc
[modify] https://crrev.com/d0539eeb7a60b3935deeb1c44775274566174738/remoting/signaling/server_log_entry_unittest.cc
[modify] https://crrev.com/d0539eeb7a60b3935deeb1c44775274566174738/remoting/test/fake_network_dispatcher.cc
[modify] https://crrev.com/d0539eeb7a60b3935deeb1c44775274566174738/remoting/test/fake_socket_factory.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13cd648c8a4b961cf4fba58af327654738b72100

commit 13cd648c8a4b961cf4fba58af327654738b72100
Author: jdoerrie <jdoerrie@chromium.org>
Date: Tue Oct 02 21:21:02 2018

[clang-tidy] Apply modernize-use-auto in /chrome/browser/extensions

This change applies clang-tidy's modernize-use-auto [1] in /chrome/browser/extensions.
This change does not rewrite new and cast expressions.

Reproduction steps:
- run clang-tidy's modernize-use-auto
- run git cl format
- manually remove unused typedefs due to -Wunused-local-typedef error

[1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html

This CL was uploaded by git cl split.

R=rdevlin.cronin@chromium.org

Bug: 890902
Change-Id: Ic5efd3b6eefa2c950dcb85793e824835e6f79c32
Reviewed-on: https://chromium-review.googlesource.com/c/1257903
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595988}
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/activity_log/activity_log.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/activity_log/counting_policy.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/chrome_app_icon_loader.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/chrome_app_icon_service.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/chrome_app_sorting.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/chrome_app_sorting_unittest.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/chrome_component_extension_resource_manager.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/component_loader.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/context_menu_matcher.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/convert_user_script.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/crx_installer.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/default_apps.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/error_console/error_console.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/extension_action.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/extension_action_runner.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/extension_action_runner_unittest.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/extension_browsertest.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/extension_commands_global_registry_apitest.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/extension_garbage_collector.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/extension_keybinding_registry.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/extension_management.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/extension_service.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/extension_service_test_with_install.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/extension_service_unittest.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/extension_storage_monitor.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/extension_web_ui.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/external_pref_loader.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/external_provider_impl.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/global_shortcut_listener.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/install_signer.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/install_tracker.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/install_verifier.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/isolated_app_browsertest.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/menu_manager.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/plugin_manager.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/policy_handlers.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/shared_module_service.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/startup_helper_browsertest.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/updater/extension_cache_fake.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/updater/extension_updater_unittest.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/user_script_listener.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/warning_badge_service.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/webstore_inline_installer.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/webstore_inline_installer_unittest.cc
[modify] https://crrev.com/13cd648c8a4b961cf4fba58af327654738b72100/chrome/browser/extensions/window_controller_list.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84af0be3e33d0450cbe5571a5664e43fc019b5ad

commit 84af0be3e33d0450cbe5571a5664e43fc019b5ad
Author: jdoerrie <jdoerrie@chromium.org>
Date: Tue Oct 02 22:15:39 2018

[clang-tidy] Apply modernize-use-auto in /media

This change applies clang-tidy's modernize-use-auto [1] in /media.
This change does not rewrite new and cast expressions.

Reproduction steps:
- run clang-tidy's modernize-use-auto
- run git cl format
- manually remove unused typedefs due to -Wunused-local-typedef error

[1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html

This CL was uploaded by git cl split.

R=dalecurtis@chromium.org, tommi@chromium.org

Bug: 890902
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I223baa18f0318bb4c97570705d94bd9bc17c435b
Reviewed-on: https://chromium-review.googlesource.com/c/1257886
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596005}
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/audio/audio_manager_unittest.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/audio/audio_output_dispatcher_impl.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/audio/audio_output_resampler.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/audio/virtual_audio_input_stream.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/base/audio_renderer_mixer.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/base/cdm_promise_adapter.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/base/key_systems.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/base/mime_util_internal.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/base/seekable_buffer.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/base/test_data_util.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/base/text_renderer_unittest.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/blink/cdm_session_adapter.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/blink/lru_unittest.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/blink/multibuffer_unittest.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/capture/content/animated_content_sampler_unittest.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/capture/video/linux/v4l2_capture_delegate.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/capture/video/video_capture_system_impl.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/cdm/aes_decryptor.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/cdm/library_cdm/clear_key_cdm/cdm_file_io_test.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/filters/aom_video_decoder_unittest.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/filters/decrypting_audio_decoder.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/filters/ffmpeg_video_decoder_unittest.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/filters/gpu_video_decoder.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/filters/source_buffer_range_by_dts.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/filters/source_buffer_range_by_pts.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/filters/source_buffer_stream.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/filters/vpx_video_decoder_unittest.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/formats/mp4/box_definitions.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/formats/mp4/box_reader.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/formats/mp4/track_run_iterator.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/formats/webm/tracks_builder.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/formats/webm/webm_cluster_parser.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/formats/webm/webm_cluster_parser_unittest.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/gpu/h264_decoder.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/gpu/h264_dpb.cc
[modify] https://crrev.com/84af0be3e33d0450cbe5571a5664e43fc019b5ad/media/midi/usb_midi_descriptor_parser.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/601c715ffbec87fbf011168b2f8ae7884c9c22bb

commit 601c715ffbec87fbf011168b2f8ae7884c9c22bb
Author: jdoerrie <jdoerrie@chromium.org>
Date: Tue Oct 02 23:43:11 2018

[clang-tidy] Apply modernize-use-auto in /chrome/browser

This change applies clang-tidy's modernize-use-auto [1] in /chrome/browser.
This change does not rewrite new and cast expressions.

Reproduction steps:
- run clang-tidy's modernize-use-auto
- run git cl format
- manually remove unused typedefs due to -Wunused-local-typedef error

[1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html

This CL was uploaded by git cl split.

R=thestig@chromium.org

Bug: 890902
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Id50b106729a64268795a4ca170c62573fae65abc
Reviewed-on: https://chromium-review.googlesource.com/c/1257846
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596047}
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/about_flags_unittest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/apps/platform_apps/api/media_galleries/media_galleries_apitest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/apps/platform_apps/api/music_manager_private/device_id_linux.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/apps/platform_apps/app_browsertest_util.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/apps/platform_apps/app_load_service.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/autocomplete/search_provider_unittest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/autofill/captured_sites_test_utils.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/background/background_application_list_model_unittest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/background/background_contents_service.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/background/background_mode_manager.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/bookmarks/bookmark_html_writer.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/browsing_data/browsing_data_cache_storage_helper.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/browsing_data/browsing_data_cache_storage_helper_browsertest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/browsing_data/browsing_data_database_helper.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/browsing_data/browsing_data_database_helper_browsertest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/browsing_data/browsing_data_file_system_helper.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/browsing_data/browsing_data_file_system_helper_unittest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/browsing_data/browsing_data_flash_lso_helper.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/browsing_data/browsing_data_indexed_db_helper.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/browsing_data/browsing_data_indexed_db_helper_browsertest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/browsing_data/browsing_data_service_worker_helper.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/browsing_data/cookies_tree_model.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/browsing_data/mock_browsing_data_flash_lso_helper.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/captive_portal/captive_portal_browsertest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/content_settings/local_shared_objects_container.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/custom_handlers/protocol_handler_registry.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/download/download_core_service.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/download/download_core_service_impl.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/download/download_history_unittest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/download/download_path_reservation_tracker.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/download/download_prefs.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/download/download_query.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/download/download_request_limiter.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/geolocation/geolocation_permission_context_unittest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/history/redirect_browsertest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/importer/in_process_importer_bridge.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/importer/profile_writer.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/local_discovery/service_discovery_client_impl.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/media/capture_access_handler_base.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/media/router/discovery/dial/dial_registry.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/media/router/discovery/mdns/dns_sd_registry.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/media/webrtc/desktop_capture_access_handler.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/media/webrtc/media_capture_devices_dispatcher.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/media/webrtc/native_desktop_media_list.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/media/webrtc/native_desktop_media_list_unittest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/media/webrtc/permission_bubble_media_access_handler.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/media/webrtc/webrtc_browsertest_perf.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/media_galleries/fileapi/native_media_file_util_unittest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/media_galleries/gallery_watch_manager.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/media_galleries/media_file_system_registry.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/media_galleries/media_file_system_registry_unittest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/media_galleries/media_galleries_permission_controller.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/media_galleries/media_galleries_preferences.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/media_galleries/media_galleries_preferences_unittest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/metrics/extensions_metrics_provider.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/metrics/thread_watcher.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/metrics/thread_watcher_unittest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/nacl_host/nacl_browser_delegate_impl.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/net/referrer.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/password_manager/password_manager_captured_sites_interactive_uitest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/performance_monitor/performance_monitor.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/plugins/chrome_plugin_service_filter.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/plugins/plugin_finder.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/plugins/plugin_finder_unittest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/plugins/plugin_info_host_impl_unittest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/plugins/plugin_metadata.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/plugins/plugin_prefs.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/policy/cloud/cloud_policy_invalidator.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/policy/cloud/user_cloud_policy_manager_factory.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/policy/managed_bookmarks_policy_handler.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/policy/policy_prefs_browsertest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/policy/schema_registry_service_factory.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/predictors/autocomplete_action_predictor.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/predictors/autocomplete_action_predictor_table.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/predictors/loading_data_collector.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/prerender/prerender_history.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/prerender/prerender_link_manager.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/prerender/prerender_manager.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/prerender/prerender_unittest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/printing/cloud_print/privet_local_printer_lister.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/printing/cloud_print/privet_notifications.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/printing/print_job_manager.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/printing/print_preview_data_service.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/printing/print_preview_dialog_controller.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/printing/print_preview_pdf_generated_browsertest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/profile_resetter/profile_resetter_unittest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/profile_resetter/resettable_settings_snapshot.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/profiles/off_the_record_profile_io_data.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/profiles/profile_destroyer.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/profiles/profile_info_cache.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/profiles/profile_manager.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/profiles/profiles_state.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/renderer_context_menu/render_view_context_menu.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/renderer_context_menu/spelling_menu_observer.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/renderer_host/pepper/pepper_flash_clipboard_message_filter.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/resource_coordinator/render_process_probe.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/resource_coordinator/tab_memory_metrics_reporter.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/safe_browsing/browser_feature_extractor.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/safe_browsing/client_side_detection_host.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/safe_browsing/download_protection/download_protection_service.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/search_engines/template_url_service_sync_unittest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/service_process/service_process_control.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/sessions/session_restore.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/sessions/session_service.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/shell_integration_linux.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/speech/extension_api/tts_engine_extension_api.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/speech/extension_api/tts_extension_api.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/speech/tts_controller_impl.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/speech/tts_linux.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/spellchecker/spelling_service_client_unittest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/ssl/ssl_config_service_manager_pref.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/status_icons/status_icon_menu_model.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/supervised_user/child_accounts/family_info_fetcher.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/supervised_user/experimental/safe_search_url_reporter.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/sync/test/integration/apps_helper.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/sync/test/integration/extensions_helper.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/sync/test/integration/fake_server_invalidation_service.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/sync/test/integration/performance/typed_urls_sync_perf_test.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/sync/test/integration/preferences_helper.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/sync/test/integration/quiesce_status_change_checker.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/sync/test/integration/search_engines_helper.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/sync/test/integration/sessions_helper.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/sync/test/integration/sync_app_helper.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/sync/test/integration/sync_extension_helper.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/themes/browser_theme_pack.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/themes/browser_theme_pack_unittest.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/themes/theme_syncable_service.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/vr/ui.cc
[modify] https://crrev.com/601c715ffbec87fbf011168b2f8ae7884c9c22bb/chrome/browser/web_applications/components/web_app_icon_downloader.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4

commit 5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4
Author: jdoerrie <jdoerrie@chromium.org>
Date: Tue Oct 02 23:54:05 2018

[clang-tidy] Apply modernize-use-auto in /content/renderer

This change applies clang-tidy's modernize-use-auto [1] in /content/renderer.
This change does not rewrite new and cast expressions.

Reproduction steps:
- run clang-tidy's modernize-use-auto
- run git cl format
- manually remove unused typedefs due to -Wunused-local-typedef error

[1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html

This CL was uploaded by git cl split.

R=haraken@chromium.org

Bug: 890902
Change-Id: I50debb7aaf123e76bb03925e7720ab5be5dd16a8
Reviewed-on: https://chromium-review.googlesource.com/c/1257906
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596050}
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/appcache/appcache_frontend_impl.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/categorized_worker_pool.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/dom_storage/dom_storage_cached_area.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/dom_storage/dom_storage_dispatcher.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/image_downloader/image_downloader_impl.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/media/audio/audio_renderer_mixer_manager.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/media/media_permission_dispatcher.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/media/midi/midi_message_filter.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/media/stream/aec_dump_message_filter.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/media/stream/media_stream_device_observer.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/media/stream/media_stream_video_source.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/media/stream/media_stream_video_track.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/media/stream/user_media_processor.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/media/stream/video_track_adapter.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/media/webrtc/mock_peer_connection_impl.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/media/webrtc/peer_connection_tracker.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/media/webrtc/rtc_video_decoder.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/media/webrtc/webrtc_audio_renderer.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/p2p/ipc_network_manager.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/pepper/host_globals.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/pepper/host_var_tracker.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/pepper/pepper_broker.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/pepper/pepper_browser_connection.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/pepper/pepper_media_device_manager.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/pepper/pepper_plugin_instance_impl.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/pepper/pepper_plugin_registry.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/pepper/pepper_video_decoder_host.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/pepper/pepper_websocket_host.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/pepper/plugin_module.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/pepper/v8_var_converter.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/pepper/v8_var_converter_unittest.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/pepper/video_decoder_shim.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/render_view_impl.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/render_widget.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/v8_value_converter_impl.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/web_ui_extension_data.cc
[modify] https://crrev.com/5a73d0fa914f7b7c0c621f24e8b41fa87aeef9e4/content/renderer/worker_thread_registry.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6

commit db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6
Author: jdoerrie <jdoerrie@chromium.org>
Date: Tue Oct 02 23:55:14 2018

[clang-tidy] Apply modernize-use-auto in /chrome/browser/ui

This change applies clang-tidy's modernize-use-auto [1] in /chrome/browser/ui.
This change does not rewrite new and cast expressions.

Reproduction steps:
- run clang-tidy's modernize-use-auto
- run git cl format
- manually remove unused typedefs due to -Wunused-local-typedef error

[1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html

This CL was uploaded by git cl split.

R=sky@chromium.org

Bug: 890902
Change-Id: I1cb56cf91d4eae9289c1316d20714f3096b8a606
Reviewed-on: https://chromium-review.googlesource.com/c/1257847
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596051}
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/bookmarks/recently_used_folders_combo_model.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/browser.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/browser_finder.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/browser_list.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/fast_unload_controller.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/hung_plugin_tab_helper.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/input_method/input_method_engine_base.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/libgtkui/gtk_ui.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/libgtkui/menu_util.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/login/login_handler_browsertest.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/login/login_handler_test_utils.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/passwords/password_manager_presenter.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/startup/startup_browser_creator.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/tabs/pinned_tab_codec.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/tabs/tab_strip_model.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/tabs/tab_utils.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/toolbar/app_menu_model.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/toolbar/toolbar_actions_bar.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/toolbar/toolbar_actions_model.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/unload_controller.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/views/accelerator_table_unittest.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/views/content_setting_bubble_contents.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/views/desktop_capture/desktop_media_source_view.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/views/frame/global_menu_bar_x11.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/views/infobars/alternate_nav_infobar_view.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/views/tabs/tab_strip.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/views/toolbar/app_menu.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/views/toolbar/browser_actions_container.cc
[modify] https://crrev.com/db83e58fab5c78388cbeeb933d1ff8fbe1a46fc6/chrome/browser/ui/window_sizer/window_sizer.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641

commit 1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641
Author: jdoerrie <jdoerrie@chromium.org>
Date: Wed Oct 03 00:10:57 2018

[clang-tidy] Apply modernize-use-auto in /base

This change applies clang-tidy's modernize-use-auto [1] in /base.
This change does not rewrite new and cast expressions.

Reproduction steps:
- run clang-tidy's modernize-use-auto
- run git cl format
- manually remove unused typedefs due to -Wunused-local-typedef error

[1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html

This CL was uploaded by git cl split.

R=dcheng@chromium.org

Bug: 890902
Change-Id: I1e938b7c80ba50b8e8a0d90f4a0b57ac4e3ae5b5
Reviewed-on: https://chromium-review.googlesource.com/c/1257885
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596060}
[modify] https://crrev.com/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641/base/command_line.cc
[modify] https://crrev.com/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641/base/command_line_unittest.cc
[modify] https://crrev.com/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641/base/containers/flat_tree_unittest.cc
[modify] https://crrev.com/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641/base/containers/mru_cache_unittest.cc
[modify] https://crrev.com/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641/base/containers/stack_container_unittest.cc
[modify] https://crrev.com/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641/base/deferred_sequenced_task_runner.cc
[modify] https://crrev.com/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641/base/environment.cc
[modify] https://crrev.com/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641/base/files/file_path_watcher_linux.cc
[modify] https://crrev.com/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641/base/files/file_util_posix.cc
[modify] https://crrev.com/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641/base/i18n/build_utf8_validator_tables.cc
[modify] https://crrev.com/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641/base/metrics/field_trial.cc
[modify] https://crrev.com/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641/base/metrics/field_trial_params.cc
[modify] https://crrev.com/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641/base/metrics/histogram.cc
[modify] https://crrev.com/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641/base/metrics/histogram_delta_serialization.cc
[modify] https://crrev.com/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641/base/metrics/sample_map.cc
[modify] https://crrev.com/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641/base/observer_list_threadsafe_unittest.cc
[modify] https://crrev.com/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641/base/path_service.cc
[modify] https://crrev.com/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641/base/posix/global_descriptors.cc
[modify] https://crrev.com/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641/base/profiler/stack_sampling_profiler_unittest.cc
[modify] https://crrev.com/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641/base/strings/utf_offset_string_conversions.cc
[modify] https://crrev.com/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641/base/strings/utf_offset_string_conversions_unittest.cc
[modify] https://crrev.com/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641/base/supports_user_data.cc
[modify] https://crrev.com/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641/base/synchronization/waitable_event_posix.cc
[modify] https://crrev.com/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641/base/test/gtest_util.cc
[modify] https://crrev.com/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641/base/test/launcher/test_results_tracker.cc
[modify] https://crrev.com/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641/base/test/metrics/user_action_tester.cc
[modify] https://crrev.com/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641/base/test/scoped_feature_list.cc
[modify] https://crrev.com/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641/base/test/trace_event_analyzer.cc
[modify] https://crrev.com/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641/base/threading/thread_id_name_manager.cc
[modify] https://crrev.com/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641/base/trace_event/trace_log.cc
[modify] https://crrev.com/1c4b8ffd7dce9cdb811ed4a5b21b7fd7e730b641/base/vlog.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9f88ea7d44291628179941ea4547b6280b1bd3f

commit a9f88ea7d44291628179941ea4547b6280b1bd3f
Author: jdoerrie <jdoerrie@chromium.org>
Date: Wed Oct 03 00:55:24 2018

[clang-tidy] Apply modernize-use-auto in /cc

This change applies clang-tidy's modernize-use-auto [1] in /cc.
This change does not rewrite new and cast expressions.

Reproduction steps:
- run clang-tidy's modernize-use-auto
- run git cl format
- manually remove unused typedefs due to -Wunused-local-typedef error

[1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html

This CL was uploaded by git cl split.

R=ericrk@chromium.org

Bug: 890902
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I398d6825bee96b0612611c4b530a0ed458fd8e0a
Reviewed-on: https://chromium-review.googlesource.com/c/1257850
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596076}
[modify] https://crrev.com/a9f88ea7d44291628179941ea4547b6280b1bd3f/cc/base/list_container_unittest.cc
[modify] https://crrev.com/a9f88ea7d44291628179941ea4547b6280b1bd3f/cc/base/rolling_time_delta_history.cc
[modify] https://crrev.com/a9f88ea7d44291628179941ea4547b6280b1bd3f/cc/layers/layer.cc
[modify] https://crrev.com/a9f88ea7d44291628179941ea4547b6280b1bd3f/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/a9f88ea7d44291628179941ea4547b6280b1bd3f/cc/layers/scrollbar_layer_unittest.cc
[modify] https://crrev.com/a9f88ea7d44291628179941ea4547b6280b1bd3f/cc/raster/raster_buffer_provider_perftest.cc
[modify] https://crrev.com/a9f88ea7d44291628179941ea4547b6280b1bd3f/cc/raster/task_graph_work_queue.cc
[modify] https://crrev.com/a9f88ea7d44291628179941ea4547b6280b1bd3f/cc/test/task_graph_runner_test_template.cc
[modify] https://crrev.com/a9f88ea7d44291628179941ea4547b6280b1bd3f/cc/tiles/picture_layer_tiling.cc
[modify] https://crrev.com/a9f88ea7d44291628179941ea4547b6280b1bd3f/cc/tiles/picture_layer_tiling_unittest.cc
[modify] https://crrev.com/a9f88ea7d44291628179941ea4547b6280b1bd3f/cc/tiles/tile_manager.cc
[modify] https://crrev.com/a9f88ea7d44291628179941ea4547b6280b1bd3f/cc/trees/damage_tracker.cc
[modify] https://crrev.com/a9f88ea7d44291628179941ea4547b6280b1bd3f/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/a9f88ea7d44291628179941ea4547b6280b1bd3f/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/a9f88ea7d44291628179941ea4547b6280b1bd3f/cc/trees/property_tree.cc
[modify] https://crrev.com/a9f88ea7d44291628179941ea4547b6280b1bd3f/cc/trees/property_tree_builder.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f1af51f4b94859ec5a5172d8514b3c6f19c6746

commit 2f1af51f4b94859ec5a5172d8514b3c6f19c6746
Author: jdoerrie <jdoerrie@chromium.org>
Date: Wed Oct 03 00:59:37 2018

[clang-tidy] Apply modernize-use-auto in /chrome

This change applies clang-tidy's modernize-use-auto [1] in /chrome.
This change does not rewrite new and cast expressions.

Reproduction steps:
- run clang-tidy's modernize-use-auto
- run git cl format
- manually remove unused typedefs due to -Wunused-local-typedef error

[1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html

This CL was uploaded by git cl split.

R=thestig@chromium.org

Bug: 890902
Change-Id: Ie6085e93e6ab5d0a693a726433356f55cf8b53a7
Reviewed-on: https://chromium-review.googlesource.com/c/1257851
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596077}
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/browser/font_family_cache.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/browser/internal_auth.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/browser/memory_details.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/browser/memory_details_linux.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/browser/pepper_flash_settings_manager.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/browser/process_singleton_posix.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/common/crash_keys.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/common/extensions/api/commands/commands_manifest_unittest.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/common/extensions/api/common_extension_api_unittest.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/common/extensions/api/url_handlers/url_handlers_parser.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/common/extensions/chrome_extensions_client.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/common/extensions/command.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/common/pepper_permission_util.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/renderer/chrome_render_frame_observer.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/renderer/extensions/cast_streaming_native_handler.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/renderer/media/cast_transport_ipc.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/renderer/prerender/prerender_dispatcher.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/renderer/safe_browsing/phishing_term_feature_extractor.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/renderer/safe_browsing/phishing_url_feature_extractor.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/service/cloud_print/cloud_print_connector.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/service/cloud_print/connector_settings.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/service/cloud_print/printer_job_handler.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/services/media_gallery_util/media_metadata_parser.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/test/base/test_chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/test/base/test_launcher_utils.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/test/base/testing_profile_manager.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/test/base/v8_unit_test.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/test/chromedriver/capabilities.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/test/chromedriver/chrome/chrome_impl.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/test/chromedriver/chrome/devtools_client_impl.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/test/chromedriver/chrome/network_conditions.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/test/chromedriver/chrome/web_view_impl.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/test/chromedriver/commands.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/test/chromedriver/devtools_events_logger.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/test/chromedriver/element_util.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/test/chromedriver/key_converter_unittest.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/test/chromedriver/logging.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/test/data/nacl/exit_status/pm_exit_status_test.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/test/data/nacl/sysconf_nprocessors_onln/sysconf_nprocessors_onln_test.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/tools/convert_dict/aff_reader.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/tools/convert_dict/convert_dict_unittest.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/tools/convert_dict/dic_reader.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/utility/importer/external_process_importer_bridge.cc
[modify] https://crrev.com/2f1af51f4b94859ec5a5172d8514b3c6f19c6746/chrome/utility/importer/firefox_importer.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6fe63e6dc839ce96dc6ad417eaf382985d3e8b2

commit c6fe63e6dc839ce96dc6ad417eaf382985d3e8b2
Author: jdoerrie <jdoerrie@chromium.org>
Date: Wed Oct 03 20:53:40 2018

[clang-tidy] Apply modernize-use-auto in /chrome/browser/devtools

This change applies clang-tidy's modernize-use-auto [1] in /chrome/browser/devtools.
This change does not rewrite new and cast expressions.

Reproduction steps:
- run clang-tidy's modernize-use-auto
- run git cl format
- manually remove unused typedefs due to -Wunused-local-typedef error

[1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html

This CL was uploaded by git cl split.

R=caseq@chromium.org, nasko@chromium.org

Bug: 890902
Change-Id: I20c6bbcc7bab10107f7557d1e5f6cffe0c0d0d94
Reviewed-on: https://chromium-review.googlesource.com/c/1257887
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596351}
[modify] https://crrev.com/c6fe63e6dc839ce96dc6ad417eaf382985d3e8b2/chrome/browser/devtools/chrome_devtools_manager_delegate.cc
[modify] https://crrev.com/c6fe63e6dc839ce96dc6ad417eaf382985d3e8b2/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc
[modify] https://crrev.com/c6fe63e6dc839ce96dc6ad417eaf382985d3e8b2/chrome/browser/devtools/device/android_device_info_query.cc
[modify] https://crrev.com/c6fe63e6dc839ce96dc6ad417eaf382985d3e8b2/chrome/browser/devtools/device/android_device_manager.cc
[modify] https://crrev.com/c6fe63e6dc839ce96dc6ad417eaf382985d3e8b2/chrome/browser/devtools/device/devtools_android_bridge.cc
[modify] https://crrev.com/c6fe63e6dc839ce96dc6ad417eaf382985d3e8b2/chrome/browser/devtools/device/devtools_device_discovery.cc
[modify] https://crrev.com/c6fe63e6dc839ce96dc6ad417eaf382985d3e8b2/chrome/browser/devtools/device/port_forwarding_controller.cc
[modify] https://crrev.com/c6fe63e6dc839ce96dc6ad417eaf382985d3e8b2/chrome/browser/devtools/device/usb/android_usb_device.cc
[modify] https://crrev.com/c6fe63e6dc839ce96dc6ad417eaf382985d3e8b2/chrome/browser/devtools/device/usb/usb_device_provider.cc
[modify] https://crrev.com/c6fe63e6dc839ce96dc6ad417eaf382985d3e8b2/chrome/browser/devtools/devtools_embedder_message_dispatcher.cc
[modify] https://crrev.com/c6fe63e6dc839ce96dc6ad417eaf382985d3e8b2/chrome/browser/devtools/devtools_file_helper.cc
[modify] https://crrev.com/c6fe63e6dc839ce96dc6ad417eaf382985d3e8b2/chrome/browser/devtools/devtools_file_system_indexer.cc
[modify] https://crrev.com/c6fe63e6dc839ce96dc6ad417eaf382985d3e8b2/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/c6fe63e6dc839ce96dc6ad417eaf382985d3e8b2/chrome/browser/devtools/devtools_targets_ui.cc
[modify] https://crrev.com/c6fe63e6dc839ce96dc6ad417eaf382985d3e8b2/chrome/browser/devtools/devtools_ui_bindings.cc
[modify] https://crrev.com/c6fe63e6dc839ce96dc6ad417eaf382985d3e8b2/chrome/browser/devtools/devtools_window.cc
[modify] https://crrev.com/c6fe63e6dc839ce96dc6ad417eaf382985d3e8b2/chrome/browser/devtools/devtools_window_testing.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe63fd26a45a6fee4ba01c8714dbdce15888fa64

commit fe63fd26a45a6fee4ba01c8714dbdce15888fa64
Author: jdoerrie <jdoerrie@chromium.org>
Date: Thu Oct 04 09:49:57 2018

[clang-tidy] Apply modernize-use-auto in /components/sync

This change applies clang-tidy's modernize-use-auto [1] in /components/sync.
This change does not rewrite new and cast expressions.

Reproduction steps:
- run clang-tidy's modernize-use-auto
- run git cl format
- manually remove unused typedefs due to -Wunused-local-typedef error

[1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html

This CL was uploaded by git cl split.

R=mastiz@chromium.org

Bug: 890902
Change-Id: I4a816ae8d6a4f164bb11dfe1b8f81e6354cad70d
Reviewed-on: https://chromium-review.googlesource.com/c/1257849
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596561}
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/base/cryptographer.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/base/extensions_activity.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/base/immutable_unittest.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/base/progress_marker_map.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/device_info/device_info_sync_bridge.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/driver/data_type_manager_impl.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/driver/data_type_manager_impl_unittest.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/driver/data_type_status_table.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/driver/generic_change_processor.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/driver/model_association_manager_unittest.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/engine/model_safe_worker.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/engine/sync_backend_registrar.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/engine_impl/commit_processor.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/engine_impl/commit_util.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/engine_impl/cycle/nudge_tracker.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/engine_impl/directory_commit_contribution.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/engine_impl/directory_commit_contribution_unittest.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/engine_impl/get_updates_processor.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/engine_impl/js_mutation_event_observer.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/engine_impl/model_type_registry.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/engine_impl/sync_manager_impl.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/engine_impl/syncer_unittest.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/engine_impl/update_applicator.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/syncable/change_reorder_buffer.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/syncable/delete_journal.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/syncable/directory.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/syncable/directory_backing_store.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/syncable/directory_backing_store_unittest.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/syncable/directory_unittest.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/syncable/entry_kernel.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/syncable/parent_child_index.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/syncable/parent_child_index_unittest.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/syncable/syncable_delete_journal.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/syncable/syncable_id_unittest.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/syncable/syncable_util.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/syncable/syncable_write_transaction.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/test/engine/mock_model_type_processor.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/test/engine/test_syncable_utils.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/test/fake_server/sessions_hierarchy.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/test/null_directory_change_delegate.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/tools/sync_client.cc
[modify] https://crrev.com/fe63fd26a45a6fee4ba01c8714dbdce15888fa64/components/sync/tools/sync_listen_notifications.cc
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e6a651da4ed0e96ef1a8da878a8ee1e4befa5f0

commit 2e6a651da4ed0e96ef1a8da878a8ee1e4befa5f0
Author: jdoerrie <jdoerrie@chromium.org>
Date: Thu Oct 04 17:09:08 2018

[clang-tidy] Apply modernize-use-auto in /components/omnibox

This change applies clang-tidy's modernize-use-auto [1] in /components/omnibox.
This change does not rewrite new and cast expressions.

Reproduction steps:
- run clang-tidy's modernize-use-auto
- run git cl format
- manually remove unused typedefs due to -Wunused-local-typedef error

[1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html

This CL was uploaded by git cl split.

R=jdonnelly@chromium.org

Bug: 890902
Change-Id: I186f707ed819c7f2b1db042f9db6d0ccde2c57e7
Reviewed-on: https://chromium-review.googlesource.com/c/1257853
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596722}
[modify] https://crrev.com/2e6a651da4ed0e96ef1a8da878a8ee1e4befa5f0/components/omnibox/browser/answers_cache.cc
[modify] https://crrev.com/2e6a651da4ed0e96ef1a8da878a8ee1e4befa5f0/components/omnibox/browser/autocomplete_controller.cc
[modify] https://crrev.com/2e6a651da4ed0e96ef1a8da878a8ee1e4befa5f0/components/omnibox/browser/autocomplete_match.cc
[modify] https://crrev.com/2e6a651da4ed0e96ef1a8da878a8ee1e4befa5f0/components/omnibox/browser/autocomplete_result.cc
[modify] https://crrev.com/2e6a651da4ed0e96ef1a8da878a8ee1e4befa5f0/components/omnibox/browser/base_search_provider.cc
[modify] https://crrev.com/2e6a651da4ed0e96ef1a8da878a8ee1e4befa5f0/components/omnibox/browser/bookmark_provider_unittest.cc
[modify] https://crrev.com/2e6a651da4ed0e96ef1a8da878a8ee1e4befa5f0/components/omnibox/browser/history_provider.cc
[modify] https://crrev.com/2e6a651da4ed0e96ef1a8da878a8ee1e4befa5f0/components/omnibox/browser/history_quick_provider_unittest.cc
[modify] https://crrev.com/2e6a651da4ed0e96ef1a8da878a8ee1e4befa5f0/components/omnibox/browser/history_url_provider.cc
[modify] https://crrev.com/2e6a651da4ed0e96ef1a8da878a8ee1e4befa5f0/components/omnibox/browser/history_url_provider_unittest.cc
[modify] https://crrev.com/2e6a651da4ed0e96ef1a8da878a8ee1e4befa5f0/components/omnibox/browser/in_memory_url_index_types.cc
[modify] https://crrev.com/2e6a651da4ed0e96ef1a8da878a8ee1e4befa5f0/components/omnibox/browser/in_memory_url_index_unittest.cc
[modify] https://crrev.com/2e6a651da4ed0e96ef1a8da878a8ee1e4befa5f0/components/omnibox/browser/keyword_provider.cc
[modify] https://crrev.com/2e6a651da4ed0e96ef1a8da878a8ee1e4befa5f0/components/omnibox/browser/omnibox_field_trial.cc
[modify] https://crrev.com/2e6a651da4ed0e96ef1a8da878a8ee1e4befa5f0/components/omnibox/browser/omnibox_field_trial_unittest.cc
[modify] https://crrev.com/2e6a651da4ed0e96ef1a8da878a8ee1e4befa5f0/components/omnibox/browser/omnibox_metrics_provider.cc
[modify] https://crrev.com/2e6a651da4ed0e96ef1a8da878a8ee1e4befa5f0/components/omnibox/browser/scored_history_match.cc
[modify] https://crrev.com/2e6a651da4ed0e96ef1a8da878a8ee1e4befa5f0/components/omnibox/browser/search_provider.cc
[modify] https://crrev.com/2e6a651da4ed0e96ef1a8da878a8ee1e4befa5f0/components/omnibox/browser/search_suggestion_parser.cc
[modify] https://crrev.com/2e6a651da4ed0e96ef1a8da878a8ee1e4befa5f0/components/omnibox/browser/shortcuts_backend.cc
[modify] https://crrev.com/2e6a651da4ed0e96ef1a8da878a8ee1e4befa5f0/components/omnibox/browser/shortcuts_backend_unittest.cc
[modify] https://crrev.com/2e6a651da4ed0e96ef1a8da878a8ee1e4befa5f0/components/omnibox/browser/shortcuts_database.cc
[modify] https://crrev.com/2e6a651da4ed0e96ef1a8da878a8ee1e4befa5f0/components/omnibox/browser/shortcuts_database_unittest.cc
[modify] https://crrev.com/2e6a651da4ed0e96ef1a8da878a8ee1e4befa5f0/components/omnibox/browser/shortcuts_provider.cc
[modify] https://crrev.com/2e6a651da4ed0e96ef1a8da878a8ee1e4befa5f0/components/omnibox/browser/titled_url_match_utils.cc
[modify] https://crrev.com/2e6a651da4ed0e96ef1a8da878a8ee1e4befa5f0/components/omnibox/browser/url_index_private_data.cc
[modify] https://crrev.com/2e6a651da4ed0e96ef1a8da878a8ee1e4befa5f0/components/omnibox/browser/zero_suggest_provider.cc
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6a67d5cdd6c36a93d3c6d87e0627b6c9a9e519c

commit e6a67d5cdd6c36a93d3c6d87e0627b6c9a9e519c
Author: jdoerrie <jdoerrie@chromium.org>
Date: Thu Oct 04 20:37:48 2018

[clang-tidy] Apply modernize-use-auto in /extensions/browser/api

This change applies clang-tidy's modernize-use-auto [1] in /extensions/browser/api.
This change does not rewrite new and cast expressions.

Reproduction steps:
- run clang-tidy's modernize-use-auto
- run git cl format
- manually remove unused typedefs due to -Wunused-local-typedef error

[1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html

This CL was uploaded by git cl split.

R=tbarzic@chromium.org

Bug: 890902
Change-Id: I384b75d259cbfe7b97df52317ef02aa4506eb09d
Reviewed-on: https://chromium-review.googlesource.com/c/1257844
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596837}
[modify] https://crrev.com/e6a67d5cdd6c36a93d3c6d87e0627b6c9a9e519c/extensions/browser/api/alarms/alarm_manager.cc
[modify] https://crrev.com/e6a67d5cdd6c36a93d3c6d87e0627b6c9a9e519c/extensions/browser/api/bluetooth/bluetooth_event_router.cc
[modify] https://crrev.com/e6a67d5cdd6c36a93d3c6d87e0627b6c9a9e519c/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc
[modify] https://crrev.com/e6a67d5cdd6c36a93d3c6d87e0627b6c9a9e519c/extensions/browser/api/bluetooth_low_energy/utils.cc
[modify] https://crrev.com/e6a67d5cdd6c36a93d3c6d87e0627b6c9a9e519c/extensions/browser/api/declarative/rules_registry.cc
[modify] https://crrev.com/e6a67d5cdd6c36a93d3c6d87e0627b6c9a9e519c/extensions/browser/api/declarative/rules_registry_service.cc
[modify] https://crrev.com/e6a67d5cdd6c36a93d3c6d87e0627b6c9a9e519c/extensions/browser/api/declarative_webrequest/webrequest_condition.cc
[modify] https://crrev.com/e6a67d5cdd6c36a93d3c6d87e0627b6c9a9e519c/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc
[modify] https://crrev.com/e6a67d5cdd6c36a93d3c6d87e0627b6c9a9e519c/extensions/browser/api/declarative_webrequest/webrequest_rules_registry.cc
[modify] https://crrev.com/e6a67d5cdd6c36a93d3c6d87e0627b6c9a9e519c/extensions/browser/api/device_permissions_manager.cc
[modify] https://crrev.com/e6a67d5cdd6c36a93d3c6d87e0627b6c9a9e519c/extensions/browser/api/document_scan/document_scan_api.cc
[modify] https://crrev.com/e6a67d5cdd6c36a93d3c6d87e0627b6c9a9e519c/extensions/browser/api/file_handlers/app_file_handler_util.cc
[modify] https://crrev.com/e6a67d5cdd6c36a93d3c6d87e0627b6c9a9e519c/extensions/browser/api/idle/idle_manager.cc
[modify] https://crrev.com/e6a67d5cdd6c36a93d3c6d87e0627b6c9a9e519c/extensions/browser/api/management/management_api.cc
[modify] https://crrev.com/e6a67d5cdd6c36a93d3c6d87e0627b6c9a9e519c/extensions/browser/api/messaging/extension_message_port.cc
[modify] https://crrev.com/e6a67d5cdd6c36a93d3c6d87e0627b6c9a9e519c/extensions/browser/api/messaging/message_service.cc
[modify] https://crrev.com/e6a67d5cdd6c36a93d3c6d87e0627b6c9a9e519c/extensions/browser/api/networking_private/networking_private_api.cc
[modify] https://crrev.com/e6a67d5cdd6c36a93d3c6d87e0627b6c9a9e519c/extensions/browser/api/networking_private/networking_private_linux.cc
[modify] https://crrev.com/e6a67d5cdd6c36a93d3c6d87e0627b6c9a9e519c/extensions/browser/api/serial/serial_api.cc
[modify] https://crrev.com/e6a67d5cdd6c36a93d3c6d87e0627b6c9a9e519c/extensions/browser/api/socket/udp_socket.cc
[modify] https://crrev.com/e6a67d5cdd6c36a93d3c6d87e0627b6c9a9e519c/extensions/browser/api/storage/local_value_store_cache.cc
[modify] https://crrev.com/e6a67d5cdd6c36a93d3c6d87e0627b6c9a9e519c/extensions/browser/api/storage/settings_storage_quota_enforcer.cc
[modify] https://crrev.com/e6a67d5cdd6c36a93d3c6d87e0627b6c9a9e519c/extensions/browser/api/storage/settings_test_util.cc
[modify] https://crrev.com/e6a67d5cdd6c36a93d3c6d87e0627b6c9a9e519c/extensions/browser/api/storage/storage_api.cc
[modify] https://crrev.com/e6a67d5cdd6c36a93d3c6d87e0627b6c9a9e519c/extensions/browser/api/storage/storage_frontend.cc
[modify] https://crrev.com/e6a67d5cdd6c36a93d3c6d87e0627b6c9a9e519c/extensions/browser/api/system_display/system_display_api.cc
[modify] https://crrev.com/e6a67d5cdd6c36a93d3c6d87e0627b6c9a9e519c/extensions/browser/api/system_info/system_info_api.cc
[modify] https://crrev.com/e6a67d5cdd6c36a93d3c6d87e0627b6c9a9e519c/extensions/browser/api/web_request/web_request_api.cc
[modify] https://crrev.com/e6a67d5cdd6c36a93d3c6d87e0627b6c9a9e519c/extensions/browser/api/web_request/web_request_api_helpers.cc
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/712a7d9efd31c555231cd366fac9d994b1f84e56

commit 712a7d9efd31c555231cd366fac9d994b1f84e56
Author: jdoerrie <jdoerrie@chromium.org>
Date: Fri Oct 05 08:08:51 2018

[clang-tidy] Apply modernize-use-auto in /chrome/browser/sync_file_system

This change applies clang-tidy's modernize-use-auto [1] in /chrome/browser/sync_file_system.
This change does not rewrite new and cast expressions.

Reproduction steps:
- run clang-tidy's modernize-use-auto
- run git cl format
- manually remove unused typedefs due to -Wunused-local-typedef error

[1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html

This CL was uploaded by git cl split.

R=nhiroki@chromium.org

Bug: 890902
Change-Id: I787a26b538cb11b45a42dbf4573fcf7adef06e75
Reviewed-on: https://chromium-review.googlesource.com/c/1257907
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597029}
[modify] https://crrev.com/712a7d9efd31c555231cd366fac9d994b1f84e56/chrome/browser/sync_file_system/drive_backend/callback_tracker.cc
[modify] https://crrev.com/712a7d9efd31c555231cd366fac9d994b1f84e56/chrome/browser/sync_file_system/drive_backend/conflict_resolver.cc
[modify] https://crrev.com/712a7d9efd31c555231cd366fac9d994b1f84e56/chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc
[modify] https://crrev.com/712a7d9efd31c555231cd366fac9d994b1f84e56/chrome/browser/sync_file_system/drive_backend/leveldb_wrapper.cc
[modify] https://crrev.com/712a7d9efd31c555231cd366fac9d994b1f84e56/chrome/browser/sync_file_system/drive_backend/metadata_database.cc
[modify] https://crrev.com/712a7d9efd31c555231cd366fac9d994b1f84e56/chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc
[modify] https://crrev.com/712a7d9efd31c555231cd366fac9d994b1f84e56/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc
[modify] https://crrev.com/712a7d9efd31c555231cd366fac9d994b1f84e56/chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc
[modify] https://crrev.com/712a7d9efd31c555231cd366fac9d994b1f84e56/chrome/browser/sync_file_system/drive_backend/register_app_task.cc
[modify] https://crrev.com/712a7d9efd31c555231cd366fac9d994b1f84e56/chrome/browser/sync_file_system/drive_backend/sync_worker.cc
[modify] https://crrev.com/712a7d9efd31c555231cd366fac9d994b1f84e56/chrome/browser/sync_file_system/drive_backend/task_dependency_manager.cc
[modify] https://crrev.com/712a7d9efd31c555231cd366fac9d994b1f84e56/chrome/browser/sync_file_system/fake_remote_change_processor.cc
[modify] https://crrev.com/712a7d9efd31c555231cd366fac9d994b1f84e56/chrome/browser/sync_file_system/local/local_file_change_tracker.cc
[modify] https://crrev.com/712a7d9efd31c555231cd366fac9d994b1f84e56/chrome/browser/sync_file_system/local/local_file_sync_context_unittest.cc
[modify] https://crrev.com/712a7d9efd31c555231cd366fac9d994b1f84e56/chrome/browser/sync_file_system/local/local_file_sync_service.cc
[modify] https://crrev.com/712a7d9efd31c555231cd366fac9d994b1f84e56/chrome/browser/sync_file_system/local/local_file_sync_status.cc
[modify] https://crrev.com/712a7d9efd31c555231cd366fac9d994b1f84e56/chrome/browser/sync_file_system/subtree_set.cc
[modify] https://crrev.com/712a7d9efd31c555231cd366fac9d994b1f84e56/chrome/browser/sync_file_system/sync_file_system_service_factory.cc
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22a91d8b9267a199ebbd94c0d34d250932f36b1d

commit 22a91d8b9267a199ebbd94c0d34d250932f36b1d
Author: jdoerrie <jdoerrie@chromium.org>
Date: Fri Oct 05 08:43:26 2018

[clang-tidy] Apply modernize-use-auto in /net

This change applies clang-tidy's modernize-use-auto [1] in /net.
This change does not rewrite new and cast expressions.

Reproduction steps:
- run clang-tidy's modernize-use-auto
- run git cl format
- manually remove unused typedefs due to -Wunused-local-typedef error
  in //net/test/url_request/url_request_slow_download_job.cc.

[1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html

This CL was uploaded by git cl split.

R=eroman@chromium.org

Bug: 890902
Change-Id: Idf97f430cc571be05d1b69615d43ff34ef1ce64d
Reviewed-on: https://chromium-review.googlesource.com/c/1257843
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597036}
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/base/address_list.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/base/address_tracker_linux.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/base/ip_pattern.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/base/mime_util.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/base/network_interfaces_linux.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/base/network_interfaces_unittest.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/base/port_util.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/cert/cert_verify_proc_nss.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/cert/crl_set.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/cert/ct_log_verifier.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/cert/ev_root_ca_metadata.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/cert/internal/certificate_policies.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/cert/internal/verify_name_match.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/cert/multi_threaded_cert_verifier.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/cert/pem_tokenizer.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/cert_net/cert_net_fetcher_impl.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/cookies/cookie_monster.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/cookies/cookie_monster_change_dispatcher.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/cookies/cookie_monster_store_test.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/cookies/cookie_monster_unittest.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/cookies/cookie_util.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/cookies/parsed_cookie.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/disk_cache/blockfile/backend_impl.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/disk_cache/blockfile/in_flight_io.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/disk_cache/blockfile/rankings.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/disk_cache/memory/mem_backend_impl.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/disk_cache/memory/mem_entry_impl.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/disk_cache/simple/simple_backend_impl.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/disk_cache/simple/simple_file_tracker.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/disk_cache/simple/simple_index.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/disk_cache/simple/simple_index_file.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/disk_cache/simple/simple_index_file_unittest.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/disk_cache/simple/simple_index_unittest.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/disk_cache/simple/simple_synchronous_entry.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/dns/address_sorter_posix_unittest.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/dns/dns_test_util.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/dns/host_cache.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/dns/host_resolver_impl.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/dns/mdns_cache.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/dns/mdns_client_impl.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/dns/mock_host_resolver.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/extras/sqlite/sqlite_channel_id_store.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/extras/sqlite/sqlite_persistent_cookie_store.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/ftp/ftp_auth_cache.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/ftp/ftp_network_transaction_unittest.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/http/http_auth_cache.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/http/http_auth_handler_factory.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/http/http_cache_writers.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/http/http_network_session.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/http/http_request_headers.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/http/http_server_properties_impl.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/http/http_server_properties_impl_unittest.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/http/http_server_properties_manager.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/http/http_server_properties_manager_unittest.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/http/http_stream_factory_unittest.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/http/mock_http_cache.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/http/transport_security_state.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/log/net_log_util.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/network_error_logging/network_error_logging_service.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/nqe/network_quality_estimator_unittest.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/nqe/network_quality_store.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/nqe/throughput_analyzer.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/proxy_resolution/mock_proxy_resolver.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/proxy_resolution/multi_threaded_proxy_resolver.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/proxy_resolution/pac_file_decider_unittest.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/proxy_resolution/proxy_bypass_rules.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/proxy_resolution/proxy_config.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/proxy_resolution/proxy_config_service_common_unittest.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/proxy_resolution/proxy_config_service_linux.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/proxy_resolution/proxy_list.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/proxy_resolution/proxy_resolution_service.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/proxy_resolution/proxy_resolution_service_unittest.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/proxy_resolution/proxy_resolver_v8_tracing.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/quic/quic_chromium_client_session.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/quic/quic_connection_logger.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/quic/quic_stream_factory.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/quic/quic_stream_factory_peer.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/quic/quic_stream_factory_test.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/quic/test_task_runner.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/socket/client_socket_pool_base.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/socket/client_socket_pool_base_unittest.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/socket/client_socket_pool_manager_impl.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/socket/transport_client_socket_pool.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/socket/websocket_endpoint_lock_manager.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/socket/websocket_transport_client_socket_pool.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/spdy/buffered_spdy_framer.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/spdy/http2_priority_dependencies.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/spdy/http2_push_promise_index_test.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/spdy/spdy_session.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/spdy/spdy_session_pool.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/spdy/spdy_test_util_common.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/ssl/channel_id_service.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/ssl/channel_id_store.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/ssl/default_channel_id_store.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/ssl/default_channel_id_store_unittest.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/ssl/ssl_client_auth_cache.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/test/spawned_test_server/base_test_server.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/test/spawned_test_server/local_test_server.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/test/spawned_test_server/local_test_server_posix.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/test/url_request/url_request_slow_download_job.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/third_party/quic/core/congestion_control/general_loss_algorithm.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/third_party/quic/core/crypto/cert_compressor.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/third_party/quic/core/crypto/crypto_framer.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/third_party/quic/core/crypto/crypto_handshake_message.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/third_party/quic/core/crypto/quic_crypto_client_config.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/third_party/quic/core/crypto/quic_crypto_server_config.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/third_party/quic/core/frames/quic_frame.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/third_party/quic/core/http/end_to_end_test.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/third_party/quic/core/http/quic_client_push_promise_index.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/third_party/quic/core/http/quic_spdy_client_session_base.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/third_party/quic/core/qpack/qpack_header_table.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/third_party/quic/core/quic_connection.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/third_party/quic/core/quic_dispatcher.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/third_party/quic/core/quic_framer.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/third_party/quic/core/quic_received_packet_manager.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/third_party/quic/core/quic_sent_packet_manager.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/third_party/quic/core/quic_session.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/third_party/quic/core/quic_time_wait_list_manager.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/third_party/quic/core/quic_unacked_packet_map.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/third_party/quic/test_tools/crypto_test_utils.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/third_party/quic/test_tools/packet_dropping_test_writer.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/third_party/quic/test_tools/quic_sent_packet_manager_peer.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/third_party/spdy/core/hpack/hpack_header_table.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/third_party/spdy/core/hpack/hpack_header_table_test.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/third_party/spdy/core/spdy_alt_svc_wire_format.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/third_party/spdy/core/spdy_alt_svc_wire_format_test.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/third_party/spdy/core/spdy_framer.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/tools/epoll_server/epoll_server.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/tools/huffman_trie/trie/trie_writer.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/tools/quic/quic_http_proxy_backend.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/tools/quic/quic_http_proxy_backend_test.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/tools/tld_cleanup/tld_cleanup_util.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/tools/transport_security_state_generator/input_file_parsers_unittest.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/tools/transport_security_state_generator/transport_security_state_entry.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/tools/transport_security_state_generator/transport_security_state_generator.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/url_request/test_url_fetcher_factory.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/url_request/test_url_request_interceptor.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/url_request/url_request_filter.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/url_request/url_request_http_job.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/url_request/url_request_job_factory_impl.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/url_request/url_request_test_util.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/url_request/url_request_throttler_manager.cc
[modify] https://crrev.com/22a91d8b9267a199ebbd94c0d34d250932f36b1d/net/url_request/url_request_throttler_simulation_unittest.cc
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9be0b2b7f4a0a52421422b5a94f79fe57700983a

commit 9be0b2b7f4a0a52421422b5a94f79fe57700983a
Author: jdoerrie <jdoerrie@chromium.org>
Date: Fri Oct 05 10:10:05 2018

[clang-tidy] Apply modernize-use-auto in /chrome/browser/extensions/api

This change applies clang-tidy's modernize-use-auto [1] in /chrome/browser/extensions/api.
This change does not rewrite new and cast expressions.

Reproduction steps:
- run clang-tidy's modernize-use-auto
- run git cl format
- manually remove unused typedefs due to -Wunused-local-typedef error

[1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html

This CL was uploaded by git cl split.

R=tbarzic@chromium.org

Bug: 890902
Change-Id: Ie70b063af990199a2c23956114a026264d8a7e67
Reviewed-on: https://chromium-review.googlesource.com/c/1257905
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597062}
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/commands/command_service.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/content_settings/content_settings_api.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/debugger/debugger_api.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/debugger/extension_dev_tools_infobar.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/declarative_content/content_action.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/declarative_content/declarative_content_css_condition_tracker.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/downloads/downloads_api.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/file_system/file_system_apitest.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/font_settings/font_settings_api.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/gcm/gcm_api.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/identity/extension_token_key_unittest.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/identity/identity_api.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/image_writer_private/operation_manager.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/mdns/mdns_api.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/messaging/incognito_connectability.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/messaging/native_messaging_host_manifest.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/notifications/notifications_api.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/permissions/permissions_api_helpers.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/preference/preference_api.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/sessions/sessions_apitest.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/storage/managed_value_store_cache.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/storage/policy_value_store.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/storage/settings_sync_processor.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/storage/settings_sync_unittest.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/storage/sync_storage_backend.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/streams_private/streams_private_api.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/tab_capture/offscreen_tabs_owner.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/tabs/tabs_api.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
[modify] https://crrev.com/9be0b2b7f4a0a52421422b5a94f79fe57700983a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
Project Member

Comment 18 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3feb1854e19737b9e7120c30b376def58d5bc139

commit 3feb1854e19737b9e7120c30b376def58d5bc139
Author: jdoerrie <jdoerrie@chromium.org>
Date: Fri Oct 05 12:16:44 2018

[clang-tidy] Apply modernize-use-auto in /components

This change applies clang-tidy's modernize-use-auto [1] in /components.
This change does not rewrite new and cast expressions.

Reproduction steps:
- run clang-tidy's modernize-use-auto
- run git cl format
- manually remove unused typedefs due to -Wunused-local-typedef error

[1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html

This CL was uploaded by git cl split.

R=jochen@chromium.org

Bug: 890902
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ibbb775036736e0b07c6ce5393569ed40878b5c62
Reviewed-on: https://chromium-review.googlesource.com/c/1257852
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597078}
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/app_modal/javascript_app_modal_dialog.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/autofill/content/renderer/password_autofill_agent.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/autofill/core/browser/address_rewriter.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/autofill/core/browser/autofill_data_util.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/autofill/core/browser/autofill_profile.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/autofill/core/browser/test_autofill_manager.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/autofill/core/browser/webdata/autofill_table_unittest.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/bookmarks/browser/bookmark_codec.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/bookmarks/browser/bookmark_expanded_state_tracker.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/bookmarks/browser/bookmark_node.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/bookmarks/browser/bookmark_node_data.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/bookmarks/browser/bookmark_utils.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/bookmarks/browser/titled_url_index.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/bookmarks/browser/titled_url_match.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/browser_sync/profile_sync_service_bookmark_unittest.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/certificate_transparency/chrome_require_ct_delegate.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/component_updater/component_updater_command_line_config_policy.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/content_settings/core/browser/content_settings_origin_identifier_value_map.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/content_settings/core/browser/content_settings_usages_state.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/device_event_log/device_event_log_impl.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/discardable_memory/common/discardable_shared_memory_heap.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/discardable_memory/service/discardable_shared_memory_manager.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/dom_distiller/core/distiller.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/dom_distiller/core/dom_distiller_model.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/dom_distiller/core/dom_distiller_store.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/dom_distiller/core/dom_distiller_store_unittest.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/dom_distiller/core/dom_distiller_test_util.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/dom_distiller/webui/dom_distiller_handler.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/domain_reliability/context_manager.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/download/content/public/all_download_item_notifier.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/download/internal/common/download_item_impl.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/download/internal/common/parallel_download_utils.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/drive/file_change.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/favicon/core/favicon_handler.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/favicon_base/favicon_util.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/favicon_base/select_favicon_frames.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/feed/core/feed_journal_database.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/feedback/tracing_manager.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/flags_ui/pref_service_flags_storage.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/gcm_driver/account_tracker.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/gcm_driver/account_tracker_unittest.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/gcm_driver/gcm_account_mapper.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/gcm_driver/gcm_account_mapper_unittest.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/gcm_driver/gcm_account_tracker.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/gcm_driver/gcm_account_tracker_unittest.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/gcm_driver/gcm_client_impl.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/gcm_driver/gcm_client_impl_unittest.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/gcm_driver/gcm_driver.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/gcm_driver/registration_info.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/history/core/browser/download_database.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/history/core/browser/expire_history_backend.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/history/core/browser/expire_history_backend_unittest.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/history/core/browser/history_backend.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/history/core/browser/history_backend_unittest.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/history/core/browser/history_types.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/history/core/browser/sync/delete_directive_handler.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/history/core/browser/sync/typed_url_sync_bridge.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/history/core/browser/thumbnail_database.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/history/core/browser/top_sites_cache.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/history/core/browser/top_sites_impl.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/history/core/browser/visit_database.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/image_fetcher/core/image_fetcher_impl.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/infobars/core/infobar_container.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/infobars/core/infobar_manager.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/keyed_service/core/dependency_graph.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/leveldb_proto/proto_database_impl_unittest.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/login/screens/screen_context.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/nacl/browser/nacl_browser.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/nacl/browser/pnacl_host.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/nacl/loader/nacl_ipc_adapter.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/nacl/loader/nacl_listener.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/nacl/renderer/nexe_load_manager.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/nacl/renderer/pnacl_translation_resource_host.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/network_hints/renderer/renderer_dns_prefetch.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/network_session_configurator/browser/network_session_configurator.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/ntp_snippets/category_rankers/click_based_category_ranker.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/ntp_snippets/remote/prefetched_pages_tracker_impl.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/ntp_tiles/webui/ntp_tiles_internals_message_handler.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/offline_items_collection/core/throttled_offline_content_provider.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/password_manager/core/browser/form_parsing/form_parser.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/password_manager/core/browser/password_syncable_service.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/password_manager/core/browser/password_syncable_service_unittest.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/password_manager/core/browser/test_password_store.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/payments/content/installable_payment_app_crawler.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/plugins/renderer/webview_plugin.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/prefs/pref_member.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/prefs/pref_notifier_impl_unittest.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/prefs/pref_service.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/query_parser/query_parser.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/query_parser/snippet.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/rappor/test_rappor_service.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/safe_browsing/base_blocking_page.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/safe_browsing/browser/threat_details.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/safe_browsing/browser/threat_details_cache.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/safe_browsing/db/database_manager.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/safe_browsing/db/v4_get_hash_protocol_manager.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/search_engines/keyword_table.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/search_engines/search_host_to_urls_map.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/search_engines/search_host_to_urls_map_unittest.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/search_engines/template_url.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/search_engines/template_url_service.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/search_engines/template_url_unittest.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/search_engines/util.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/sessions/core/persistent_tab_restore_service.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/sessions/core/tab_restore_service_helper.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/signin/core/browser/about_signin_internals.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/signin/core/browser/account_reconcilor.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/signin/core/browser/account_reconcilor_unittest.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/signin/core/browser/child_account_info_fetcher_impl.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/signin/core/browser/fake_profile_oauth2_token_service.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/signin/core/browser/gaia_cookie_manager_service.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/signin/core/browser/signin_error_controller.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/storage_monitor/media_storage_util.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/storage_monitor/storage_monitor.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/storage_monitor/storage_monitor_linux.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/storage_monitor/transient_device_ids.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/suggestions/blacklist_store.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/suggestions/blacklist_store_unittest.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/suggestions/image_manager.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/suggestions/webui/suggestions_source.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/sync_bookmarks/bookmark_change_processor.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/sync_bookmarks/bookmark_model_associator.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/sync_preferences/pref_model_associator.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/sync_preferences/pref_service_syncable_unittest.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/sync_preferences/synced_pref_change_registrar.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/sync_sessions/favicon_cache.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/sync_sessions/favicon_cache_unittest.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/sync_sessions/session_store.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/sync_sessions/sessions_sync_manager.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/sync_sessions/sessions_sync_manager_unittest.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/sync_sessions/synced_session_tracker.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/sync_sessions/tab_node_pool.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/translate/core/browser/translate_language_list.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/translate/core/browser/translate_prefs.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/translate/core/browser/translate_script.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/ui_devtools/devtools_server.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/url_formatter/url_formatter.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/url_matcher/regex_set_matcher.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/url_matcher/substring_set_matcher.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/url_matcher/url_matcher.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/url_matcher/url_matcher_factory.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/variations/active_field_trials_unittest.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/variations/variations_seed_processor_unittest.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/visitedlink/browser/visitedlink_event_listener.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/visitedlink/browser/visitedlink_master.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/viz/client/frame_eviction_manager.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/viz/service/display/display_resource_provider.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/viz/service/frame_sinks/surface_resource_holder.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/viz/test/ordered_texture_map.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/viz/test/test_gles2_interface.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/web_cache/browser/web_cache_manager.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/web_cache/browser/web_cache_manager_unittest.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/webcrypto/algorithms/sha_unittest.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/webdata/common/web_database.cc
[modify] https://crrev.com/3feb1854e19737b9e7120c30b376def58d5bc139/components/zoom/page_zoom.cc
Project Member

Comment 19 by bugdroid1@chromium.org, Oct 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55ec69dc51607ab238c721ff5e769b5529799d51

commit 55ec69dc51607ab238c721ff5e769b5529799d51
Author: jdoerrie <jdoerrie@chromium.org>
Date: Mon Oct 08 13:34:46 2018

[clang-tidy] Apply modernize-use-auto in /content/browser

This change applies clang-tidy's modernize-use-auto [1] in /content/browser.
This change does not rewrite new and cast expressions.

Reproduction steps:
- run clang-tidy's modernize-use-auto
- run git cl format
- manually remove unused typedefs due to -Wunused-local-typedef error

[1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html

This CL was uploaded by git cl split.

R=boliu@chromium.org, mkwst@chromium.org

Bug: 890902
Change-Id: I06146497aa7a8cba7516eb17497ca33454141b2a
Reviewed-on: https://chromium-review.googlesource.com/c/1257909
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597544}
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/accessibility/accessibility_tree_formatter_auralinux.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/appcache/appcache.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/appcache/appcache_group.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/appcache/appcache_storage_impl.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/appcache/appcache_update_job.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/appcache/appcache_update_job_unittest.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/background_sync/background_sync_manager.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/browser_child_process_host_impl.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/browsing_instance.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/cache_storage/cache_storage.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/cache_storage/cache_storage_manager.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/child_process_security_policy_impl.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/devtools/devtools_agent_host_impl.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/devtools/devtools_http_handler.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/dom_storage/dom_storage_context_impl.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/dom_storage/dom_storage_database.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/dom_storage/dom_storage_database_unittest.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/dom_storage/dom_storage_namespace.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/dom_storage/session_storage_context_mojo.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/dom_storage/session_storage_database.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/dom_storage/session_storage_database_unittest.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/dom_storage/session_storage_metadata.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/dom_storage/session_storage_namespace_impl_mojo_unittest.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/dom_storage/storage_area_impl.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/download/download_manager_impl_unittest.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/download/save_package.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/frame_host/debug_urls.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/frame_host/frame_tree.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/frame_host/frame_tree_node.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/frame_host/interstitial_page_impl.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/frame_host/navigation_controller_impl.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/frame_host/navigation_controller_impl_unittest.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/frame_host/navigation_entry_impl.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/frame_host/origin_policy_throttle.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/frame_host/render_frame_host_manager.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/frame_host/render_frame_proxy_host.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/gpu/gpu_data_manager_impl_private.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/histogram_synchronizer.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/host_zoom_map_impl.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/indexed_db/indexed_db_active_blob_registry.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/indexed_db/indexed_db_backing_store.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/indexed_db/indexed_db_context_impl.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/indexed_db/indexed_db_factory_impl.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/indexed_db/indexed_db_transaction_coordinator.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/indexed_db/leveldb/leveldb_transaction.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/media/capture/audio_mirroring_manager.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/media/capture/audio_mirroring_manager_unittest.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/media/capture/desktop_streams_registry_impl.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/notification_service_impl.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/plugin_data_remover_impl.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/plugin_service_impl.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/renderer_host/media/audio_input_device_manager.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/renderer_host/media/media_stream_manager.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/renderer_host/media/media_stream_track_metrics_host.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/renderer_host/media/video_capture_manager.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/renderer_host/media/video_capture_manager_unittest.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/renderer_host/pepper/quota_reservation.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/renderer_host/pepper/quota_reservation_unittest.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/renderer_host/render_widget_helper.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/service_worker/embedded_worker_registry.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/service_worker/service_worker_context_core.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/service_worker/service_worker_database.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/service_worker/service_worker_internals_ui.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/service_worker/service_worker_script_cache_map.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/speech/speech_recognition_engine_unittest.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/speech/speech_recognizer_impl.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/ssl/ssl_manager.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/startup_task_runner.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/storage_partition_impl_map.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/streams/stream_registry.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/tracing/tracing_controller_impl.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/tracing/tracing_ui.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/web_contents/aura/overscroll_navigation_overlay.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/webrtc/webrtc_getusermedia_browsertest.cc
[modify] https://crrev.com/55ec69dc51607ab238c721ff5e769b5529799d51/content/browser/webui/url_data_manager_backend.cc
Project Member

Comment 20 by bugdroid1@chromium.org, Oct 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/151067a8940fe31bafbbd04d9bd34cb6b3effa97

commit 151067a8940fe31bafbbd04d9bd34cb6b3effa97
Author: jdoerrie <jdoerrie@chromium.org>
Date: Tue Oct 09 20:24:13 2018

[clang-tidy] Apply modernize-use-auto in /chrome/browser/ui/webui

This change applies clang-tidy's modernize-use-auto [1] in /chrome/browser/ui/webui.
This change does not rewrite new and cast expressions.

Reproduction steps:
- run clang-tidy's modernize-use-auto
- run git cl format
- manually remove unused typedefs due to -Wunused-local-typedef error

[1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html

This CL was uploaded by git cl split.

R=dpapad@chromium.org

Bug: 890902
Change-Id: I3a3f9f42ec3c33915cc757fa9913cff0730174b7
Reviewed-on: https://chromium-review.googlesource.com/c/1257888
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598062}
[modify] https://crrev.com/151067a8940fe31bafbbd04d9bd34cb6b3effa97/chrome/browser/ui/webui/browsing_history_handler.cc
[modify] https://crrev.com/151067a8940fe31bafbbd04d9bd34cb6b3effa97/chrome/browser/ui/webui/certificate_viewer_webui.cc
[modify] https://crrev.com/151067a8940fe31bafbbd04d9bd34cb6b3effa97/chrome/browser/ui/webui/cookies_tree_model_util.cc
[modify] https://crrev.com/151067a8940fe31bafbbd04d9bd34cb6b3effa97/chrome/browser/ui/webui/flash_ui.cc
[modify] https://crrev.com/151067a8940fe31bafbbd04d9bd34cb6b3effa97/chrome/browser/ui/webui/foreign_session_handler.cc
[modify] https://crrev.com/151067a8940fe31bafbbd04d9bd34cb6b3effa97/chrome/browser/ui/webui/identity_internals_ui.cc
[modify] https://crrev.com/151067a8940fe31bafbbd04d9bd34cb6b3effa97/chrome/browser/ui/webui/invalidations_message_handler.cc
[modify] https://crrev.com/151067a8940fe31bafbbd04d9bd34cb6b3effa97/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc
[modify] https://crrev.com/151067a8940fe31bafbbd04d9bd34cb6b3effa97/chrome/browser/ui/webui/md_downloads/downloads_list_tracker.cc
[modify] https://crrev.com/151067a8940fe31bafbbd04d9bd34cb6b3effa97/chrome/browser/ui/webui/media/webrtc_logs_ui.cc
[modify] https://crrev.com/151067a8940fe31bafbbd04d9bd34cb6b3effa97/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
[modify] https://crrev.com/151067a8940fe31bafbbd04d9bd34cb6b3effa97/chrome/browser/ui/webui/omnibox/omnibox_page_handler.cc
[modify] https://crrev.com/151067a8940fe31bafbbd04d9bd34cb6b3effa97/chrome/browser/ui/webui/quota_internals/quota_internals_handler.cc
[modify] https://crrev.com/151067a8940fe31bafbbd04d9bd34cb6b3effa97/chrome/browser/ui/webui/quota_internals/quota_internals_proxy.cc
[modify] https://crrev.com/151067a8940fe31bafbbd04d9bd34cb6b3effa97/chrome/browser/ui/webui/settings/protocol_handlers_handler.cc
[modify] https://crrev.com/151067a8940fe31bafbbd04d9bd34cb6b3effa97/chrome/browser/ui/webui/settings/site_settings_handler.cc
[modify] https://crrev.com/151067a8940fe31bafbbd04d9bd34cb6b3effa97/chrome/browser/ui/webui/site_settings_helper.cc
[modify] https://crrev.com/151067a8940fe31bafbbd04d9bd34cb6b3effa97/chrome/browser/ui/webui/sync_file_system_internals/extension_statuses_handler.cc
[modify] https://crrev.com/151067a8940fe31bafbbd04d9bd34cb6b3effa97/chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.cc
[modify] https://crrev.com/151067a8940fe31bafbbd04d9bd34cb6b3effa97/chrome/browser/ui/webui/translate_internals/translate_internals_ui.cc
[modify] https://crrev.com/151067a8940fe31bafbbd04d9bd34cb6b3effa97/chrome/browser/ui/webui/version_ui.cc
Project Member

Comment 21 by bugdroid1@chromium.org, Oct 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042

commit a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042
Author: jdoerrie <jdoerrie@chromium.org>
Date: Wed Oct 10 09:10:37 2018

[clang-tidy] Apply modernize-use-auto in /extensions

This change applies clang-tidy's modernize-use-auto [1] in /extensions.
This change does not rewrite new and cast expressions.

Reproduction steps:
- run clang-tidy's modernize-use-auto
- run git cl format
- manually remove unused typedefs due to -Wunused-local-typedef error

[1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html

This CL was uploaded by git cl split.

R=lazyboy@chromium.org, palmer@chromium.org

Bug: 890902
Change-Id: I30bac79917a19d7628b517137130a2da228e6509
Reviewed-on: https://chromium-review.googlesource.com/c/1257845
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598262}
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/chrome/common/apps/platform_apps/media_galleries_permission.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/app_window/app_window.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/app_window/app_window_geometry_cache.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/app_window/app_window_registry.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/blob_holder.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/computed_hashes.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/content_hash_tree.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/content_verifier/content_hash.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/content_verifier/test_utils.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/content_verifier_io_data.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/declarative_user_script_manager.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/event_listener_map.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/event_router.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/extension_api_frame_id_map.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/extension_error.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/extension_function_dispatcher.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/extension_function_registry.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/extension_pref_value_map.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/extension_prefs.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/extension_registrar.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/extension_user_script_loader.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/guest_view/app_view/app_view_guest.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/guest_view/web_view/web_view_content_script_manager.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/guest_view/web_view/web_view_find_helper.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/image_loader.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/info_map.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/lazy_background_task_queue.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/management_policy.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/mock_external_provider.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/process_manager.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/process_map.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/quota_service.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/runtime_data.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/serial_extension_host_queue.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/state_store.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/updater/extension_downloader.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/updater/manifest_fetch_data.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/user_script_loader.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/value_store/testing_value_store.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/value_store/value_store_change.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/value_store/value_store_unittest.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/verified_contents.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/browser/warning_service.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/common/api/bluetooth/bluetooth_manifest_permission.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/common/api/sockets/sockets_manifest_permission.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/common/api/sockets/sockets_manifest_permission_unittest.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/common/event_filter.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/common/extension.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/common/extension_api.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/common/extension_icon_set.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/common/extension_l10n_util.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/common/extension_messages.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/common/extension_set.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/common/features/complex_feature.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/common/features/feature_provider.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/common/manifest_handler.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/common/manifest_handlers/automation.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/common/manifest_handlers/externally_connectable.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/common/manifest_handlers/requirements_info.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/common/message_bundle.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/common/permissions/permission_message_util.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/common/permissions/permission_set.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/common/permissions/permissions_info.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/common/url_pattern.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/common/url_pattern_set.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/common/user_script.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/renderer/dispatcher.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/renderer/extension_throttle_simulation_unittest.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/renderer/ipc_message_sender.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/renderer/module_system.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/renderer/request_sender.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/renderer/script_injection.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/renderer/script_injection_manager.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/renderer/user_script_set.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/renderer/user_script_set_manager.cc
[modify] https://crrev.com/a1e1598b6309e8a8094a3fbef99dfeb9c6e4e042/extensions/renderer/v8_schema_registry.cc
Project Member

Comment 22 by bugdroid1@chromium.org, Oct 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/183bbf9147bbe2a535470c511c9e1bb0402f2ef9

commit 183bbf9147bbe2a535470c511c9e1bb0402f2ef9
Author: jdoerrie <jdoerrie@chromium.org>
Date: Wed Oct 10 10:12:35 2018

[clang-tidy] Apply modernize-use-auto in /components/invalidation

This change applies clang-tidy's modernize-use-auto [1] in /components/invalidation.
This change does not rewrite new and cast expressions.

Reproduction steps:
- run clang-tidy's modernize-use-auto
- run git cl format
- manually remove unused typedefs due to -Wunused-local-typedef error

[1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html

This CL was uploaded by git cl split.

R=nyquist@chromium.org

Bug: 890902
Change-Id: I30a50970bba4454e8348035cee629c2b56ba914a
Reviewed-on: https://chromium-review.googlesource.com/c/1257922
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598273}
[modify] https://crrev.com/183bbf9147bbe2a535470c511c9e1bb0402f2ef9/components/invalidation/impl/deprecated_invalidator_registrar.cc
[modify] https://crrev.com/183bbf9147bbe2a535470c511c9e1bb0402f2ef9/components/invalidation/impl/fcm_invalidation_listener.cc
[modify] https://crrev.com/183bbf9147bbe2a535470c511c9e1bb0402f2ef9/components/invalidation/impl/fcm_invalidation_listener_unittest.cc
[modify] https://crrev.com/183bbf9147bbe2a535470c511c9e1bb0402f2ef9/components/invalidation/impl/invalidation_logger.cc
[modify] https://crrev.com/183bbf9147bbe2a535470c511c9e1bb0402f2ef9/components/invalidation/impl/invalidator_registrar.cc
[modify] https://crrev.com/183bbf9147bbe2a535470c511c9e1bb0402f2ef9/components/invalidation/impl/invalidator_storage.cc
[modify] https://crrev.com/183bbf9147bbe2a535470c511c9e1bb0402f2ef9/components/invalidation/impl/mock_ack_handler.cc
[modify] https://crrev.com/183bbf9147bbe2a535470c511c9e1bb0402f2ef9/components/invalidation/impl/object_id_invalidation_map_test_util.cc
[modify] https://crrev.com/183bbf9147bbe2a535470c511c9e1bb0402f2ef9/components/invalidation/impl/registration_manager.cc
[modify] https://crrev.com/183bbf9147bbe2a535470c511c9e1bb0402f2ef9/components/invalidation/impl/registration_manager_unittest.cc
[modify] https://crrev.com/183bbf9147bbe2a535470c511c9e1bb0402f2ef9/components/invalidation/impl/single_object_invalidation_set_unittest.cc
[modify] https://crrev.com/183bbf9147bbe2a535470c511c9e1bb0402f2ef9/components/invalidation/impl/sync_invalidation_listener.cc
[modify] https://crrev.com/183bbf9147bbe2a535470c511c9e1bb0402f2ef9/components/invalidation/impl/sync_invalidation_listener_unittest.cc
[modify] https://crrev.com/183bbf9147bbe2a535470c511c9e1bb0402f2ef9/components/invalidation/impl/unacked_invalidation_set.cc
[modify] https://crrev.com/183bbf9147bbe2a535470c511c9e1bb0402f2ef9/components/invalidation/impl/unacked_invalidation_set_test_util.cc
[modify] https://crrev.com/183bbf9147bbe2a535470c511c9e1bb0402f2ef9/components/invalidation/public/object_id_invalidation_map.cc
[modify] https://crrev.com/183bbf9147bbe2a535470c511c9e1bb0402f2ef9/components/invalidation/public/single_object_invalidation_set.cc
[modify] https://crrev.com/183bbf9147bbe2a535470c511c9e1bb0402f2ef9/components/invalidation/public/topic_invalidation_map.cc
Project Member

Comment 23 by bugdroid1@chromium.org, Oct 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2

commit dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2
Author: jdoerrie <jdoerrie@chromium.org>
Date: Wed Oct 10 12:04:32 2018

[clang-tidy] Apply modernize-use-auto in /ui

This change applies clang-tidy's modernize-use-auto [1] in /ui.
This change does not rewrite new and cast expressions.

Reproduction steps:
- run clang-tidy's modernize-use-auto
- run git cl format
- manually remove unused typedefs due to -Wunused-local-typedef error

[1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html

This CL was uploaded by git cl split.

R=sadrul@chromium.org

Bug: 890902
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I0eb0b9aa6d22bb039c9c2510dd1ad4f814f66aa7
Reviewed-on: https://chromium-review.googlesource.com/c/1257854
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598284}
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/aura/mus/os_exchange_data_provider_mus.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/aura/test/test_windows.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/aura/window.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/base/accelerators/accelerator_manager.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/base/class_property.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/base/clipboard/clipboard.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/base/clipboard/clipboard_aurax11.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/base/dragdrop/os_exchange_data_provider_aurax11.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/base/models/list_selection_model.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/base/models/simple_menu_model.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/base/resource/resource_bundle_unittest.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/base/template_expressions.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/base/view_prop.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/base/x/selection_owner.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/base/x/selection_requestor.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/base/x/selection_utils.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/base/x/x11_menu_list.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/compositor/layer.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/compositor/layer_animation_observer.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/compositor/layer_animator.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/compositor/layer_animator_collection.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/compositor/test/in_process_context_factory.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/compositor/test/test_layers.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/display/display_change_notifier.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/display/manager/display_manager.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/display/test/display_manager_test_api.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/events/devices/x11/device_data_manager_x11.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/events/devices/x11/touch_factory_x11.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/events/event_rewriter_unittest.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/events/event_source.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/events/event_target.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/events/event_utils.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/events/gestures/gesture_recognizer_impl.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/events/keycodes/keysym_to_unicode.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/gfx/animation/animation_container.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/gfx/color_analysis.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/gfx/font_list_impl.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/gfx/font_render_params_linux.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/gfx/image/image.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/gfx/image/image_family.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/gfx/image/image_generic.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/gfx/image/image_skia.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/gfx/render_text_harfbuzz.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/gfx/sequential_id_generator.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/gl/gl_share_group.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/gl/gpu_timing_fake.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/latency/latency_info.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/message_center/message_center_impl.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/message_center/message_center_impl_unittest.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/message_center/message_center_stats_collector.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/message_center/notification_list_unittest.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/message_center/popup_timers_controller.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/message_center/views/notification_view_unittest.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/views/controls/button/radio_button.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/views/controls/menu/menu_controller.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/views/controls/menu/menu_runner_impl.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/views/controls/native/native_view_host.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/views/controls/textfield/textfield_model.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/views/corewm/tooltip_controller_unittest.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/views/examples/menu_example.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/views/layout/box_layout.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/views/view.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/views/widget/desktop_aura/desktop_capture_client.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11_unittest.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/views/widget/desktop_aura/desktop_native_cursor_manager.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/views/widget/desktop_aura/desktop_screen_x11.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/views/widget/native_widget_aura.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/views/widget/window_reorderer.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/views/widget/window_reorderer_unittest.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/views/window/custom_frame_view.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/wm/core/base_focus_rules.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/wm/core/transient_window_manager.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/wm/core/transient_window_stacking_client.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/wm/core/window_animations.cc
[modify] https://crrev.com/dcef4b15ee3ce9f813c60c4b4327a40bea8f45e2/ui/wm/core/window_animations_unittest.cc
Project Member

Comment 24 by bugdroid1@chromium.org, Oct 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49294223a3f2a3016d355a2eff5c2f1f5f806553

commit 49294223a3f2a3016d355a2eff5c2f1f5f806553
Author: jdoerrie <jdoerrie@chromium.org>
Date: Thu Oct 18 00:27:05 2018

[clang-tidy] Apply modernize-use-auto in /media/cast

This change applies clang-tidy's modernize-use-auto [1] in /media/cast.
This change does not rewrite new and cast expressions.

Reproduction steps:
- run clang-tidy's modernize-use-auto
- run git cl format
- manually remove unused typedefs due to -Wunused-local-typedef error

[1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html

This CL was uploaded by git cl split.

R=miu@chromium.org

Bug: 890902
Change-Id: I1f11e8871d5dab6298edd8829b852cd1907ee2b3
Reviewed-on: https://chromium-review.googlesource.com/c/1257904
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600617}
[modify] https://crrev.com/49294223a3f2a3016d355a2eff5c2f1f5f806553/media/cast/logging/encoding_event_subscriber.cc
[modify] https://crrev.com/49294223a3f2a3016d355a2eff5c2f1f5f806553/media/cast/logging/encoding_event_subscriber_unittest.cc
[modify] https://crrev.com/49294223a3f2a3016d355a2eff5c2f1f5f806553/media/cast/logging/log_deserializer.cc
[modify] https://crrev.com/49294223a3f2a3016d355a2eff5c2f1f5f806553/media/cast/logging/log_serializer.cc
[modify] https://crrev.com/49294223a3f2a3016d355a2eff5c2f1f5f806553/media/cast/logging/raw_event_subscriber_bundle.cc
[modify] https://crrev.com/49294223a3f2a3016d355a2eff5c2f1f5f806553/media/cast/logging/receiver_time_offset_estimator_impl.cc
[modify] https://crrev.com/49294223a3f2a3016d355a2eff5c2f1f5f806553/media/cast/logging/serialize_deserialize_test.cc
[modify] https://crrev.com/49294223a3f2a3016d355a2eff5c2f1f5f806553/media/cast/logging/stats_event_subscriber.cc
[modify] https://crrev.com/49294223a3f2a3016d355a2eff5c2f1f5f806553/media/cast/logging/stats_event_subscriber_unittest.cc
[modify] https://crrev.com/49294223a3f2a3016d355a2eff5c2f1f5f806553/media/cast/net/pacing/paced_sender.cc
[modify] https://crrev.com/49294223a3f2a3016d355a2eff5c2f1f5f806553/media/cast/net/rtcp/rtcp_builder.cc
[modify] https://crrev.com/49294223a3f2a3016d355a2eff5c2f1f5f806553/media/cast/net/rtcp/rtcp_utility_unittest.cc
[modify] https://crrev.com/49294223a3f2a3016d355a2eff5c2f1f5f806553/media/cast/net/rtcp/sender_rtcp_session.cc
[modify] https://crrev.com/49294223a3f2a3016d355a2eff5c2f1f5f806553/media/cast/net/rtp/cast_message_builder_unittest.cc
[modify] https://crrev.com/49294223a3f2a3016d355a2eff5c2f1f5f806553/media/cast/net/rtp/frame_buffer.cc
[modify] https://crrev.com/49294223a3f2a3016d355a2eff5c2f1f5f806553/media/cast/net/rtp/rtp_sender.cc
Project Member

Comment 25 by bugdroid1@chromium.org, Oct 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac0629efba3e9f329885a255d8b494d7ba9117f9

commit ac0629efba3e9f329885a255d8b494d7ba9117f9
Author: jdoerrie <jdoerrie@chromium.org>
Date: Fri Oct 19 14:51:48 2018

[clang-tidy] Apply modernize-use-auto in /components/policy

This change applies clang-tidy's modernize-use-auto [1] in /components/policy.
This change does not rewrite new and cast expressions.

Reproduction steps:
- run clang-tidy's modernize-use-auto
- run git cl format
- manually remove unused typedefs due to -Wunused-local-typedef error

[1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html

This CL was uploaded by git cl split.

R=pmarko@chromium.org

Bug: 890902
Change-Id: I07dd9ef1d1e8e0cadbd622010b0f2a2b184e2b89
Reviewed-on: https://chromium-review.googlesource.com/c/1257848
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601146}
[modify] https://crrev.com/ac0629efba3e9f329885a255d8b494d7ba9117f9/components/policy/core/browser/configuration_policy_handler_list.cc
[modify] https://crrev.com/ac0629efba3e9f329885a255d8b494d7ba9117f9/components/policy/core/browser/policy_error_map.cc
[modify] https://crrev.com/ac0629efba3e9f329885a255d8b494d7ba9117f9/components/policy/core/browser/url_blacklist_manager.cc
[modify] https://crrev.com/ac0629efba3e9f329885a255d8b494d7ba9117f9/components/policy/core/common/cloud/cloud_policy_client_unittest.cc
[modify] https://crrev.com/ac0629efba3e9f329885a255d8b494d7ba9117f9/components/policy/core/common/cloud/cloud_policy_service.cc
[modify] https://crrev.com/ac0629efba3e9f329885a255d8b494d7ba9117f9/components/policy/core/common/cloud/component_cloud_policy_store.cc
[modify] https://crrev.com/ac0629efba3e9f329885a255d8b494d7ba9117f9/components/policy/core/common/cloud/device_management_service.cc
[modify] https://crrev.com/ac0629efba3e9f329885a255d8b494d7ba9117f9/components/policy/core/common/cloud/external_policy_data_fetcher.cc
[modify] https://crrev.com/ac0629efba3e9f329885a255d8b494d7ba9117f9/components/policy/core/common/cloud/external_policy_data_fetcher_unittest.cc
[modify] https://crrev.com/ac0629efba3e9f329885a255d8b494d7ba9117f9/components/policy/core/common/cloud/mock_device_management_service.cc
[modify] https://crrev.com/ac0629efba3e9f329885a255d8b494d7ba9117f9/components/policy/core/common/config_dir_policy_loader.cc
[modify] https://crrev.com/ac0629efba3e9f329885a255d8b494d7ba9117f9/components/policy/core/common/policy_bundle.cc
[modify] https://crrev.com/ac0629efba3e9f329885a255d8b494d7ba9117f9/components/policy/core/common/policy_map.cc
[modify] https://crrev.com/ac0629efba3e9f329885a255d8b494d7ba9117f9/components/policy/core/common/policy_service.cc
[modify] https://crrev.com/ac0629efba3e9f329885a255d8b494d7ba9117f9/components/policy/core/common/policy_test_utils.cc
[modify] https://crrev.com/ac0629efba3e9f329885a255d8b494d7ba9117f9/components/policy/core/common/registry_dict.cc
[modify] https://crrev.com/ac0629efba3e9f329885a255d8b494d7ba9117f9/components/policy/core/common/registry_dict_unittest.cc
[modify] https://crrev.com/ac0629efba3e9f329885a255d8b494d7ba9117f9/components/policy/core/common/schema.cc
[modify] https://crrev.com/ac0629efba3e9f329885a255d8b494d7ba9117f9/components/policy/core/common/schema_registry.cc
►

Sign in to add a comment