"Enable debugging features" fails after root password prompt |
||||||||
Issue descriptionChrome Version: Devloper channel 71.0.3558.0 Chrome OS Version: R71-11097.0.0 Chrome OS Platform: Google_Grunt Firmware 11031.8.0 Please specify Cr-* of the system to which this bug/feature applies (add the label below). I did a powerwash of the device and put it onto the dev channel. This was successful, so I put it into developer mode. However, when it rebooted into developer mode and showed me the welcome screen along with "Enable debugging features", I was unable to enable those debugging features. It got to the point where it prompted me for a root password and then after I supplied one, it said "Something went wrong. Debugging features were not completely enabled on this Chrome device" I confirmed that the root password was not set and SSH was not enabled.
,
Oct 2
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/54583b50c9a6f971a677a74a76fc32369f4b7a1c commit 54583b50c9a6f971a677a74a76fc32369f4b7a1c Author: Mike Frysinger <vapier@chromium.org> Date: Tue Oct 02 12:19:30 2018 debugd: configure ssh access in the root mount namespace Since debugd always runs with / read-only (even if the underlying filesystem is not), make sure we switch to the root mount namespace before making filesystem changes to enable ssh access. BUG= chromium:872088 , chromium:890898 TEST=enabling debug features in OOBE works Change-Id: Ic6be83fc3594b3f8c2f303d916ecd4e6f802d264 Reviewed-on: https://chromium-review.googlesource.com/1253002 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Daniel Kurtz <djkurtz@chromium.org> [modify] https://crrev.com/54583b50c9a6f971a677a74a76fc32369f4b7a1c/debugd/src/helpers/dev_features_ssh.cc
,
Oct 2
the CLs here are quite small and only impact the OOBE developer flow. the code isn't called by anything else, so impact/risk should be quite low.
,
Oct 2
This does not meet the criteria for merging to stable channel. Merge to M69 is not approved. Reach out to geohus@ for inclusion in M70.
,
Oct 2
,
Oct 2
This bug requires manual review: We are only 13 days from stable. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 2
Does this need to be on M70 for Grunt (or are other devices impacted by this)? My understanding is it is on M71 these days.
,
Oct 2
Chatted with offline with djkurtz, this does impact other devices. Approved for M70.
,
Oct 2
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/13eb097f4e40b55fadb9144c08bb0a3186920121 commit 13eb097f4e40b55fadb9144c08bb0a3186920121 Author: Mike Frysinger <vapier@chromium.org> Date: Tue Oct 02 17:23:00 2018 debugd: configure ssh access in the root mount namespace Since debugd always runs with / read-only (even if the underlying filesystem is not), make sure we switch to the root mount namespace before making filesystem changes to enable ssh access. BUG= chromium:872088 , chromium:890898 TEST=enabling debug features in OOBE works Change-Id: Ic6be83fc3594b3f8c2f303d916ecd4e6f802d264 (cherry picked from commit 54583b50c9a6f971a677a74a76fc32369f4b7a1c) Reviewed-on: https://chromium-review.googlesource.com/1257307 Reviewed-by: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/13eb097f4e40b55fadb9144c08bb0a3186920121/debugd/src/helpers/dev_features_ssh.cc
,
Oct 6
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/35c43b46619ee96565825ba6b71e3f1ee7447e01 commit 35c43b46619ee96565825ba6b71e3f1ee7447e01 Author: Mike Frysinger <vapier@chromium.org> Date: Sat Oct 06 06:13:31 2018 debugd: configure the user password in the root mount namespace Since debugd runs w/out mounting the stateful partition at all, make sure we switch to the root mount namespace before checking the dev mode password. BUG= chromium:872088 , chromium:890898 TEST=enabling debug features in OOBE works Change-Id: I5e2bf940839d25005b37deff78e282590ce34a0d Reviewed-on: https://chromium-review.googlesource.com/1255385 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Daniel Kurtz <djkurtz@chromium.org> [modify] https://crrev.com/35c43b46619ee96565825ba6b71e3f1ee7447e01/debugd/src/helpers/dev_features_password.cc
,
Oct 6
,
Oct 6
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/a3a4709947f92d278edc8002c3ad6fc1d685659f commit a3a4709947f92d278edc8002c3ad6fc1d685659f Author: Mike Frysinger <vapier@chromium.org> Date: Sat Oct 06 06:25:30 2018 debugd: configure the user password in the root mount namespace Since debugd runs w/out mounting the stateful partition at all, make sure we switch to the root mount namespace before checking the dev mode password. BUG= chromium:872088 , chromium:890898 TEST=enabling debug features in OOBE works Change-Id: I5e2bf940839d25005b37deff78e282590ce34a0d (cherry picked from commit 35c43b46619ee96565825ba6b71e3f1ee7447e01) Reviewed-on: https://chromium-review.googlesource.com/c/1266975 Reviewed-by: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/a3a4709947f92d278edc8002c3ad6fc1d685659f/debugd/src/helpers/dev_features_password.cc |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by vapier@chromium.org
, Oct 1Components: UI>Shell>OOBE
Labels: -Restrict-View-Google
Owner: vapier@chromium.org
Status: Started (was: Unconfirmed)