New issue
Advanced search Search tips

Issue 890894 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility

Blocked on:
issue 889232


Participants' hotlists:
Launcher-A11y


Sign in to add a comment

Cannot navigate to overflow button on shelf using keyboard shortcut

Project Member Reported by kjbooker@chromium.org, Oct 1

Issue description

Chrome Version: 70.0.3538.16 (official build) dev (64-bit)
Firmware version:  Google_Eve.9584.160.0

When there is an ellipsis on the shelf (bottom, right, or left) to select more apps, the user cannot navigate to the ellipsis using keyboard shortcuts.

What is the expected result?
Navigate to additional apps through keyboard shortcuts.

What happens instead?
Skips the ellipsis with keyboard shortcuts.



 
Cc: afakhry@chromium.org manucornet@chromium.org
How is the docked magnifier affecting things?
Summary: Cannot navigate to ellipsis on shelf using keyboard shortcut (was: Cannot navigate to ellipsis on shelf using keyboard shortcut when doc magnifier enabled )
Google Chrome	71.0.3558.0 (Official Build) dev (64-bit)
Firmware Version	Google_Caroline.7820.384.0

I'm changing the title of this bug to make it simpler. This reproduces both with and without either magnifier on, so I'll remove the magnifier label. 

Repros in M71. 
Cc: -afakhry@chromium.org
Removing afakhry@ since this is not Magnifier specific. 
Cc: newcomer@chromium.org
Owner: manucornet@chromium.org
Labels: a11y-Shelf
Labels: M-74
Status: Assigned (was: Available)
Summary: Cannot navigate to overflow button on shelf using keyboard shortcut (was: Cannot navigate to ellipsis on shelf using keyboard shortcut )

Comment 11 by newcomer@chromium.org, Jan 16 (6 days ago)

Blockedon: 889232
We may need specific handling to make focus move from the overflow button to the overflow window. I just enabled 'arrow key focus traversal' in the shelf, which is required for what I just mentioned.

You can see progress on  issue 889232  (CL should land today).

Comment 12 by manucornet@chromium.org, Jan 18 (4 days ago)

Status: Started (was: Assigned)
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 19 (3 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65594253ffebb0fd364da090856b6f195895eab8

commit 65594253ffebb0fd364da090856b6f195895eab8
Author: Manu Cornet <manucornet@chromium.org>
Date: Sat Jan 19 11:12:13 2019

CrOS shelf: Simplify focus cycling code and add overflow button

Bug:  890894 , 854313
Change-Id: I734714f3e6457852d038a00c481cc5425b8bf89c
Reviewed-on: https://chromium-review.googlesource.com/c/1420920
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Auto-Submit: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624462}
[modify] https://crrev.com/65594253ffebb0fd364da090856b6f195895eab8/ash/shelf/shelf_view.cc
[modify] https://crrev.com/65594253ffebb0fd364da090856b6f195895eab8/ash/shelf/shelf_view.h
[modify] https://crrev.com/65594253ffebb0fd364da090856b6f195895eab8/ash/shelf/shelf_view_unittest.cc

Comment 14 by manucornet@chromium.org, Jan 19 (3 days ago)

Status: Fixed (was: Started)

Sign in to add a comment