New issue
Advanced search Search tips

Issue 890891 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocked on:
issue 891061



Sign in to add a comment

supersize archive (ChromeModernPublic.apk) failing on chromium.perf/Android arm64 Builder Perf

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Oct 1

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of skyostil@google.com

supersize archive (ChromeModernPublic.apk) failing on chromium.perf/Android arm64 Builder Perf

Builders failed on: 
- Android arm64 Builder Perf: 
  https://ci.chromium.org/buildbot/chromium.perf/Android%20arm64%20Builder%20Perf


 
Owner: estevenson@chromium.org
Status: Assigned (was: Available)
32 bit builder looks unaffected: https://ci.chromium.org/buildbot/chromium.perf/Android%20Builder%20Perf/?limit=200
Have archive running on a 64 bit build locally and it's running super slow and making my desktop become unresponsive. 

Not sure yet if there's an actual bug or if archive just isn't handling the load well (in which case we'd probably just have to disable supersize for 64 bit builds until we figure out a solution). 
Looks like we're creating ~157 million symbols (vs ~2 million in 32 bit). Noticed that I'm seeing a large number of symbols that look like "OUTLINED_FUNCTION_0" with a whole bunch of object paths which makes us create way too many aliases.

Looking at the git log from where this started failing this makes sense: https://chromium-review.googlesource.com/c/chromium/src/+/1236174

Going to disable supersize on 64 bit for now.
Blockedon: 891061
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/048d3702cb3bbf798051d11b28c37451dc85f3c2

commit 048d3702cb3bbf798051d11b28c37451dc85f3c2
Author: Eric Stevenson <estevenson@chromium.org>
Date: Tue Oct 02 00:30:15 2018

Disable Supersize on 64 bit bots.

Currently broken since outlining support hasn't yet been added to
Supersize.

Bug:  890891 
Change-Id: Ib15e7da2382f19b338ea9230c2ae465e5d1fbdae
Reviewed-on: https://chromium-review.googlesource.com/1255550
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Auto-Submit: Eric Stevenson <estevenson@chromium.org>

[modify] https://crrev.com/048d3702cb3bbf798051d11b28c37451dc85f3c2/scripts/slave/README.recipes.md
[modify] https://crrev.com/048d3702cb3bbf798051d11b28c37451dc85f3c2/scripts/slave/recipes/android/builder.py
[modify] https://crrev.com/048d3702cb3bbf798051d11b28c37451dc85f3c2/scripts/slave/recipes/android/builder.expected/full_chromium_perf_Android_arm64_Builder_Perf.json

Status: Fixed (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/193d7c53fbea604b92ebdcf19562e95400f5a7e3

commit 193d7c53fbea604b92ebdcf19562e95400f5a7e3
Author: Samuel Huang <huangs@chromium.org>
Date: Tue Nov 06 18:51:39 2018

[Build Bots] Re-enable SuperSize for arm64 build bots.

This CL essentialy reverts
  https://chromium-review.googlesource.com/c/chromium/tools/build/+/1255550/ ,
and reruns './recipes.py test train'.

Previously SuperSize didn't support outlined symbols for LLD (891061),
thereby causing arm64 (no ThinLTO) to run 10x as long and time out
(890891). Now that outlined symbol support has been added to SuperSize,
we can re-enable running it for arm64 build bots.

Bug:  891061 , 890891 
Change-Id: I1e83506576c07d14fab51b2ed9dc1a606aec327f
Reviewed-on: https://chromium-review.googlesource.com/c/1318290
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Auto-Submit: Samuel Huang <huangs@chromium.org>

[modify] https://crrev.com/193d7c53fbea604b92ebdcf19562e95400f5a7e3/scripts/slave/README.recipes.md
[modify] https://crrev.com/193d7c53fbea604b92ebdcf19562e95400f5a7e3/scripts/slave/recipes/android/builder.py
[modify] https://crrev.com/193d7c53fbea604b92ebdcf19562e95400f5a7e3/scripts/slave/recipes/android/builder.expected/full_chromium_perf_Android_arm64_Builder_Perf.json

Sign in to add a comment