Issue metadata
Sign in to add a comment
|
Switching from Media Remoting to Mirroring from the dialog overflow menu is unsuccessful and causes freeze. |
||||||||||||||||||||||
Issue descriptionChrome Version: 71.0.3554.2 OS: Win, CrOS - Doesn't occur on Mac MR: 7118.924.0.0 (also on previous public release) What steps will reproduce the problem? (1) Right click on the Cast icon in the toolbar and make sure "Optimize fullscreen videos" is selected. (2) Cast a vimeo.com video and enter fullscreen mode. This will trigger Media Remoting. (3) Once Remoting has started, right click the Cast icon in the toolbar and unselect "Optimize fullscreen videos". What is the expected result? Immediately the Remoting session should end and switch to mirroring. What happens instead? Nothing happens on the sender, after about 5 seconds, the content freezes on the receiver. Internal feedback report ID: 85696796297 Note that this is a bit different from bug 889522. In this bug, there is a freeze on the receiver, and this one also does not repro on Mac.
,
Oct 2
,
Oct 12
I wasn't able to reproduce this on Linux or Windows (latest canary). Was able to switch between remoting and mirroring multiple times using the context menu. David, does this still repro on CrOS?
,
Oct 15
I also confirmed on Windows that it doesn't repro on today's canary, though it still does on today's dev. I think it's reasonable to wait until the next CrOS dev push to verify it's fixed there as well (after 10/18).
,
Oct 15
Marking fixed. Plan to verify SGTM.
,
Oct 22
On today's canary it is reproing again. Chrome 72.0.3588.1 (Win 8) It is also reproing on latest CrOS dev today 71.0.3578.8
,
Oct 22
I was actually on Win 10 when I repro'd it today (correction for comment #6).
,
Oct 23
dbbrooks@, can you please show this to someone in person if you have a reliable repro case? Windows will likely be easier to debug.
,
Oct 24
OK sure. It's also occurring on Mac now as well.
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2ca1bc1f6cf9a6ecdcb38c9d682d23fbb8cb2e9 commit c2ca1bc1f6cf9a6ecdcb38c9d682d23fbb8cb2e9 Author: Takumi Fujimoto <takumif@chromium.org> Date: Thu Oct 25 02:40:05 2018 Set cancel callback in CastRemotingConnector only if the dialog is open Set a callback to close the remoting permission dialog only if the dialog was actually opened. This prevents an unintended early exit from StopRemoting() that results in remoting not actually getting stopped. Bug: 890856 ,898616 Change-Id: I487559fafe921fcc42205b6aa2b7ca887d517559 Reviewed-on: https://chromium-review.googlesource.com/c/1298189 Reviewed-by: Yuri Wiitala <miu@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#602586} [modify] https://crrev.com/c2ca1bc1f6cf9a6ecdcb38c9d682d23fbb8cb2e9/chrome/browser/media/cast_remoting_connector.cc
,
Oct 26
As per comment #0, it seems to be related to cast device which is not available at TE-End. Hence, requesting Dev (dbbrooks@chromium.org) to look into it and help in verifying the issue. Thanks..!
,
Oct 26
I just verified this is fixed in canary 72.0.3592.0 on both Mac and Windows. Looks good.
,
Oct 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/edc9ab7dbfc6606b8925e04943d349b770c2295a commit edc9ab7dbfc6606b8925e04943d349b770c2295a Author: Takumi Fujimoto <takumif@chromium.org> Date: Fri Oct 26 20:33:28 2018 Set cancel callback in CastRemotingConnector only if the dialog is open Set a callback to close the remoting permission dialog only if the dialog was actually opened. This prevents an unintended early exit from StopRemoting() that results in remoting not actually getting stopped. Bug: 890856 ,898616 Change-Id: I487559fafe921fcc42205b6aa2b7ca887d517559 Reviewed-on: https://chromium-review.googlesource.com/c/1298189 Reviewed-by: Yuri Wiitala <miu@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602586}(cherry picked from commit c2ca1bc1f6cf9a6ecdcb38c9d682d23fbb8cb2e9) Reviewed-on: https://chromium-review.googlesource.com/c/1302956 Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#352} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/edc9ab7dbfc6606b8925e04943d349b770c2295a/chrome/browser/media/cast_remoting_connector.cc
,
Oct 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/edc9ab7dbfc6606b8925e04943d349b770c2295a Commit: edc9ab7dbfc6606b8925e04943d349b770c2295a Author: takumif@chromium.org Commiter: takumif@chromium.org Date: 2018-10-26 20:33:28 +0000 UTC Set cancel callback in CastRemotingConnector only if the dialog is open Set a callback to close the remoting permission dialog only if the dialog was actually opened. This prevents an unintended early exit from StopRemoting() that results in remoting not actually getting stopped. Bug: 890856 ,898616 Change-Id: I487559fafe921fcc42205b6aa2b7ca887d517559 Reviewed-on: https://chromium-review.googlesource.com/c/1298189 Reviewed-by: Yuri Wiitala <miu@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602586}(cherry picked from commit c2ca1bc1f6cf9a6ecdcb38c9d682d23fbb8cb2e9) Reviewed-on: https://chromium-review.googlesource.com/c/1302956 Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#352} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mfo...@chromium.org
, Oct 2