New issue
Advanced search Search tips

Issue 890850 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Audio-related browser_tests failing on Linux Tests (dbg)(1)(32)

Project Member Reported by fdoray@chromium.org, Oct 1

Issue description

Bot: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29%2832%29
First failing build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29%2832%29/53197

Sample failures:

[ RUN      ] MediaEngagementAutoplayBrowserTest.UsePreloadedData_Denied/1
  Xlib:  extension "RANDR" missing on display ":99".
  [21946:21946:1001/012418.567612:ERROR:browser_dm_token_storage_linux.cc(93)] Error: /etc/machine-id contains 0 characters (32 were expected).
  [21946:22022:1001/012418.792028:ERROR:bus.cc(396)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
  [21946:21946:1001/012418.834531:WARNING:password_store_factory.cc(262)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
  [21946:21946:1001/012419.723297:ERROR:x11_input_method_context_impl_gtk.cc(144)] Not implemented reached in virtual void libgtkui::X11InputMethodContextImplGtk::SetSurroundingText(const base::string16 &, const gfx::Range &)
  [21946:21946:1001/012420.415175:WARNING:gaia_auth_fetcher.cc(858)] Could not reach Google Accounts servers: errno -11
  [21946:21946:1001/012420.793418:WARNING:message_loop_task_runner.cc(26)] Requesting super-long task delay period of 99999999 seconds from here: SchedulePerformStateTransitions@../../chrome/browser/resource_coordinator/tab_manager.cc:955
  [21946:21964:1001/012422.236258:WARNING:embedded_test_server.cc(239)] Request not handled. Returning 404: /favicon.ico
  [21946:21946:1001/012422.314996:WARNING:gaia_auth_fetcher.cc(858)] Could not reach Google Accounts servers: errno -11
  [22021:22097:1001/012422.608044:WARNING:http_cache_transaction.cc(2975)] Failed to revalidate partial entry
  [22201:22201:1001/012422.687965:WARNING:audio_sandbox_hook_linux.cc(102)] dlopen: failed to open libpulse.so.0 with error: libpulse.so.0: cannot open shared object file: No such file or directory
  [22201:22201:1001/012422.689147:WARNING:audio_sandbox_hook_linux.cc(102)] dlopen: failed to open libpulsecommon-11.1.so with error: libpulsecommon-11.1.so: cannot open shared object file: No such file or directory
  [1:5:1001/012423.367651:ERROR:render_media_log.cc(30)] MediaEvent: MEDIA_ERROR_LOG_ENTRY {"error":"audio render error"}
  [1:1:1001/012423.369108:ERROR:render_media_log.cc(30)] MediaEvent: PIPELINE_ERROR AUDIO_RENDERER_ERROR
  [1:5:1001/012423.411713:ERROR:render_media_log.cc(30)] MediaEvent: MEDIA_ERROR_LOG_ENTRY {"error":"audio render error"}
  [1:1:1001/012423.414814:ERROR:render_media_log.cc(30)] MediaEvent: PIPELINE_ERROR AUDIO_RENDERER_ERROR
  [1:5:1001/012423.771398:ERROR:render_media_log.cc(30)] MediaEvent: MEDIA_ERROR_LOG_ENTRY {"error":"audio render error"}
  [1:1:1001/012423.783984:ERROR:render_media_log.cc(30)] MediaEvent: PIPELINE_ERROR AUDIO_RENDERER_ERROR
  ../../chrome/browser/media/media_engagement_autoplay_browsertest.cc:141: Failure
  Expected equality of these values:
    kAllowedTitle
      Which is: Allowed
    WaitAndGetTitle()
      Which is: Denied
  Stack trace:
  #0 0x00000b4101b9 StackTraceGetter::CurrentStackTrace()
  #1 0x00000b430b64 testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
  #2 0x00000b42ffbe testing::internal::AssertHelper::operator=()
  #3 0x000009078147 MediaEngagementAutoplayBrowserTest::ExpectAutoplayAllowed()
  #4 0x000009072a56 MediaEngagementAutoplayBrowserTest::ExpectAutoplayAllowedIfEnabled()
  #5 0x000009071d15 MediaEngagementAutoplayBrowserTest_UsePreloadedData_Denied_Test::RunTestOnMainThread()
  #6 0x000009071e5b MediaEngagementAutoplayBrowserTest_UsePreloadedData_Denied_Test::RunTestOnMainThread()
  #7 0x00000ed1bc6a content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()

------

[ RUN      ] CastStreamingApiTest.StopNoStart
  Xlib:  extension "RANDR" missing on display ":99".
  [19539:19539:1001/011437.887817:ERROR:browser_dm_token_storage_linux.cc(93)] Error: /etc/machine-id contains 0 characters (32 were expected).
  [19539:19803:1001/011438.253292:ERROR:bus.cc(396)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
  [19539:19539:1001/011438.323141:WARNING:password_store_factory.cc(262)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
  [19539:19539:1001/011439.625612:ERROR:x11_input_method_context_impl_gtk.cc(144)] Not implemented reached in virtual void libgtkui::X11InputMethodContextImplGtk::SetSurroundingText(const base::string16 &, const gfx::Range &)
  [19539:19539:1001/011440.059060:WARNING:gaia_auth_fetcher.cc(858)] Could not reach Google Accounts servers: errno -11
  [19539:19539:1001/011440.965856:WARNING:gaia_auth_fetcher.cc(858)] Could not reach Google Accounts servers: errno -11
  [19539:19539:1001/011441.068560:INFO:CONSOLE(13)] "[TEST] stopNoStart", source: chrome-extension://ddchlicdkolnonkihahngkmmmjnjlkkf/stop_no_start.js (13)
  [19957:19957:1001/011442.120006:WARNING:audio_sandbox_hook_linux.cc(102)] dlopen: failed to open libpulse.so.0 with error: libpulse.so.0: cannot open shared object file: No such file or directory
  [19957:19957:1001/011442.120611:WARNING:audio_sandbox_hook_linux.cc(102)] dlopen: failed to open libpulsecommon-11.1.so with error: libpulsecommon-11.1.so: cannot open shared object file: No such file or directory
  [19539:19539:1001/011442.196867:INFO:CONSOLE(0)] "[FAIL] stopNoStart: lastError.message == Could not start audio source
  Error
      at extensions::test:255:18
      at extensions::test:306:20
      at extensions::tabCapture:59:30
      at extensions::tabCapture:13:17
      at runCallbackWithLastError (extensions::tabCapture:12:17)
      at onError (extensions::tabCapture:55:13)", source: chrome-extension://ddchlicdkolnonkihahngkmmmjnjlkkf/stop_no_start.html (0)
  [19539:19539:1001/011442.203433:INFO:CONSOLE(138)] "Uncaught chrome.test.failure", source: extensions::test (138)
  ../../chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc:77: Failure
  Value of: RunExtensionSubtest("cast_streaming", "stop_no_start.html")
    Actual: false
  Expected: true
  Failed 1 of 1 tests
  Stack trace:
  #0 0x00000b4101b9 StackTraceGetter::CurrentStackTrace()
  #1 0x00000b430b64 testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
  #2 0x00000b42ffbe testing::internal::AssertHelper::operator=()
  #3 0x00000a310689 extensions::CastStreamingApiTest_StopNoStart_Test::RunTestOnMainThread()
  #4 0x00000a31074f extensions::CastStreamingApiTest_StopNoStart_Test::RunTestOnMainThread()
  #5 0x00000ed1bc6a content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
  #6 0x000008ad7797 _ZN4base8internal13FunctorTraitsIM25RenderViewContextMenuBaseFvvEvE6InvokeIS4_P21RenderViewContextMenuJEEEvT_OT0_DpOT1_
  #7 0x000008ad76d8 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIM25RenderViewContextMenuBaseFvvEJP21RenderViewContextMenuEEEvOT_DpOT0_
  #8 0x00000ed1eed7 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLj0EEEEvOT_OT0_NSF_16integer_sequenceIjJXspT1_EEEE
  #9 0x00000ed1edda _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
  #10 0x000008ac7d11 _ZNKR4base17RepeatingCallbackIFvvEE3RunEv
  #11 0x00000dac5ae4 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
  #12 0x00000dac32ed ChromeBrowserMainParts::PreMainMessageLoopRun()
  #13 0x0000ed275815 content::BrowserMainLoop::PreMainMessageLoopRun()

------

[ RUN      ] UnifiedAutoplayBrowserTest.OpenSameOriginFromMenu
  Xlib:  extension "RANDR" missing on display ":99".
  [31135:31135:1001/010936.286730:ERROR:browser_dm_token_storage_linux.cc(93)] Error: /etc/machine-id contains 0 characters (32 were expected).
  [31135:31336:1001/010936.464796:ERROR:bus.cc(396)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
  [31135:31135:1001/010936.512763:WARNING:password_store_factory.cc(262)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
  [31135:31135:1001/010937.192296:ERROR:x11_input_method_context_impl_gtk.cc(144)] Not implemented reached in virtual void libgtkui::X11InputMethodContextImplGtk::SetSurroundingText(const base::string16 &, const gfx::Range &)
  [31335:31386:1001/010937.637926:WARNING:simple_synchronous_entry.cc(1252)] Could not open platform files for entry.
  [31135:31135:1001/010937.665015:WARNING:gaia_auth_fetcher.cc(858)] Could not reach Google Accounts servers: errno -102
  [31135:31388:1001/010937.893971:WARNING:embedded_test_server.cc(239)] Request not handled. Returning 404: /favicon.ico
  [31135:31135:1001/010938.481325:WARNING:gaia_auth_fetcher.cc(858)] Could not reach Google Accounts servers: errno -102
  [31411:31411:1001/010938.971213:WARNING:audio_sandbox_hook_linux.cc(102)] dlopen: failed to open libpulse.so.0 with error: libpulse.so.0: cannot open shared object file: No such file or directory
  [31411:31411:1001/010938.971793:WARNING:audio_sandbox_hook_linux.cc(102)] dlopen: failed to open libpulsecommon-11.1.so with error: libpulsecommon-11.1.so: cannot open shared object file: No such file or directory
  [1:5:1001/010939.016910:ERROR:render_media_log.cc(30)] MediaEvent: MEDIA_ERROR_LOG_ENTRY {"error":"audio render error"}
  [1:1:1001/010939.019401:ERROR:render_media_log.cc(30)] MediaEvent: PIPELINE_ERROR AUDIO_RENDERER_ERROR
  [1:5:1001/010939.024442:ERROR:render_media_log.cc(30)] MediaEvent: MEDIA_ERROR_LOG_ENTRY {"error":"audio render error"}
  [1:1:1001/010939.032520:ERROR:render_media_log.cc(30)] MediaEvent: PIPELINE_ERROR AUDIO_RENDERER_ERROR
  ../../chrome/browser/media/unified_autoplay_browsertest.cc:136: Failure
  Value of: AttemptPlay(new_contents)
    Actual: false
  Expected: true
  Stack trace:
  #0 0x00000b4101b9 StackTraceGetter::CurrentStackTrace()
  #1 0x00000b430b64 testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
  #2 0x00000b42ffbe testing::internal::AssertHelper::operator=()
  #3 0x000009092f24 UnifiedAutoplayBrowserTest_OpenSameOriginFromMenu_Test::RunTestOnMainThread()
  #4 0x00000ed1bc6a content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()

------

[ RUN      ] WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabsOfferRsaAnswerEcdsa
  Xlib:  extension "RANDR" missing on display ":99".
  [30214:30214:1001/010935.348356:ERROR:browser_dm_token_storage_linux.cc(93)] Error: /etc/machine-id contains 0 characters (32 were expected).
  [30214:30288:1001/010935.541952:ERROR:bus.cc(396)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
  [30214:30214:1001/010935.593913:WARNING:password_store_factory.cc(262)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
  [30214:30214:1001/010936.372231:ERROR:x11_input_method_context_impl_gtk.cc(144)] Not implemented reached in virtual void libgtkui::X11InputMethodContextImplGtk::SetSurroundingText(const base::string16 &, const gfx::Range &)
  [30214:30214:1001/010937.096642:WARNING:message_loop_task_runner.cc(26)] Requesting super-long task delay period of 99999999 seconds from here: SchedulePerformStateTransitions@../../chrome/browser/resource_coordinator/tab_manager.cc:955
  [30214:30214:1001/010937.156571:WARNING:gaia_auth_fetcher.cc(858)] Could not reach Google Accounts servers: errno -11
  [30214:30214:1001/010938.176306:WARNING:gaia_auth_fetcher.cc(858)] Could not reach Google Accounts servers: errno -11
  [30214:30214:1001/010938.579790:WARNING:one_google_bar_loader_impl.cc(316)] Request failed with error: -11
  [30214:30350:1001/010938.889052:WARNING:embedded_test_server.cc(239)] Request not handled. Returning 404: /favicon.ico
  [30214:30214:1001/010938.910097:INFO:CONSOLE(13)] "Requesting doGetUserMedia: constraints: {"audio":true,"video":true}", source: http://127.0.0.1:38493/webrtc/test_functions.js (13)
  [30441:30441:1001/010939.487688:WARNING:audio_sandbox_hook_linux.cc(102)] dlopen: failed to open libpulse.so.0 with error: libpulse.so.0: cannot open shared object file: No such file or directory
  [30441:30441:1001/010939.488446:WARNING:audio_sandbox_hook_linux.cc(102)] dlopen: failed to open libpulsecommon-11.1.so with error: libpulsecommon-11.1.so: cannot open shared object file: No such file or directory
  [1:1:1001/010940.106094:WARNING:render_delay_buffer.cc(420)] Applying internal delay of 5 blocks.
  [30214:30214:1001/010940.149529:INFO:CONSOLE(13)] "GetUserMedia FAILED: Maybe the camera is in use by another process?", source: http://127.0.0.1:38493/webrtc/test_functions.js (13)
  [30214:30214:1001/010940.150935:INFO:CONSOLE(13)] "failed-with-error-NotReadableError", source: http://127.0.0.1:38493/webrtc/test_functions.js (13)
  [30214:30214:1001/010940.152222:INFO:CONSOLE(13)] "Returning request-callback-denied to test.", source: http://127.0.0.1:38493/webrtc/test_functions.js (13)
  [30214:30214:1001/010940.157627:INFO:CONSOLE(13)] "Returning failed-with-error-NotReadableError to test.", source: http://127.0.0.1:38493/webrtc/test_functions.js (13)
  ../../chrome/browser/media/webrtc/webrtc_browsertest_base.cc:313: Failure
  Expected equality of these values:
    kOkGotStream
      Which is: "ok-got-stream"
    result
      Which is: "failed-with-error-NotReadableError"
  Stack trace:
  #0 0x00000b4101b9 StackTraceGetter::CurrentStackTrace()
  #1 0x00000b430b64 testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
  #2 0x00000b42ffbe testing::internal::AssertHelper::operator=()
  #3 0x0000090f9730 WebRtcTestBase::OpenPageAndGetUserMediaInNewTabWithConstraints()
  #4 0x0000090f912d WebRtcTestBase::OpenPageAndGetUserMediaInNewTab()
  #5 0x0000090f9807 WebRtcTestBase::OpenTestPageAndGetUserMediaInNewTab()
  #6 0x0000090f23d8 WebRtcBrowserTest::StartServerAndOpenTabs()
  #7 0x0000090f1929 WebRtcBrowserTest::RunsAudioVideoWebRTCCallInTwoTabs()
  #8 0x0000090f00c6 WebRtcBrowserTest_RunsAudioVideoWebRTCCallInTwoTabsOfferRsaAnswerEcdsa_Test::RunTestOnMainThread()
  #9 0x00000ed1bc6a content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()

------

All failing tests:

4 tests failed:
      CDM_10/ECKEncryptedMediaTest.Playback_Encryption_CENC/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:710)
      MSE_ClearKey/EncryptedMediaTest.ConfigChangeVideo_ClearToEncrypted/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:499)
      MSE_ClearKey/EncryptedMediaTest.FrameSizeChangeVideo/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:499)
      UnifiedAutoplayBrowserTest.OpenSameOriginFromMenu (../../chrome/browser/media/unified_autoplay_browsertest.cc:128)
  9 tests timed out:
      CastMirroringServiceHostBrowserTest.CaptureTabAudio (../../chrome/browser/media/cast_mirroring_service_host_browsertest.cc:246)
      MediaEngagementBrowserTest.DoNotRecordEngagement_PlaybackStopped (../../chrome/browser/media/media_engagement_browsertest.cc:403)
      MediaEngagementBrowserTest.RecordAudibleBasedOnShortTime (../../chrome/browser/media/media_engagement_browsertest.cc:554)
      MediaEngagementBrowserTest.RecordVisitOnBrowserClose (../../chrome/browser/media/media_engagement_browsertest.cc:467)
      MediaEngagementBrowserTest.SessionNewTabNavigateSameURL (../../chrome/browser/media/media_engagement_browsertest.cc:562)
      MediaEngagementSessionRestoreBrowserTest.RestoredSession_Playback_MEI (../../chrome/browser/media/media_engagement_browsertest.cc:774)
      PrerenderBrowserTest.PrerenderHTML5VideoJs (../../chrome/browser/prerender/prerender_browsertest.cc:1923)
      WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabsEmitsGatheringStateChange (../../chrome/browser/media/webrtc/webrtc_browsertest.cc:252)
      WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabsGetStatsCallback (../../chrome/browser/media/webrtc/webrtc_browsertest.cc:216)

...

  9 tests failed:
      CDM_11/ECKEncryptedMediaTest.CdmProxy/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:710)
      CastStreamingApiTest.BadLogging (../../chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc:66)
      MSE_ClearKey/EncryptedMediaTest.ConfigChangeVideo_EncryptedToEncrypted/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:499)
      MSE_ClearKey/EncryptedMediaTest.Playback_EncryptedVideo_MP4_ClearAudio_WEBM/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:499)
      MSE_ClearKey/EncryptedMediaTest.Playback_EncryptedVideo_WEBM_EncryptedAudio_MP4/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:499)
      MSE_ExternalClearKey/EncryptedMediaTest.ConfigChangeVideo_ClearToEncrypted/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:499)
      MediaEngagementAutoplayBrowserTest.TopFrameNavigation/1 (../../chrome/browser/media/media_engagement_autoplay_browsertest.cc:212)
      MediaEngagementAutoplayBrowserTest.UsePreloadedData_Allowed/1 (../../chrome/browser/media/media_engagement_autoplay_browsertest.cc:212)
      WebRtcFromWebAccessibleResourceTest.GetUserMediaInWebAccessibleResourceSuccess (../../chrome/browser/extensions/api/webrtc_from_web_accessible_resource_browsertest.cc:92)
  5 tests timed out:
      MediaEngagementBrowserTest.RecordEngagement_NotVisible_AudioOnly (../../chrome/browser/media/media_engagement_browsertest.cc:432)
      MediaEngagementBrowserTest.RecordVisitOnNewOrigin (../../chrome/browser/media/media_engagement_browsertest.cc:490)
      MediaEngagementBrowserTest.SessionNewTabNavigateSameURLWithOpener_Typed (../../chrome/browser/media/media_engagement_browsertest.cc:656)
      WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabsOfferRsaAnswerRsa (../../chrome/browser/media/webrtc/webrtc_browsertest.cc:176)
      WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabsWithClonedCertificateRsa (../../chrome/browser/media/webrtc/webrtc_browsertest.cc:191)
 
Owner: marinaciocea@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a13eecb2dba24057f7a7e52ad62ed4396f23d6e

commit 9a13eecb2dba24057f7a7e52ad62ed4396f23d6e
Author: François Doray <fdoray@chromium.org>
Date: Mon Oct 01 16:29:42 2018

Revert "Enable AudioServiceSandbox flag in audio service field trial testing."

This reverts commit 6caca44331621dd0ba01b2ca1e01b0eb90d2c5b5.

Reason for revert: I suspect that this CL is causing  https://crbug.com/890850 

Original change's description:
> Enable AudioServiceSandbox flag in audio service field trial testing.
> 
> Bug: 832666
> Change-Id: I3ec5dbea8e34f3a9295723def845e49b2bb59af3
> Reviewed-on: https://chromium-review.googlesource.com/1240280
> Reviewed-by: Steven Holte <holte@chromium.org>
> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#595397}

TBR=holte@chromium.org,marinaciocea@chromium.org

Change-Id: I5e6d1a9e153003c086ce8c2f247230d4832ce99b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 832666,  890850 
Reviewed-on: https://chromium-review.googlesource.com/1254746
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595464}
[modify] https://crrev.com/9a13eecb2dba24057f7a7e52ad62ed4396f23d6e/testing/variations/fieldtrial_testing_config.json

Labels: -Pri-3 Pri-1
Status: Assigned (was: Untriaged)
Labels: OS-Linux
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c8daef006b8f8ce2c0805ca6dd1dde88cc5050c

commit 0c8daef006b8f8ce2c0805ca6dd1dde88cc5050c
Author: Marina Ciocea <marinaciocea@chromium.org>
Date: Mon Oct 01 17:21:17 2018

Enable AudioServiceSandbox flag in audio service field trial testing on Windows and Mac.

This reverts commit 9a13eecb2dba24057f7a7e52ad62ed4396f23d6e.

Reason for revert: Enable sandbox only for Windows and Mac. Leave sandbox disabled on Linux until I fix #890850.

Original change's description:
> Revert "Enable AudioServiceSandbox flag in audio service field trial testing."
>
> This reverts commit 6caca44331621dd0ba01b2ca1e01b0eb90d2c5b5.
>
> Reason for revert: I suspect that this CL is causing  https://crbug.com/890850 
>
> Original change's description:
> > Enable AudioServiceSandbox flag in audio service field trial testing.
> >
> > Bug: 832666
> > Change-Id: I3ec5dbea8e34f3a9295723def845e49b2bb59af3
> > Reviewed-on: https://chromium-review.googlesource.com/1240280
> > Reviewed-by: Steven Holte <holte@chromium.org>
> > Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#595397}
>
> TBR=holte@chromium.org,marinaciocea@chromium.org
>
> Change-Id: I5e6d1a9e153003c086ce8c2f247230d4832ce99b
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 832666,  890850 
> Reviewed-on: https://chromium-review.googlesource.com/1254746
> Reviewed-by: François Doray <fdoray@chromium.org>
> Commit-Queue: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#595464}

TBR=fdoray@chromium.org,holte@chromium.org,marinaciocea@chromium.org

Change-Id: I5176102960a7450de1b44612b85c7098d0df9c8c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 832666,  890850 
Reviewed-on: https://chromium-review.googlesource.com/1255063
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595475}
[modify] https://crrev.com/0c8daef006b8f8ce2c0805ca6dd1dde88cc5050c/testing/variations/fieldtrial_testing_config.json

 Issue 890917  has been merged into this issue.
Labels: M-71
Status: Started (was: Assigned)
Looks like an x86 specific issue, tests pass on Linux x64 bot: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8933884153150086896/+/steps/browser_tests/0/stdout
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7dc9dfa0d23947d676cdaed77b0df1a937ec77c2

commit 7dc9dfa0d23947d676cdaed77b0df1a937ec77c2
Author: Marina Ciocea <marinaciocea@chromium.org>
Date: Wed Oct 17 21:15:26 2018

Add ftruncate64 to audio sandbox policy.

Audio sandbox policy currently allows ftruncate syscall; adding ftruncate64
used on x86 systems.

This fix solves browser_tests failures on 32 bit Linux bots. With ftruncate64
blocked, IPC between audio process and renderer was failing leading to audio
render errors.

Bug:  890850 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I6b09429c018468e0eb037498514df048fe79d520
Reviewed-on: https://chromium-review.googlesource.com/c/1282407
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600555}
[modify] https://crrev.com/7dc9dfa0d23947d676cdaed77b0df1a937ec77c2/services/service_manager/sandbox/linux/bpf_audio_policy_linux.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cde1131dcc8567362dc54cca802ca772ee380ed1

commit cde1131dcc8567362dc54cca802ca772ee380ed1
Author: Marina Ciocea <marinaciocea@chromium.org>
Date: Thu Oct 18 07:17:22 2018

Enable audio service sandbox feature on Linux test bots.

This is a reland of https://crrev.com/c/1240280 after fixing #890850 in parent
CL.

TBR=holte

Bug: 832666,  890850 
Change-Id: I98cc6918842b8acfe0dae14ed176b29b92eadc4e
Reviewed-on: https://chromium-review.googlesource.com/c/1283132
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600679}
[modify] https://crrev.com/cde1131dcc8567362dc54cca802ca772ee380ed1/testing/variations/fieldtrial_testing_config.json

Labels: Merge-Request-71
Status: Verified (was: Started)
Tests pass with #9 fix and #10 sandbox reenable:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29%2832%29/53611

Please approve M71 merge request. The fix is low risk, affecting Linux x86 systems, and needed for unblocking audio service sandbox group in M71 Beta finch experiment.
Project Member

Comment 12 by sheriffbot@chromium.org, Oct 19

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-71 Merge-Approved-71
Approving merge to M71 branch 3578 based on comment #11. Pls merge ASAP so we can pick it up for M71 Beta release. Thank you.
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 19

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3277952d221154b6d75c9d5ee9cd37b320aff500

commit 3277952d221154b6d75c9d5ee9cd37b320aff500
Author: Marina Ciocea <marinaciocea@chromium.org>
Date: Fri Oct 19 20:15:18 2018

[M71] Add ftruncate64 to audio sandbox policy.

Audio sandbox policy currently allows ftruncate syscall; adding ftruncate64
used on x86 systems.

This fix solves browser_tests failures on 32 bit Linux bots. With ftruncate64
blocked, IPC between audio process and renderer was failing leading to audio
render errors.

Bug:  890850 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I6b09429c018468e0eb037498514df048fe79d520
Reviewed-on: https://chromium-review.googlesource.com/c/1282407
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600555}(cherry picked from commit 7dc9dfa0d23947d676cdaed77b0df1a937ec77c2)
Reviewed-on: https://chromium-review.googlesource.com/c/1292470
Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#168}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/3277952d221154b6d75c9d5ee9cd37b320aff500/services/service_manager/sandbox/linux/bpf_audio_policy_linux.cc

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/3277952d221154b6d75c9d5ee9cd37b320aff500

Commit: 3277952d221154b6d75c9d5ee9cd37b320aff500
Author: marinaciocea@chromium.org
Commiter: marinaciocea@chromium.org
Date: 2018-10-19 20:15:18 +0000 UTC

[M71] Add ftruncate64 to audio sandbox policy.

Audio sandbox policy currently allows ftruncate syscall; adding ftruncate64
used on x86 systems.

This fix solves browser_tests failures on 32 bit Linux bots. With ftruncate64
blocked, IPC between audio process and renderer was failing leading to audio
render errors.

Bug:  890850 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I6b09429c018468e0eb037498514df048fe79d520
Reviewed-on: https://chromium-review.googlesource.com/c/1282407
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600555}(cherry picked from commit 7dc9dfa0d23947d676cdaed77b0df1a937ec77c2)
Reviewed-on: https://chromium-review.googlesource.com/c/1292470
Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#168}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Sign in to add a comment