Convert ios/chrome/browser/ui/settings/clear_browsing_data_manager.mm to IdentityManager |
||
Issue descriptionAPI used: - SigninManager::IsAuthenticated()
,
Nov 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05c32ab7198dc1aa6f87b5872b3e98195dede873 commit 05c32ab7198dc1aa6f87b5872b3e98195dede873 Author: Mario Sanchez Prada <mario@igalia.com> Date: Tue Nov 06 18:01:21 2018 [ios] Migrate ClearBrowsingDataManager to the IdentityManager Use identity::IdentityManager::HasPrimaryAccount() instead of SigninManagerBase::IsAuthenticated, and remove unneeded includes. Bug: 890826 Change-Id: Iabe09231fa684e8249475ba9dcd8782d7ecd90d5 Reviewed-on: https://chromium-review.googlesource.com/c/1315969 Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#605735} [modify] https://crrev.com/05c32ab7198dc1aa6f87b5872b3e98195dede873/ios/chrome/browser/ui/settings/clear_browsing_data_manager.mm
,
Nov 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b72eeec68ad1991b2f2989eb599e7486fe6a2b04 commit b72eeec68ad1991b2f2989eb599e7486fe6a2b04 Author: Mario Sanchez Prada <mario@igalia.com> Date: Fri Nov 09 09:43:50 2018 Migrate clear_browsing_data_manager_unittest.mm to the Identity service Use IdentityTestEnvironmentChromeBrowserStateAdaptor instead of manually creating the browser's state by providing specific factories, and then use the APIs from IdentityTestEnvironment, instead of SigninManagerBase. Bug: 890826 Change-Id: Id9d422e002d8fd2edc0ef1ad158f29e95c6dce64 Reviewed-on: https://chromium-review.googlesource.com/c/1318974 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#606774} [modify] https://crrev.com/b72eeec68ad1991b2f2989eb599e7486fe6a2b04/ios/chrome/browser/ui/settings/BUILD.gn [modify] https://crrev.com/b72eeec68ad1991b2f2989eb599e7486fe6a2b04/ios/chrome/browser/ui/settings/clear_browsing_data_manager_unittest.mm
,
Nov 9
|
||
►
Sign in to add a comment |
||
Comment 1 by ma...@igalia.com
, Nov 2Status: Started (was: Available)