New issue
Advanced search Search tips

Issue 890825 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 5
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task

Blocking:
issue 883330



Sign in to add a comment

Convert ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_coordinator_unittest.mm to IdentityManager

Project Member Reported by sdefresne@chromium.org, Oct 1

Issue description

API used:
- SigninManager::SignOut()
- SigninManager::IsAuthenticated()

 
Owner: ma...@igalia.com
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18bf59482aece24a845cfd2a5455569201cb84fa

commit 18bf59482aece24a845cfd2a5455569201cb84fa
Author: Mario Sanchez Prada <mario@igalia.com>
Date: Mon Nov 05 12:40:39 2018

[ios] Migrate recent_tabs_coordinator_unittest.mm to IdentityManager

Migrated to the IdentityManager by relying on IdentityTestEnvironment,
so that we can use MakePrimaryAccount() without needing to explicitly
pass a ProfileOAuth2TokenService and a SigninManagerBase.

Bug:  890825 
Change-Id: I20e228e7d9f5d2c2154666d264e31b5154bdcff8
Reviewed-on: https://chromium-review.googlesource.com/c/1314635
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605304}
[modify] https://crrev.com/18bf59482aece24a845cfd2a5455569201cb84fa/ios/chrome/browser/ui/recent_tabs/BUILD.gn
[modify] https://crrev.com/18bf59482aece24a845cfd2a5455569201cb84fa/ios/chrome/browser/ui/recent_tabs/recent_tabs_coordinator_unittest.mm

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44a923966e0d3b88b4472e834f0ab99e50c886af

commit 44a923966e0d3b88b4472e834f0ab99e50c886af
Author: Mario Sanchez Prada <mario@igalia.com>
Date: Mon Nov 05 17:49:24 2018

[ios] Cleanup in recent_tabs_coordinator_unittest.mm after CL1314635

Let's use "test@test.com" to make it more explicit that we're passing
an email address to MakePrimaryAccountAvailable(), and avoid using
an accessor method when we can simply reference an object directly.

Bug:  890825 
Change-Id: Id84246d3c07e7494c7b9188000a18277fce92621
Reviewed-on: https://chromium-review.googlesource.com/c/1317862
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#605370}
[modify] https://crrev.com/44a923966e0d3b88b4472e834f0ab99e50c886af/ios/chrome/browser/ui/recent_tabs/recent_tabs_coordinator_unittest.mm

Sign in to add a comment