Taking this..

It is actually not using any IsAuthenticated() call. The delegate just extends from SigninManagerFactory to know whether a SigninManager was either created or destroyed. Any required further action @sdefresne?

@sdefresne is OOO so adding @blundell to the loop

Hi Sergio, it actually is using IsAuthenticated() AFAICT: https://cs.chromium.org/chromium/src/ios/chrome/browser/signin/ios_chrome_signin_status_metrics_provider_delegate.cc?q=IOSChromeSigninStatu&sq=package:chromium&g=0&l=41

Is there anything I'm missing?

I think I just messed things up, probably taking a look at 2-3 different bugs at the same times :)

No problem!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a85032e3707c299ac7d61f2f82a2cd44bb4dd818

commit a85032e3707c299ac7d61f2f82a2cd44bb4dd818
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Thu Nov 15 13:16:39 2018

Convert IOSChromeSigninStatusMetricsProviderDelegate to IdentityManager

It used to call SiginManager::IsAuthenticated(). Replaced that call by
IdentityManager::HasPrimaryAccount().

Bug:  890822 
Change-Id: If6e24c69db6f4634a5f96110ad9ca590b6d74d45
Reviewed-on: https://chromium-review.googlesource.com/c/1329677
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#608343}
[modify] https://crrev.com/a85032e3707c299ac7d61f2f82a2cd44bb4dd818/ios/chrome/browser/signin/ios_chrome_signin_status_metrics_provider_delegate.cc

This should be closed