API used: - SigninManager::OnExternalSigninCompleted() - SigninManager::IsAuthenticated() - SigninManager::SignOut() - SigninManagerBase::GetAuthenticatedAccountInfo()
Working on this
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b18d70620f2532e08d01a8874bc907764a10b0c8 commit b18d70620f2532e08d01a8874bc907764a10b0c8 Author: Sergio Villar Senin <svillar@igalia.com> Date: Fri Nov 16 15:31:32 2018 Migrate iOS' AuthenticationService classes This is a first step in the migration of the different iOS' authentication_service_* classes to the IdentityManager API. The migration cannot be completed at this point as several APIs are not available yet. This CL is basically passing the IdentityManager to the different classes and using its API whenever appropiate instead of directly calling SinginManager and TokenService. Bug: 890817 , 890818 , 890819 , 890820 , 890820 Change-Id: I6df4466cc7f8ff1524e9736cb54376c0ee166070 Reviewed-on: https://chromium-review.googlesource.com/c/1335567 Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#608788} [modify] https://crrev.com/b18d70620f2532e08d01a8874bc907764a10b0c8/ios/chrome/browser/signin/authentication_service.h [modify] https://crrev.com/b18d70620f2532e08d01a8874bc907764a10b0c8/ios/chrome/browser/signin/authentication_service.mm [modify] https://crrev.com/b18d70620f2532e08d01a8874bc907764a10b0c8/ios/chrome/browser/signin/authentication_service_factory.mm [modify] https://crrev.com/b18d70620f2532e08d01a8874bc907764a10b0c8/ios/chrome/browser/signin/authentication_service_fake.h [modify] https://crrev.com/b18d70620f2532e08d01a8874bc907764a10b0c8/ios/chrome/browser/signin/authentication_service_fake.mm [modify] https://crrev.com/b18d70620f2532e08d01a8874bc907764a10b0c8/ios/chrome/browser/signin/authentication_service_unittest.mm
Forgot to assign this to me
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e73ecbd3095ffcebb1f52d499230cbb9df6dc77a commit e73ecbd3095ffcebb1f52d499230cbb9df6dc77a Author: Sergio Villar Senin <svillar@igalia.com> Date: Tue Nov 20 09:51:57 2018 Convert iOS AuthenticationService classes to IdentityManager This is a follow up of crrev.com/c/1335567. The only missing bit pending to be migrated was some SigninManager API that is now replaced by the PrimaryAccountMutator API. Bug: 890817 , 890818 , 890819 , 890820 , 890820 Change-Id: I9c746457987038bc810163dbb69dafdba75a74f0 Reviewed-on: https://chromium-review.googlesource.com/c/1341537 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#609651} [modify] https://crrev.com/e73ecbd3095ffcebb1f52d499230cbb9df6dc77a/ios/chrome/browser/signin/authentication_service.h [modify] https://crrev.com/e73ecbd3095ffcebb1f52d499230cbb9df6dc77a/ios/chrome/browser/signin/authentication_service.mm [modify] https://crrev.com/e73ecbd3095ffcebb1f52d499230cbb9df6dc77a/ios/chrome/browser/signin/authentication_service_factory.mm [modify] https://crrev.com/e73ecbd3095ffcebb1f52d499230cbb9df6dc77a/ios/chrome/browser/signin/authentication_service_fake.h [modify] https://crrev.com/e73ecbd3095ffcebb1f52d499230cbb9df6dc77a/ios/chrome/browser/signin/authentication_service_fake.mm [modify] https://crrev.com/e73ecbd3095ffcebb1f52d499230cbb9df6dc77a/ios/chrome/browser/signin/authentication_service_unittest.mm
Now closing
Comment 1 by blundell@chromium.org
, Nov 12