New issue
Advanced search Search tips

Issue 890816 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 6
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task

Blocking:
issue 883330



Sign in to add a comment

Convert ios/chrome/browser/autocomplete/autocomplete_provider_client_impl.cc to IdentityManager

Project Member Reported by sdefresne@chromium.org, Oct 1

Issue description

API used:
- SigninManager::IsAuthenticated()

 
Owner: ma...@igalia.com
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e82a201f56c0bc833e2efcc2dd5ced02b8ab5f9

commit 5e82a201f56c0bc833e2efcc2dd5ced02b8ab5f9
Author: Mario Sanchez Prada <mario@igalia.com>
Date: Tue Nov 06 19:21:46 2018

[ios] Migrate AutocompleteProviderClientImpl to the IdentityManager

Use call to IdentityManager::HasPrimaryAccount() instead of the former
SigninManagerBase::IsAuthenticated(), and remove unnecessary includes.

Bug:  890816 
Change-Id: I7d5d0f6a078c1065984cabcc071efd3fc02ed92d
Reviewed-on: https://chromium-review.googlesource.com/c/1314472
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#605781}
[modify] https://crrev.com/5e82a201f56c0bc833e2efcc2dd5ced02b8ab5f9/ios/chrome/browser/autocomplete/BUILD.gn
[modify] https://crrev.com/5e82a201f56c0bc833e2efcc2dd5ced02b8ab5f9/ios/chrome/browser/autocomplete/autocomplete_provider_client_impl.mm

Status: Fixed (was: Started)

Sign in to add a comment