New issue
Advanced search Search tips

Issue 890813 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 10
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task

Blocked on:
issue 889902
issue 906062

Blocking:
issue 883330



Sign in to add a comment

Convert chrome/browser/ui/webui/signin/inline_login_handler_impl.cc to IdentityManager

Project Member Reported by sdefresne@chromium.org, Oct 1

Issue description

API used:
- SigninManagerBase::GetAuthenticatedAccountInfo()

 
Blockedon: 889902
Owner: ma...@igalia.com
Status: Started (was: Available)
This file requires a migration path for SigninManager::MergeSigninCredentialInCookieJar() before being completely migrated off the SigninManager, setting dependency on 889902.

WIP CL in here:
https://chromium-review.googlesource.com/c/chromium/src/+/1259009
Status: Assigned (was: Started)
Moving this one to assigned since we can't implement the CL until there's a migration path for SigninManager::MergeSigninCredentialInCookieJar via the newly added class PrimaryAccountMutator (see https://bugs.chromium.org/p/chromium/issues/detail?id=889902#c20)
Blockedon: 906062
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fea47aacf80c5e06dc7246a9b3673525cf14b62

commit 8fea47aacf80c5e06dc7246a9b3673525cf14b62
Author: Mario Sanchez Prada <mario@igalia.com>
Date: Thu Dec 06 08:54:03 2018

Convert InlineLoginHandlerImpl to IdentityManager

Replace usage of SigninManager's API with calls to APIs from the
IdentityManager and PrimaryAccountMutator.

Bug:  890813 
Change-Id: I1a70a47e41aa132f0d5e4a1de12bd7c5d5eb31ce
Reviewed-on: https://chromium-review.googlesource.com/c/1259009
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#614289}
[modify] https://crrev.com/8fea47aacf80c5e06dc7246a9b3673525cf14b62/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
[modify] https://crrev.com/8fea47aacf80c5e06dc7246a9b3673525cf14b62/chrome/browser/ui/webui/signin/inline_login_handler_impl.h

Status: Fixed (was: Started)

Sign in to add a comment