New issue
Advanced search Search tips

Issue 890811 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task


Sign in to add a comment

Convert chrome/browser/ui/webui/signin/dice_turn_sync_on_helper.cc to IdentityManager

Project Member Reported by sdefresne@chromium.org, Oct 1

Issue description

APIs used:
- SigninManager::OnExternalSigninCompleted()
- SigninManager::SignOut()
- SigninManager::SignOutAndKeepAllAccounts()
- SigninManager::IsAuthenticated()

- PO2TS::RevokeCredentials()
- PO2TS::ExtractCredentials()
 
Blockedon: 907901
Blocking: 883318
Labels: Proj-Servicification-VendorBug
This class also uses PO2TS to revoke credentials; this should be converted to AccountsMutator.

Finally, the unittest should be converted to use IdentityTestEnvironment.
Owner: toniki...@chromium.org
Status: Started (was: Available)
Description: Show this description
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a59054d082649116a5656724026a872c3ac1c4c6

commit a59054d082649116a5656724026a872c3ac1c4c6
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Fri Dec 21 20:59:14 2018

[s13n] Convert c/b/ui/webui/signin/dice_turn_sync_on_helper.cc to IdentityManager

SigninManager, PO2TS and AccountTrackerService are going to be an implementation
detail of the IdentityManager et al, and eventually will not be exposed to clients
out of //services/identity.
This CL converts DiceTurnSyncOnHelper and its subclasses accordingly.

The remaing work is the completely removal of the use of PO2TS in production
code, which is blocked on  bug 907901  (PO2TS::RevokeCredentials).

BUG=890811, 890812 

Change-Id: I5673c254e2ce494293627616f596945945d6ded1
Reviewed-on: https://chromium-review.googlesource.com/c/1387393
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#618594}
[modify] https://crrev.com/a59054d082649116a5656724026a872c3ac1c4c6/chrome/browser/ui/webui/signin/dice_turn_sync_on_helper.cc
[modify] https://crrev.com/a59054d082649116a5656724026a872c3ac1c4c6/chrome/browser/ui/webui/signin/dice_turn_sync_on_helper.h
[modify] https://crrev.com/a59054d082649116a5656724026a872c3ac1c4c6/chrome/browser/ui/webui/signin/dice_turn_sync_on_helper_unittest.cc

Blockedon: 922017

Comment 8 by blundell@chromium.org, Jan 16 (6 days ago)

Added a bug for the creation of the equivalent of ExtractCredentials().

Comment 9 by toniki...@chromium.org, Yesterday (37 hours ago)

Blockedon: 922482

Sign in to add a comment