New issue
Advanced search Search tips

Issue 890808 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 16
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task

Blocking:
issue 883330



Sign in to add a comment

Convert chrome/browser/ui/webui/chromeos/login/arc_terms_of_service_screen_handler.cc to IdentityManager

Project Member Reported by sdefresne@chromium.org, Oct 1

Issue description

API used:
- SigninManager::IsAuthenticated()

 
Owner: svil...@igalia.com
Status: Started (was: Available)
Taking this
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17d11907ccd0ed818d2a9f6d0db145dfea03871f

commit 17d11907ccd0ed818d2a9f6d0db145dfea03871f
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Tue Oct 16 09:04:27 2018

Convert arc_terms_of_service_screen_handler.cc to IdentityManager

It was using SigninManagerBase API to get the primary (authenticated)
account id. It's now using the IdentityManager API.

Bug:  890808 
Change-Id: Ifabe11ca68de07949fcad2f81c022723dcb842ef
Reviewed-on: https://chromium-review.googlesource.com/c/1276769
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#599925}
[modify] https://crrev.com/17d11907ccd0ed818d2a9f6d0db145dfea03871f/chrome/browser/ui/webui/chromeos/login/arc_terms_of_service_screen_handler.cc

Status: Fixed (was: Started)
Fixed!

Sign in to add a comment