Convert chrome/browser/ui/views/profiles/profile_chooser_view.cc to IdentityManager |
|||
Issue descriptionAPI used: - SigninManager::IsSigninAllowed() - SigninManager::SignOut() - SigninManager::IsAuthenticated()
,
Nov 7
CL: https://chromium-review.googlesource.com/c/chromium/src/+/1324589 it touches a method in chrome/browser/sync/sync_ui_util.cc (covered by bug 890796 ). Setting dependency.
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ebaf6fb99f5992c82f731ac8b2ff4b30a55b76e4 commit ebaf6fb99f5992c82f731ac8b2ff4b30a55b76e4 Author: Antonio Gomes <tonikitoo@igalia.com> Date: Thu Nov 08 11:33:33 2018 [s13n] Convert c/b/ui/views/profiles/profile_chooser_view.cc to IdentityManager CL also converts ::GetMessagesForAvatarSyncError defined at c/b/sync/sync_ui_util.h|cc, (but not the whole file). BUG= 890804 , 890796 Change-Id: I4d7dbbdb1c5ca6f86e44cf9b4b454143eac08d9d Reviewed-on: https://chromium-review.googlesource.com/c/1324589 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Thomas Tangl <tangltom@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#606415} [modify] https://crrev.com/ebaf6fb99f5992c82f731ac8b2ff4b30a55b76e4/chrome/browser/sync/sync_ui_util.cc [modify] https://crrev.com/ebaf6fb99f5992c82f731ac8b2ff4b30a55b76e4/chrome/browser/sync/sync_ui_util.h [modify] https://crrev.com/ebaf6fb99f5992c82f731ac8b2ff4b30a55b76e4/chrome/browser/ui/views/profiles/avatar_toolbar_button.cc [modify] https://crrev.com/ebaf6fb99f5992c82f731ac8b2ff4b30a55b76e4/chrome/browser/ui/views/profiles/profile_chooser_view.cc
,
Nov 8
|
|||
►
Sign in to add a comment |
|||
Comment 1 by toniki...@chromium.org
, Oct 31Owner: toniki...@chromium.org
Status: Started (was: Available)