New issue
Advanced search Search tips

Issue 890802 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 7
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task

Blocked on:
issue 906065

Blocking:
issue 883330



Sign in to add a comment

Convert chrome/browser/ui/sync/one_click_signin_sync_starter.cc to IdentityManager

Project Member Reported by sdefresne@chromium.org, Oct 1

Issue description

API used:
- SigninManager::StartSignInWithRefreshToken()
- SigninManager::IsAuthenticated()
- SigninManager::GetUsernameForAuthInProgress()
- SigninManager::GetGaiaIdForAuthInProgress()
- SigninManager::CompletePendingSignin()
- SigninManager::CopyCredentialsFrom()
- SigninManager::SignOutAndRemoveAllAccounts()
- SigninManager::AuthInProgress()
- SigninManager::SignOut()

 
 Issue 809034  has been merged into this issue.
Labels: Proj-Servicification-VendorBug
Blockedon: -889902 906065
Owner: ma...@igalia.com
Status: Started (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ddcd8695b975a5677ff2b6baf8a5b8c87c01c50

commit 4ddcd8695b975a5677ff2b6baf8a5b8c87c01c50
Author: Mario Sanchez Prada <mario@igalia.com>
Date: Mon Jan 07 13:09:17 2019

Convert //c/b/ui/sync/one_click_signin_sync_starter.cc to IdentityManager

Migrate away from SigninManager and use the APIs from IdentityManager
and PrimaryAccountMutator instead.

Bug:  890802 
Change-Id: I348c07d635132bb720d2ec62b8a08e18cdef39f6
Reviewed-on: https://chromium-review.googlesource.com/c/1386832
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620304}
[modify] https://crrev.com/4ddcd8695b975a5677ff2b6baf8a5b8c87c01c50/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
[modify] https://crrev.com/4ddcd8695b975a5677ff2b6baf8a5b8c87c01c50/chrome/browser/ui/sync/one_click_signin_sync_starter.h

Status: Fixed (was: Started)

Sign in to add a comment