New issue
Advanced search Search tips

Issue 890800 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task

Blocked on:
issue 889863

Blocking:
issue 883330



Sign in to add a comment

Convert chrome/browser/ui/chrome_pages.cc to IdentityManager

Project Member Reported by sdefresne@chromium.org, Oct 1

Issue description

API used:
- SigninManager::IsSigninAllowed()
- SigninManager::IsAuthenticated()

 
Cc: blundell@chromium.org
 Issue 903888  has been merged into this issue.
 Issue 797928  has been merged into this issue.
Labels: Proj-Servicification-VendorBug
Owner: svil...@igalia.com
Status: Started (was: Available)
Working on this
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcfc0e98983347a93675c8e71741914db6d92a38

commit bcfc0e98983347a93675c8e71741914db6d92a38
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Thu Dec 20 15:11:20 2018

Convert chrome/browser/ui/chrome_pages.cc to IdentityManager

It was using the SigninManager API to check whether signin was allowed
and to verify that the primary account was authenticated. Replaced by
calls to IdentityManager.

Bug:  890800 
Change-Id: Ic2b6ce2606ecdf3fd403c2318a0e79ee15221521
Reviewed-on: https://chromium-review.googlesource.com/c/1384205
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#618214}
[modify] https://crrev.com/bcfc0e98983347a93675c8e71741914db6d92a38/chrome/browser/ui/chrome_pages.cc

Status: Fixed (was: Started)

Sign in to add a comment