New issue
Advanced search Search tips

Issue 890793 link

Starred by 3 users
Status: Fixed
Owner:
ma...@igalia.com
Closed: Dec 20
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task

Blocked on:
issue 889902
issue 889863
Blocking:
issue 883330



Sign in to add a comment

Convert chrome/browser/signin/signin_promo_util.cc to IdentityManager

Project Member Reported by sdefresne@chromium.org, Oct 1 
API used:
- SigninManager::IsSigninAllowed()
- SigninManager::IsAuthenticated()
- SigninManager::AuthInProgress()

Comment 1 by blundell@chromium.org, Dec 13 

 Issue 797937  has been merged into this issue.

Comment 2 by blundell@chromium.org, Dec 13

Labels: Proj-Servicification-VendorBug

Comment 3 by ma...@igalia.com, Dec 18

Owner: ma...@igalia.com
Status: Started (was: Available)
Taking this one
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6e44e42fb5ac61b9e2662a063011077a7eff0e7

commit a6e44e42fb5ac61b9e2662a063011077a7eff0e7
Author: Mario Sanchez Prada <mario@igalia.com>
Date: Thu Dec 20 12:47:20 2018

Convert chrome/browser/signin/signin_promo_util.cc to IdentityManager

Migrate away from SigninManager using the APIs from IdentityManager and
PrimaryAccountMutator, and the value from the "signin.allowed" preference.

Bug:  890793 
Change-Id: I3be5b91b859aa5cd9cd69ea0abc824c51a44066f
Reviewed-on: https://chromium-review.googlesource.com/c/1382486
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#618185}
[modify] https://crrev.com/a6e44e42fb5ac61b9e2662a063011077a7eff0e7/chrome/browser/signin/signin_promo_util.cc

Comment 6 by ma...@igalia.com, Dec 20

Status: Fixed (was: Started)
►

Sign in to add a comment