New issue
Advanced search Search tips

Issue 890792 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 12
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task

Blocking:
issue 883330



Sign in to add a comment

Convert chrome/browser/signin/signin_global_error.cc to IdentityManager

Project Member Reported by sdefresne@chromium.org, Oct 1

Issue description

API used:
- SigninManager::IsAuthenticated()

 
Owner: svil...@igalia.com
Status: Started (was: Available)
Taking this
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/557d4cfd2336cc35f91ec95bb9ef4b1290e6d491

commit 557d4cfd2336cc35f91ec95bb9ef4b1290e6d491
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Fri Oct 12 11:46:53 2018

Convert chrome/browser/signin/signin_global_error.cc to IdentityManager

It was using SigninManagerBase API to get the primary (authenticated)
account id. It's now using the IdentityManager API.

Bug:  890792 
Change-Id: Ia8cdd8e491f29256af2c015a9127b0766e81b99e
Reviewed-on: https://chromium-review.googlesource.com/c/1276965
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599173}
[modify] https://crrev.com/557d4cfd2336cc35f91ec95bb9ef4b1290e6d491/chrome/browser/signin/signin_global_error.cc

Status: Fixed (was: Started)
Closing then

Sign in to add a comment