Convert chrome/browser/signin/process_dice_header_delegate_impl.cc to IdentityManager |
||
Issue descriptionAPI used: - SigninManager::IsAuthenticated()
,
Oct 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/453c2ddb7e9c33b8e306d48442b4d70342a39717 commit 453c2ddb7e9c33b8e306d48442b4d70342a39717 Author: Sergio Villar Senin <svillar@igalia.com> Date: Mon Oct 15 11:07:36 2018 Migrate process_dice_header_delegate_impl.cc to IdentityManager It was using the SinginManager API instead. The unit test was partially migrated too as the object now receives the IdentityManager as argument. The test still uses some APIs that will be eventually replaced by follow up CLs. Bug: 890791 Change-Id: I7a2f18bd8ce01eec85954b716b9064a914b613e3 Reviewed-on: https://chromium-review.googlesource.com/c/1278788 Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#599611} [modify] https://crrev.com/453c2ddb7e9c33b8e306d48442b4d70342a39717/chrome/browser/signin/chrome_signin_helper.cc [modify] https://crrev.com/453c2ddb7e9c33b8e306d48442b4d70342a39717/chrome/browser/signin/process_dice_header_delegate_impl.cc [modify] https://crrev.com/453c2ddb7e9c33b8e306d48442b4d70342a39717/chrome/browser/signin/process_dice_header_delegate_impl.h [modify] https://crrev.com/453c2ddb7e9c33b8e306d48442b4d70342a39717/chrome/browser/signin/process_dice_header_delegate_impl_unittest.cc
,
Oct 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4cdc95ad6713e3ba3eec5d245a0e41c34ddee003 commit 4cdc95ad6713e3ba3eec5d245a0e41c34ddee003 Author: Sergio Villar Senin <svillar@igalia.com> Date: Tue Oct 16 15:11:49 2018 Migrate process_dice_header_delegate_impl_unittest.cc to IdentityTestEnvironment After successfully migrating the ProcessDiceHeaderDelegateImpl we can complete the job by also migrating the unit test. Several fake objects were removed in favour of IdentityTestEnvironment which also provides an IdentityManager. Bug: 890791 Change-Id: Ie689268b0b9e2569a4cce5c4abe645d3daa82c7e Reviewed-on: https://chromium-review.googlesource.com/c/1282743 Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#599985} [modify] https://crrev.com/4cdc95ad6713e3ba3eec5d245a0e41c34ddee003/chrome/browser/signin/process_dice_header_delegate_impl_unittest.cc
,
Oct 16
Now closing. |
||
►
Sign in to add a comment |
||
Comment 1 by svil...@igalia.com
, Oct 12Status: Started (was: Available)