New issue
Advanced search Search tips

Issue 890788 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 23
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task

Blocking:
issue 883330



Sign in to add a comment

Convert chrome/browser/signin/chrome_signin_status_metrics_provider_delegate.cc to IdentityManager

Project Member Reported by sdefresne@chromium.org, Oct 1

Issue description

API used:
- SigninManager::IsAuthenticated()

 
Owner: toniki...@igalia.com
Status: Started (was: Available)
Owner: toniki...@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53ed3f8565a6ff168da09f1afd62ac9c0ed824a2

commit 53ed3f8565a6ff168da09f1afd62ac9c0ed824a2
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Tue Oct 23 12:30:14 2018

[s13n] Migrate ChromeSigninStatusMetricsProviderDelegate away from using SigninManager APIs

As part of the s13n effort to migrate users of SigninManager APIs in
favor of using the associated IdentityManager APIs, this is a
straightforward CL that replaces uses of SigninManager::IsAuthenticated()
to IdentityManager->HasPrimaryAccount().

BUG= 890788 

Change-Id: I0d83e058a6cc641c3e3b98b36803bf7854b36ac3
Reviewed-on: https://chromium-review.googlesource.com/c/1291669
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#601916}
[modify] https://crrev.com/53ed3f8565a6ff168da09f1afd62ac9c0ed824a2/chrome/browser/signin/chrome_signin_status_metrics_provider_delegate.cc

Status: Fixed (was: Started)

Sign in to add a comment