Convert chrome/browser/printing/cloud_print/privet_notifications.cc to IdentityManager |
|||
Issue descriptionAPI used: - SigninManager::IsAuthenticated()
,
Oct 15
,
Oct 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1268fb7464a6b3c2185078bf937da439ce1c5387 commit 1268fb7464a6b3c2185078bf937da439ce1c5387 Author: Sergio Villar Senin <svillar@igalia.com> Date: Mon Oct 15 14:52:12 2018 Convert cloud_print/privet_notifications.cc to IdentityManager It was using SigninManager API. Migrated to IdentityManager so it could eventually make use of the identity service. By the way, PrivetNotificationsFactory was lacking the dependency with the SigninManagerFactory. Adding the new one with IdentityManagerFactory instead. BUG= 890784 Change-Id: I0a3c3eb44ea28e8e388728b3e4e58841873057e4 Reviewed-on: https://chromium-review.googlesource.com/c/1278791 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#599638} [modify] https://crrev.com/1268fb7464a6b3c2185078bf937da439ce1c5387/chrome/browser/printing/cloud_print/privet_notifications.cc [modify] https://crrev.com/1268fb7464a6b3c2185078bf937da439ce1c5387/chrome/browser/printing/cloud_print/privet_notifications_factory.cc
,
Oct 16
Done! |
|||
►
Sign in to add a comment |
|||
Comment 1 by svil...@igalia.com
, Oct 12