New issue
Advanced search Search tips

Issue 890784 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 16
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task

Blocking:
issue 883330



Sign in to add a comment

Convert chrome/browser/printing/cloud_print/privet_notifications.cc to IdentityManager

Project Member Reported by sdefresne@chromium.org, Oct 1

Issue description

API used:
- SigninManager::IsAuthenticated()

 
Status: Started (was: Available)
Let's do this...
Owner: svil...@igalia.com
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1268fb7464a6b3c2185078bf937da439ce1c5387

commit 1268fb7464a6b3c2185078bf937da439ce1c5387
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Mon Oct 15 14:52:12 2018

Convert cloud_print/privet_notifications.cc to IdentityManager

It was using SigninManager API. Migrated to IdentityManager so it could
eventually make use of the identity service.

By the way, PrivetNotificationsFactory was lacking the dependency with
the SigninManagerFactory. Adding the new one with
IdentityManagerFactory instead.

BUG= 890784 

Change-Id: I0a3c3eb44ea28e8e388728b3e4e58841873057e4
Reviewed-on: https://chromium-review.googlesource.com/c/1278791
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599638}
[modify] https://crrev.com/1268fb7464a6b3c2185078bf937da439ce1c5387/chrome/browser/printing/cloud_print/privet_notifications.cc
[modify] https://crrev.com/1268fb7464a6b3c2185078bf937da439ce1c5387/chrome/browser/printing/cloud_print/privet_notifications_factory.cc

Status: Fixed (was: Started)
Done!

Sign in to add a comment