New issue
Advanced search Search tips

Issue 890778 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 30
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task

Blocking:
issue 883330



Sign in to add a comment

Convert chrome/browser/password_manager/password_store_factory.cc to IdentityManager

Project Member Reported by sdefresne@chromium.org, Oct 1

Issue description

API used:
- SigninManagerBase::GetAuthenticatedAccountInfo()

 
Owner: svil...@igalia.com
Status: Started (was: Available)
Taking this...
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af1a3ed8daa9df82e663c064fc951f30e2777646

commit af1a3ed8daa9df82e663c064fc951f30e2777646
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Mon Oct 15 09:47:52 2018

Convert password_store_factory.cc to IdentityManager

It's currently using the SigninManager API to retrieve the currently
authenticated account's email. Replaced by the IdentityManager
equivalent API so it could eventually use the identity service.

Bug:  890778 
Change-Id: Icff574cb51ee2ae32bb0e5edc8f658c0061e0343
Reviewed-on: https://chromium-review.googlesource.com/c/1280265
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#599602}
[modify] https://crrev.com/af1a3ed8daa9df82e663c064fc951f30e2777646/chrome/browser/password_manager/password_store_factory.cc

Status: Fixed (was: Started)
Closing

Sign in to add a comment