New issue
Advanced search Search tips

Issue 890776 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 17
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task

Blocking:
issue 883330



Sign in to add a comment

Convert chrome/browser/feedback/show_feedback_page.cc to IdentityManager

Project Member Reported by sdefresne@chromium.org, Oct 1

Issue description

API used:
- SigninManagerBase::GetAuthenticatedAccountInfo()

 
Owner: svil...@igalia.com
Status: Started (was: Available)
Working on this...
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fb6527f91b382b411290de7307e0a233300dbdb

commit 7fb6527f91b382b411290de7307e0a233300dbdb
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Tue Oct 16 18:20:52 2018

Convert chrome/browser/feedback/show_feedback_page.cc to IdentityManager

It's currently using the SigninManager API to retrieve the currently
authenticated account's email. Replaced by the IdentityManager
equivalent API so it could eventually use the identity service.

Bug:  890776 
Change-Id: I2ed33724ec940d955fbe10bfbc1eaaea29ea473a
Reviewed-on: https://chromium-review.googlesource.com/c/1280276
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#600048}
[modify] https://crrev.com/7fb6527f91b382b411290de7307e0a233300dbdb/chrome/browser/feedback/show_feedback_page.cc

Status: Fixed (was: Started)
Fixed

Sign in to add a comment