Working on this

Hmm looks like it requires the migration of identity_api.cc first...

@sdefrene should we add another bug for that ?

The implementation of IdentityManager is still backed by the existing class. This mean that it should be possible to migrate the tests independently from the implementation.

For this test, it may be possible to convert it to use IdentityTestEnvironment, and thus remove dependency on ProfileOAuth2TokenService, GaiaCookieManagerService and AccountTrackerService in addition to SigninManager.

blundell: have you created another bug to remove uses of those services in this test?

I agree with Sylvain. I have not created another bug, so let's just use this one.

It looks like you'll need to add a public API to IdentityTestEnvironmentProfileAdaptor that returns the list of factories required by IdentityTestEnvironment. Once https://chromium-review.googlesource.com/c/chromium/src/+/1280764 lands, that will just be a matter of moving GetIdentityTestEnvironmentFactories into the public API from being inside the .cc file as it is now.

Does that make sense? As this test file is really large, you should feel free to convert it incrementally if it's too much to bite off to convert it all in one go.

 Issue 906615  has been merged into this issue.

Yikes, really sorry about this! Antonio and Sergio, I apologize if I caused you folks to do duplicate work, as it seems like Antonio also put a CL together here.

Hi.

I spoke to Sergio offline, and we agreed on continuing with the CL up for review in https://crrev.com/c/1343019.

Thanks, and sorry again about that!

(https://bugs.chromium.org/p/chromium/issues/detail?id=906615#c7)

Comment #7 on  issue 906615  by bugdroid1@chromium.org: Convert identity_apitest.cc to use IdentityTestEnvironment
https://bugs.chromium.org/p/chromium/issues/detail?id=906615#c7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa626b9fede1d7f3e04ef072615d9b40b81e9442

commit fa626b9fede1d7f3e04ef072615d9b40b81e9442
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Mon Nov 26 14:29:45 2018

[s13n] Convert identity_apitest.cc to use IdentityTestEnvironment

This bug is a follow up of [1] and [2], where production code
(//c/b/extensions/api/identity/identity_api.cc) is migrated away from
using PO2TS in favor of IdentityManager, and the API is extended to
accommodate the needs of this migration, respectively.

[1] https://crrev.com/b/1340890
[2] https://crrev.com/b/1346609

BUG= 906615 

Change-Id: Ib41f99f08b7d181bbcff28be97c8b55993aa8c04
Reviewed-on: https://chromium-review.googlesource.com/c/1343019
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610844}
[modify] https://crrev.com/fa626b9fede1d7f3e04ef072615d9b40b81e9442/chrome/browser/extensions/api/identity/identity_apitest.cc