Delete Legacy thread_times and smoothness metrics |
|||
Issue descriptionAll thread_times and smoothness metrics that we care about are implemented in TBMv2. This bug tracks the clean-up work to remove the legacy code.
,
Oct 3
,
Oct 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5cf2125afa9adeeda1b9eb8b9e75d5cc666d6870 commit 5cf2125afa9adeeda1b9eb8b9e75d5cc666d6870 Author: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Date: Wed Oct 03 14:50:35 2018 Telemetry: Migrate smoothness benchmarks We would like to deprecate smoothness metrics and replace them with equivalent TBMv2 rendering metrics. To prevent those changes from breaking benchmarks that use legacy smoothness metrics, this CL chanes those benchmarks to compute both legacy and equivalent TBMv2 metrics. After the transition is complete, we can just compute TBMv2 ones. Bug: 890757 Change-Id: I95203ec76a09be2273e4f71fe3e372e1ff04cc6d Reviewed-on: https://chromium-review.googlesource.com/c/1258213 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Cr-Commit-Position: refs/heads/master@{#596210} [modify] https://crrev.com/5cf2125afa9adeeda1b9eb8b9e75d5cc666d6870/tools/perf/measurements/rendering.py [modify] https://crrev.com/5cf2125afa9adeeda1b9eb8b9e75d5cc666d6870/tools/perf/measurements/rendering_unittest.py [add] https://crrev.com/5cf2125afa9adeeda1b9eb8b9e75d5cc666d6870/tools/perf/measurements/rendering_util.py [modify] https://crrev.com/5cf2125afa9adeeda1b9eb8b9e75d5cc666d6870/tools/perf/measurements/smoothness.py
,
Oct 3
,
Oct 3
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/929a7f4eba49faea05967904a06f5260472c652a commit 929a7f4eba49faea05967904a06f5260472c652a Author: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Date: Wed Oct 03 17:15:16 2018 Telemetry: clean up legacy surface flinger metrics This CL deletes legacy avg_surface_fps, jank_count, max_frame_delay, and frame_lengths metrics and replaces them with TBMv2 versions. Most metric names will be unchanged, for having continuity, except for max_frame_delay. The new name for max_frame_delay will be frame_length_max because it's a derivative metric (maximum of the frame_length histogram). There is no alert for this metric. So, the rename should not cause any sheriffing trouble. To compare old/new metrics please see the following links. Webview: https://chromeperf.appspot.com/report?sid=e0157b4ab1bcaa35e1be0e9264c35a508c405454500ddaf67ea29fba9193aedd Nexux 5x: https://chromeperf.appspot.com/report?sid=99f75786b80c3cd8020dabdaabbf898b519e5a9a9d9e7ace33dc7f267bf57924 Bug: chromium:890757 Change-Id: I2e950be6edca0d1a24cd672209e4754242d2ca70 Reviewed-on: https://chromium-review.googlesource.com/1258877 Reviewed-by: Timothy Dresser <tdresser@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Ben Hayden <benjhayden@chromium.org> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> [modify] https://crrev.com/929a7f4eba49faea05967904a06f5260472c652a/tracing/tracing/metrics/rendering/frame_time.html [modify] https://crrev.com/929a7f4eba49faea05967904a06f5260472c652a/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py [modify] https://crrev.com/929a7f4eba49faea05967904a06f5260472c652a/telemetry/telemetry/web_perf/metrics/rendering_stats.py [modify] https://crrev.com/929a7f4eba49faea05967904a06f5260472c652a/telemetry/telemetry/web_perf/metrics/smoothness_unittest.py [modify] https://crrev.com/929a7f4eba49faea05967904a06f5260472c652a/tracing/tracing/metrics/rendering/frame_time_test.html [modify] https://crrev.com/929a7f4eba49faea05967904a06f5260472c652a/telemetry/telemetry/web_perf/metrics/smoothness.py
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8fbe05fb32cf430baa5ff7f13704f6bee7abeab4 commit 8fbe05fb32cf430baa5ff7f13704f6bee7abeab4 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Oct 04 03:52:41 2018 Roll src/third_party/catapult 2dd914402ebc..0543f082e2f4 (7 commits) https://chromium.googlesource.com/catapult.git/+log/2dd914402ebc..0543f082e2f4 git log 2dd914402ebc..0543f082e2f4 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 khmel@chromium.org Fix flakiness of tests, that require GAIA login. 2018-10-03 kylechar@chromium.org Support macOS 10.14 Mojave. 2018-10-03 zmo@chromium.org Revert "Wire action_runner's Click through DevTools" 2018-10-03 chiniforooshan@chromium.org Telemetry: clean up legacy surface flinger metrics 2018-10-03 pasko@chromium.org androidStartupMetric: skip the first start 2018-10-03 benjhayden@chromium.org Fix flaky cp-toast.autoclose-only-last test. 2018-10-03 zmo@chromium.org Wire action_runner's Click through DevTools Created with: gclient setdep -r src/third_party/catapult@0543f082e2f4 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:879353 , chromium:890951 ,chromium:885912, chromium:890757 , chromium:881384 ,chromium:885912 TBR=sullivan@chromium.org Change-Id: I6e2ae7a29df4dcab18c0cde1e852ee159a3f12cf Reviewed-on: https://chromium-review.googlesource.com/c/1260146 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596495} [modify] https://crrev.com/8fbe05fb32cf430baa5ff7f13704f6bee7abeab4/DEPS
,
Oct 5
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/56216d7832a46730d5d9d6bba7fa5742d9601390 commit 56216d7832a46730d5d9d6bba7fa5742d9601390 Author: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Date: Fri Oct 05 03:10:57 2018 Telemetry: pixel approximated/checkerboarded This deletes legacy mean_{pixels_approximated/checkerboarded} metrics and replaces them with TBMv2 versions. Please see the following links for comparing old/new metrics on random stories: desktop: https://chromeperf.appspot.com/report?sid=1a8996aafc29a22ff31d6f22e5bb07a8adef249796e822ffeaad3b63202533e9&start_rev=585066&end_rev=596584 mobile: https://chromeperf.appspot.com/report?sid=60c2396242617fc540bb907c9b8441827f838113fbba9a677a1baa1fe893a336&start_rev=591600&end_rev=596657 The metrics are different by a factor of x100. I think the old versions multiply the result by 100 by mistake. That can explain why we see above 100% pixels checkerboarded sometimes, e.g.: https://v2spa-dot-chromeperf.appspot.com/#session=8eef13224b1d1e25790cd2475bec701b420a96da0f66baa2aca226f3a6f98c73 Bug: chromium:890757 Change-Id: If2d03456ea431bf1fd3838af5a52f38f4cac17f5 Reviewed-on: https://chromium-review.googlesource.com/c/1262018 Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Ben Hayden <benjhayden@chromium.org> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> [modify] https://crrev.com/56216d7832a46730d5d9d6bba7fa5742d9601390/tracing/tracing/metrics/rendering/pixels.html [modify] https://crrev.com/56216d7832a46730d5d9d6bba7fa5742d9601390/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py [modify] https://crrev.com/56216d7832a46730d5d9d6bba7fa5742d9601390/telemetry/telemetry/web_perf/metrics/rendering_stats.py [modify] https://crrev.com/56216d7832a46730d5d9d6bba7fa5742d9601390/tracing/tracing/metrics/rendering/pixels_test.html [modify] https://crrev.com/56216d7832a46730d5d9d6bba7fa5742d9601390/telemetry/telemetry/web_perf/metrics/smoothness_unittest.py [modify] https://crrev.com/56216d7832a46730d5d9d6bba7fa5742d9601390/telemetry/telemetry/web_perf/metrics/smoothness.py
,
Oct 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84f9167ca06c316950a8f0eb12d6d55244769859 commit 84f9167ca06c316950a8f0eb12d6d55244769859 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Oct 05 05:20:13 2018 Roll src/third_party/catapult a7a24422d086..56216d7832a4 (1 commits) https://chromium.googlesource.com/catapult.git/+log/a7a24422d086..56216d7832a4 git log a7a24422d086..56216d7832a4 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 chiniforooshan@chromium.org Telemetry: pixel approximated/checkerboarded Created with: gclient setdep -r src/third_party/catapult@56216d7832a4 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:890757 TBR=sullivan@chromium.org Change-Id: I00fdd306c02a5ff45b9706d9664e45bed98bec4f Reviewed-on: https://chromium-review.googlesource.com/c/1263862 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597000} [modify] https://crrev.com/84f9167ca06c316950a8f0eb12d6d55244769859/DEPS
,
Oct 11
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/0480f8caeb27101608c99e4df2f686d6697551f4 commit 0480f8caeb27101608c99e4df2f686d6697551f4 Author: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Date: Thu Oct 11 17:16:47 2018 Telemetry: migrate frame_times & percentage_smooth This migrates frame_times_tbmv2 to frame_times and smooth_frames to percentage_smooth. The rename for smooth_frames is for continuity of graphs in perf dashboard. We can rename the metric if we want later and migrate data. This migration also fixes crbug.com/892385 To compare old/new values: https://v2spa-dot-chromeperf.appspot.com/#session=2ba522d010d5e4a81b1bfa24be6d8d5a2e29ff6d49af15721377314c49a4ea1d Bug: chromium:890757 Bug: chromium:892385 Change-Id: If5411c66b753ccaaa62543e886c423f338667619 Reviewed-on: https://chromium-review.googlesource.com/c/1264176 Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Ben Hayden <benjhayden@chromium.org> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> [modify] https://crrev.com/0480f8caeb27101608c99e4df2f686d6697551f4/tracing/tracing/metrics/rendering/frame_time.html [modify] https://crrev.com/0480f8caeb27101608c99e4df2f686d6697551f4/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py [modify] https://crrev.com/0480f8caeb27101608c99e4df2f686d6697551f4/telemetry/telemetry/web_perf/metrics/rendering_stats.py [modify] https://crrev.com/0480f8caeb27101608c99e4df2f686d6697551f4/telemetry/telemetry/web_perf/metrics/smoothness_unittest.py [modify] https://crrev.com/0480f8caeb27101608c99e4df2f686d6697551f4/tracing/tracing/metrics/rendering/frame_time_test.html [modify] https://crrev.com/0480f8caeb27101608c99e4df2f686d6697551f4/tracing/tracing/metrics/rendering/rendering_metric_test.html [modify] https://crrev.com/0480f8caeb27101608c99e4df2f686d6697551f4/telemetry/telemetry/web_perf/metrics/smoothness.py
,
Oct 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb11cbc66e56a475bdf0f5bf3d962cf80c3afe27 commit bb11cbc66e56a475bdf0f5bf3d962cf80c3afe27 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Oct 12 22:54:58 2018 Roll src/third_party/catapult c8b97e37ec9c..99b88b0a2d58 (21 commits) https://chromium.googlesource.com/catapult.git/+log/c8b97e37ec9c..99b88b0a2d58 git log c8b97e37ec9c..99b88b0a2d58 --date=short --no-merges --format='%ad %ae %s' 2018-10-12 simonhatch@chromium.org Pinpoint - Merge bugs with same root cause. 2018-10-12 benjhayden@chromium.org Change deprecation warnings in /api/alerts to errors. 2018-10-12 benjhayden@chromium.org Cache report names, test suites, and descriptors in v2spa service worker 2018-10-12 chiniforooshan@chromium.org Telemetry: process all rendering pipeline events 2018-10-12 benjhayden@chromium.org Cache session ids in v2spa service worker. 2018-10-12 benjhayden@chromium.org Fix links in rollback.md 2018-10-12 benjhayden@chromium.org Add KeyValueCacheRequest for v2spa service worker. 2018-10-12 benjhayden@chromium.org Add ts_mon metrics to common/timing.py 2018-10-12 benjhayden@chromium.org Add CacheRequestBase for v2spa service worker. 2018-10-12 nednguyen@google.com [Telemetry] Add --test-filter flag that support exact matching of multiple tests 2018-10-12 sadrul@chromium.org rendering: Generate metrics at the 95%ile. 2018-10-12 pasko@chromium.org androidStartupMetric: re-introduce First Contentful Paint 2018-10-12 chrishtr@chromium.org Clean up categories to match current tracing in Blink. 2018-10-11 jbudorick@chromium.org Revert "Enable orderfile memory optimization in benchmarks" 2018-10-11 benjhayden@chromium.org Add task queue for v2spa service worker. 2018-10-11 benjhayden@chromium.org Remove unnecessary file dashboard/test/index.html 2018-10-11 perezju@chromium.org [soundwave] Allow points with missing r_chromium 2018-10-11 chiniforooshan@chromium.org Telemetry: migrate frame_times & percentage_smooth 2018-10-11 ulan@chromium.org [tracing] Restore the minimum mutator utilization metric. 2018-10-11 seanmccullough@chromium.org [chromeperf] add prefix to wct script so tests get found. 2018-10-11 pasko@chromium.org Enable orderfile memory optimization in benchmarks Created with: gclient setdep -r src/third_party/catapult@99b88b0a2d58 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:840872, chromium:893199 ,chromium:867060,chromium:894261,chromium:894287, chromium:886621 ,chromium:893514,chromium:758566, chromium:879526 , chromium:890757 , chromium:892385 , chromium:877660 ,chromium:758566 TBR=sullivan@chromium.org Change-Id: I469ed20d66790fa12e290ad65e2ea51c16cfdba7 Reviewed-on: https://chromium-review.googlesource.com/c/1279078 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599392} [modify] https://crrev.com/bb11cbc66e56a475bdf0f5bf3d962cf80c3afe27/DEPS
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/df56c1dae15e3d365ab4d62eb7f07522d70f64c5 commit df56c1dae15e3d365ab4d62eb7f07522d70f64c5 Author: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Date: Tue Oct 23 18:00:12 2018 Telemetry: detect telemetry target renderers In this change we detect the "target" renderer, that Telemetry scripts create and run JS on, to be used in queueing_duration. Since this will add to Telemetry-related logic in rendering_metric.html, we also factor out Telemetry-related logic in a separated helper. Also, rendererWithLargestPid in chrome_model_helper.html is supposed to do a similar thing, but in a hackier way. It is not used anywhere. So, we delete it. Bug: chromium:890757 Change-Id: I83397a7b2f5601a211396ff74e2cc4c0de7ae1ca Reviewed-on: https://chromium-review.googlesource.com/c/1291889 Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Reviewed-by: Ben Hayden <benjhayden@chromium.org> [modify] https://crrev.com/df56c1dae15e3d365ab4d62eb7f07522d70f64c5/tracing/tracing/metrics/rendering/rendering_metric.html [modify] https://crrev.com/df56c1dae15e3d365ab4d62eb7f07522d70f64c5/tracing/tracing/metrics/rendering/queueing_duration.html [add] https://crrev.com/df56c1dae15e3d365ab4d62eb7f07522d70f64c5/tracing/tracing/model/helpers/telemetry_helper_test.html [modify] https://crrev.com/df56c1dae15e3d365ab4d62eb7f07522d70f64c5/tracing/tracing/model/helpers/chrome_model_helper.html [modify] https://crrev.com/df56c1dae15e3d365ab4d62eb7f07522d70f64c5/tracing/trace_viewer.gni [add] https://crrev.com/df56c1dae15e3d365ab4d62eb7f07522d70f64c5/tracing/tracing/model/helpers/telemetry_helper.html [modify] https://crrev.com/df56c1dae15e3d365ab4d62eb7f07522d70f64c5/tracing/tracing/metrics/rendering/rendering_metric_test.html
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/c6a85907fbdd620e996caf2b3d80081603c7e807 commit c6a85907fbdd620e996caf2b3d80081603c7e807 Author: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Date: Tue Oct 23 19:00:40 2018 Telemetry: migrate the rest of smoothness metrics Comparison of old/new values on some bots and stories: https://v2spa-dot-chromeperf.appspot.com/#session=fe1a41a6418d0eb04bac04eb32ef1948c9566f5c955f33ef5f3d01fb9e295bd6 Bug: chromium:890757 Change-Id: I1c5decc49231c39b00dad46f47ba855a66c6bad8 Reviewed-on: https://chromium-review.googlesource.com/c/1286371 Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Reviewed-by: Ben Hayden <benjhayden@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> [delete] https://crrev.com/df56c1dae15e3d365ab4d62eb7f07522d70f64c5/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py [modify] https://crrev.com/c6a85907fbdd620e996caf2b3d80081603c7e807/tracing/tracing/metrics/rendering/queueing_duration_test.html [delete] https://crrev.com/df56c1dae15e3d365ab4d62eb7f07522d70f64c5/telemetry/telemetry/web_perf/metrics/rendering_stats.py [modify] https://crrev.com/c6a85907fbdd620e996caf2b3d80081603c7e807/tracing/tracing/metrics/rendering/latency_test.html [delete] https://crrev.com/df56c1dae15e3d365ab4d62eb7f07522d70f64c5/telemetry/telemetry/web_perf/metrics/smoothness_unittest.py [modify] https://crrev.com/c6a85907fbdd620e996caf2b3d80081603c7e807/tracing/tracing/metrics/rendering/queueing_duration.html [modify] https://crrev.com/c6a85907fbdd620e996caf2b3d80081603c7e807/tracing/tracing/metrics/rendering/latency.html [delete] https://crrev.com/df56c1dae15e3d365ab4d62eb7f07522d70f64c5/telemetry/telemetry/web_perf/metrics/rendering_frame_unittest.py [delete] https://crrev.com/df56c1dae15e3d365ab4d62eb7f07522d70f64c5/telemetry/telemetry/web_perf/metrics/rendering_frame.py [modify] https://crrev.com/c6a85907fbdd620e996caf2b3d80081603c7e807/telemetry/telemetry/web_perf/metrics/smoothness.py
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ce66e47db01e72b09e91d1775039553d3d86c6e commit 6ce66e47db01e72b09e91d1775039553d3d86c6e Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Oct 23 19:43:59 2018 Roll src/third_party/catapult 7d5d4ab1dd6f..df56c1dae15e (1 commits) https://chromium.googlesource.com/catapult.git/+log/7d5d4ab1dd6f..df56c1dae15e git log 7d5d4ab1dd6f..df56c1dae15e --date=short --no-merges --format='%ad %ae %s' 2018-10-23 chiniforooshan@chromium.org Telemetry: detect telemetry target renderers Created with: gclient setdep -r src/third_party/catapult@df56c1dae15e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:890757 TBR=sullivan@chromium.org Change-Id: I990e0cd37b20572248f5c1699b002cd3ba6adf50 Reviewed-on: https://chromium-review.googlesource.com/c/1297112 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602060} [modify] https://crrev.com/6ce66e47db01e72b09e91d1775039553d3d86c6e/DEPS
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d27585c373be6f346af56dbefc38b13ca97cda40 commit d27585c373be6f346af56dbefc38b13ca97cda40 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Oct 24 00:41:14 2018 Roll src/third_party/catapult df56c1dae15e..c6a85907fbdd (1 commits) https://chromium.googlesource.com/catapult.git/+log/df56c1dae15e..c6a85907fbdd git log df56c1dae15e..c6a85907fbdd --date=short --no-merges --format='%ad %ae %s' 2018-10-23 chiniforooshan@chromium.org Telemetry: migrate the rest of smoothness metrics Created with: gclient setdep -r src/third_party/catapult@c6a85907fbdd The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:890757 TBR=sullivan@chromium.org Change-Id: Iddd7892c6226646ce5766c4faf1c6f9f624bcf9a Reviewed-on: https://chromium-review.googlesource.com/c/1297271 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602189} [modify] https://crrev.com/d27585c373be6f346af56dbefc38b13ca97cda40/DEPS
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/006d5c21056e7dd1be62755ca9a8d35f0d70291a commit 006d5c21056e7dd1be62755ca9a8d35f0d70291a Author: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Date: Wed Oct 24 02:48:29 2018 Telemetry: remove smoothness measurement This should be submitted after https://chromium-review.googlesource.com/c/catapult/+/1286371 Bug: 890757 Change-Id: I1185895b778024fd8c2f64a6597899cb717c6610 Reviewed-on: https://chromium-review.googlesource.com/c/1287029 Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Ravi Mistry <rmistry@chromium.org> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#602227} [modify] https://crrev.com/006d5c21056e7dd1be62755ca9a8d35f0d70291a/tools/perf/benchmarks/smoothness.py [delete] https://crrev.com/8ae18f7b2f42e8528aef24f434db91fb3e15d112/tools/perf/contrib/cluster_telemetry/repaint_unittest.py [modify] https://crrev.com/006d5c21056e7dd1be62755ca9a8d35f0d70291a/tools/perf/contrib/cros_benchmarks/ui_smoothness_bench.py [modify] https://crrev.com/006d5c21056e7dd1be62755ca9a8d35f0d70291a/tools/perf/contrib/vr_benchmarks/vr_benchmarks.py [modify] https://crrev.com/006d5c21056e7dd1be62755ca9a8d35f0d70291a/tools/perf/measurements/rendering.py [delete] https://crrev.com/8ae18f7b2f42e8528aef24f434db91fb3e15d112/tools/perf/measurements/smoothness.py [delete] https://crrev.com/8ae18f7b2f42e8528aef24f434db91fb3e15d112/tools/perf/measurements/smoothness_unittest.py
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b9d773473df1bc55602efef6ffae306b16313020 commit b9d773473df1bc55602efef6ffae306b16313020 Author: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Date: Tue Oct 30 15:00:41 2018 Telemetry: remove unused code The perf dashboard shows that we are not generating data for any of the thread_times.* benchmarks since early June. This CL deletes the unused benchmarks. Bug: 890757 Change-Id: I9101fbf59ded8d3b749ed95f5ac46c8c8ada3b73 Reviewed-on: https://chromium-review.googlesource.com/c/1306175 Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Reviewed-by: enne <enne@chromium.org> Reviewed-by: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#603896} [delete] https://crrev.com/1ce3a7284c8a38593fb0c38a7b45120a26c48f02/tools/perf/benchmarks/thread_times.py [delete] https://crrev.com/1ce3a7284c8a38593fb0c38a7b45120a26c48f02/tools/perf/contrib/oop_raster/OWNERS [delete] https://crrev.com/1ce3a7284c8a38593fb0c38a7b45120a26c48f02/tools/perf/contrib/oop_raster/__init__.py [delete] https://crrev.com/1ce3a7284c8a38593fb0c38a7b45120a26c48f02/tools/perf/contrib/oop_raster/oop_raster.py [delete] https://crrev.com/1ce3a7284c8a38593fb0c38a7b45120a26c48f02/tools/perf/measurements/thread_times.py [delete] https://crrev.com/1ce3a7284c8a38593fb0c38a7b45120a26c48f02/tools/perf/measurements/thread_times_unittest.py [delete] https://crrev.com/1ce3a7284c8a38593fb0c38a7b45120a26c48f02/tools/perf/measurements/timeline_controller.py
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/827328d9d6c232818709b0f4e6862c8a70ef26c9 commit 827328d9d6c232818709b0f4e6862c8a70ef26c9 Author: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Date: Wed Oct 31 16:36:48 2018 Telemetry: don't test for both TBMv1 and TBMv2 We are merging TBMv1 and TBMv2 metrics and no longer have two versions of every metric. Bug: 890757 Change-Id: Ia304e7fa10d3abcf480d511751b16addab130713 Reviewed-on: https://chromium-review.googlesource.com/c/1309995 Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#604289} [modify] https://crrev.com/827328d9d6c232818709b0f4e6862c8a70ef26c9/tools/perf/measurements/rendering_unittest.py
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b130e0856063d3b647481be55f9f22a81031a045 commit b130e0856063d3b647481be55f9f22a81031a045 Author: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Date: Thu Nov 01 15:42:21 2018 Telemetry: preparation for deleting timeline.py We have TBMv2 versions of thread_times metrics, implemented in the Catapult repo in tracing/tracing/metrics/rendering. The legacy code for these metrics live in the Chromium repo in tools/perf/metrics/timeline.py. In order to not have a pause in the perf dashboard when we replace metrics defined in the Chromium repo with the ones defined in the Catapult repo, we plan to: 1- (this CL) modify the AddTBMv2RenderingMetrics function to behave when both metrics (with the same name) exist, 2- for all (groups of) thread times metrics: 2.1- rename the TBMv2 version, in the Catapult repo, to have the same name as the legacy metric, 2.2- delete the legacy metric, from the Chromium repo. 3- and, finally, delete the rendering measurement and rendering_util, and completely move to TBMv2. Bug: 890757 Change-Id: Iafb84d3ec0f732177005651e0b54b8dccb307c65 Reviewed-on: https://chromium-review.googlesource.com/c/1307838 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Cr-Commit-Position: refs/heads/master@{#604592} [modify] https://crrev.com/b130e0856063d3b647481be55f9f22a81031a045/tools/perf/measurements/rendering_util.py
,
Nov 2
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/a8f088180a1ccd86ff3fc50fcd1e666e97aa8392 commit a8f088180a1ccd86ff3fc50fcd1e666e97aa8392 Author: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Date: Fri Nov 02 15:23:44 2018 Telemetry: migrate thread_*_cpu_time_per_frame For comparing TBMv1 and TBMv2 versions so far: Linux: https://chromeperf.appspot.com/report?sid=f27e7308feb3b2230af469d8c4944f200ae106b98031817aad93e07df394c8fc&start_rev=595355&end_rev=603892 Win: https://chromeperf.appspot.com/report?sid=3f30f24c05f5c4c7f7346dff25499ad3fd5a4afd2843ca663e6be54be005b7a2&start_rev=601407&end_rev=603790 Android: https://chromeperf.appspot.com/report?sid=46d589df1e870651b3278641871a88327691baae9d7edd9a43f433b643d8132e&start_rev=599484&end_rev=603904 As can be seen in above graphs, the values are shifted (mainly on desktop). The reason is that TBMv1 versions use renderer compositor frames to compute these metrics, while TBMv2 versions use display compositor frames. crbug.com/888551 explains why the latter is preferred. I have included frame_times (display compositor) vs mean_frame_time_renderer_compositor graphs in the above-mentioned links, too, for verification. We could use the same "wrong" definition in the TBMv2 to avoid jumps in perf dashboard graphs for now, but that requires a major code change; and it will be temporary. I suggest we land this and copy TBMv2 history over. I will file a bug for it after this lands. Bug: chromium:890757 Change-Id: I5175e971d1768ffaa01a507591594b560d55f337 Reviewed-on: https://chromium-review.googlesource.com/c/1308815 Reviewed-by: Ben Hayden <benjhayden@chromium.org> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> [modify] https://crrev.com/a8f088180a1ccd86ff3fc50fcd1e666e97aa8392/tracing/tracing/metrics/rendering/cpu_utilization_test.html [modify] https://crrev.com/a8f088180a1ccd86ff3fc50fcd1e666e97aa8392/tracing/tracing/metrics/rendering/cpu_utilization.html
,
Nov 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/661fddf6f497b0392411d47198312c0b39608736 commit 661fddf6f497b0392411d47198312c0b39608736 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Nov 02 18:11:14 2018 Roll src/third_party/catapult a6ef719b69f4..a8f088180a1c (2 commits) https://chromium.googlesource.com/catapult.git/+log/a6ef719b69f4..a8f088180a1c git log a6ef719b69f4..a8f088180a1c --date=short --no-merges --format='%ad %ae %s' 2018-11-02 chiniforooshan@chromium.org Telemetry: migrate thread_*_cpu_time_per_frame 2018-11-02 erikchen@chromium.org [Reland 1] ADB commands should only retry errors, not exceptions. Created with: gclient setdep -r src/third_party/catapult@a8f088180a1c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:890757 , chromium:895027 TBR=sullivan@chromium.org Change-Id: I070af3f6172541300ce6dc4d5ac183f117dd1db6 Reviewed-on: https://chromium-review.googlesource.com/c/1315408 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604985} [modify] https://crrev.com/661fddf6f497b0392411d47198312c0b39608736/DEPS
,
Nov 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af5198be3516b3e7e5f54e9cdf6dc2882e1e4100 commit af5198be3516b3e7e5f54e9cdf6dc2882e1e4100 Author: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Date: Fri Nov 02 19:37:50 2018 Telemetry: remove old cpu_per_frame metrics TBMv2 versions are added in https://chromium-review.googlesource.com/c/catapult/+/1308815 Bug: 890757 Change-Id: If9f56016acbcd7f218a4e5516dcd74d0ae1a5327 Reviewed-on: https://chromium-review.googlesource.com/c/1313548 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Cr-Commit-Position: refs/heads/master@{#605016} [modify] https://crrev.com/af5198be3516b3e7e5f54e9cdf6dc2882e1e4100/tools/perf/metrics/timeline.py [modify] https://crrev.com/af5198be3516b3e7e5f54e9cdf6dc2882e1e4100/tools/perf/metrics/timeline_unittest.py
,
Nov 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05af02c8afe6a0fdc3d5e32ff88632fa15f5c567 commit 05af02c8afe6a0fdc3d5e32ff88632fa15f5c567 Author: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Date: Tue Nov 06 17:14:46 2018 Telemetry: finally move rendering to TBMv2 tasks_per_frame metrics are added in https://chromium-review.googlesource.com/c/catapult/+/1318249. mean_frame_time metrics are deleted since we already frame_times for display compositor frames and we decided to not use renderer compositor frames in crbug.com/888551 . Bug: 890757 Change-Id: Ib4d0b9cedc4f1012873f82da01839b9173d4e6dd Reviewed-on: https://chromium-review.googlesource.com/c/1318395 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Cr-Commit-Position: refs/heads/master@{#605718} [modify] https://crrev.com/05af02c8afe6a0fdc3d5e32ff88632fa15f5c567/tools/perf/benchmarks/rendering.py [modify] https://crrev.com/05af02c8afe6a0fdc3d5e32ff88632fa15f5c567/tools/perf/contrib/cluster_telemetry/rendering_ct.py [modify] https://crrev.com/05af02c8afe6a0fdc3d5e32ff88632fa15f5c567/tools/perf/contrib/cluster_telemetry/repaint.py [delete] https://crrev.com/168554a77f99988f976626b1605276d1e7279347/tools/perf/measurements/rendering.py [delete] https://crrev.com/168554a77f99988f976626b1605276d1e7279347/tools/perf/measurements/rendering_unittest.py [delete] https://crrev.com/168554a77f99988f976626b1605276d1e7279347/tools/perf/measurements/rendering_util.py [delete] https://crrev.com/168554a77f99988f976626b1605276d1e7279347/tools/perf/metrics/timeline.py [delete] https://crrev.com/168554a77f99988f976626b1605276d1e7279347/tools/perf/metrics/timeline_unittest.py
,
Nov 7
|
|||
►
Sign in to add a comment |
|||
Comment 1 by nednguyen@chromium.org
, Oct 1